From 28bb9321e2c55aa93097487e41c3aca95e0c106c Mon Sep 17 00:00:00 2001 From: Qiang Huang Date: Wed, 15 Jan 2014 12:09:26 +0800 Subject: [PATCH] cgroup.c: redefine the valid cgroup name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Qiang Huang Acked-by: Stéphane Graber --- src/lxc/cgroup.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c index 6d837f97e..69910cc65 100644 --- a/src/lxc/cgroup.c +++ b/src/lxc/cgroup.c @@ -1669,7 +1669,11 @@ bool is_valid_cgroup(const char *name) { const char *p; for (p = name; *p; p++) { - if (*p < 32 || *p == 127 || *p == '/') + /* Use the ASCII printable characters range(32 - 127) + * is reasonable, we kick out 32(SPACE) because it'll + * break legacy lxc-ls + */ + if (*p <= 32 || *p >= 127 || *p == '/') return false; } return strcmp(name, ".") != 0 && strcmp(name, "..") != 0;