proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-16 09:01:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

coverity: ovl_clonepaths: free osrc and ndelta on error paths

Browse Source 
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
This commit is contained in:
Serge Hallyn 2016-01-04 14:37:17 -08:00
parent 7d72b9596c
commit 278d97f74a
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/lxc/bdev/lxcoverlay.c
View File

@ -177,18 +177,26 @@ int ovl_clonepaths(struct bdev *orig, struct bdev *new, const char *oldname,
* up) * up)
*/ */
lastslash = strrchr(ndelta, '/'); lastslash = strrchr(ndelta, '/');
if (!lastslash) if (!lastslash) {
free(osrc);
free(ndelta);
return -1; return -1;
}
lastslash++; lastslash++;
lastslashidx = lastslash - ndelta; lastslashidx = lastslash - ndelta;
work = malloc(lastslashidx + 7); work = malloc(lastslashidx + 7);
if (!work) if (!work) {
free(osrc);
free(ndelta);
return -1; return -1;
}
strncpy(work, ndelta, lastslashidx + 1); strncpy(work, ndelta, lastslashidx + 1);
strcpy(work + lastslashidx, "olwork"); strcpy(work + lastslashidx, "olwork");
if ((mkdir(work, 0755) < 0) && errno != EEXIST) { if ((mkdir(work, 0755) < 0) && errno != EEXIST) {
SYSERROR("error: mkdir %s", work); SYSERROR("error: mkdir %s", work);
free(osrc);
free(ndelta);
free(work); free(work);
return -1; return -1;
} }