proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-16 01:52:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

start: don't lock setting the state

Browse Source 
- setting the handler->state value is atomic on any POSIX implementation since
  we're dealing with an integer (enum/lxc_state_t)
- while the state clients are served it is not possible for lxc_set_state() to
  transition to the next state anyway so there's no danger in moving to the
  next state with clients missing it
- we only care about the list being modified

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
This commit is contained in:
Christian Brauner 2017-11-22 14:32:56 +01:00
parent f3a2945e88
commit 20144819c4
No known key found for this signature in database
GPG Key ID: 8EB056D53EECB12D
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lxc/start.c
View File

@ -341,14 +341,10 @@ static int lxc_serve_state_clients(const char *name,
struct state_client *client;
struct lxc_msg msg = {.type = lxc_msg_state, .value = state};
process_lock();
/* Only set state under process lock held so that we don't cause
* lxc_cmd_add_state_client() to miss a state.
*/
handler->state = state;
TRACE("Set container state to %s", lxc_state2str(state));
process_lock();
if (lxc_list_empty(&handler->state_clients)) {
TRACE("No state clients registered");
process_unlock();