mirror of
https://git.proxmox.com/git/mirror_iproute2
synced 2025-10-31 14:01:31 +00:00
f93134841e
RDMA has weak connection between PIDs and HW objects, because
the latter tied to file descriptors for their lifetime management.
The outcome of such connection is that for the following scenario,
the returned PID will be 0 (not-valid):
1. Create FD and context
2. Share it with ephemeral child
3. Create any object and exit that child
This flow was revealed in testing environment and of course real users
are not running such scenario, because it makes no sense at all in RDMA
world.
Let's do two changes in the code to support such workflow anyway:
1. Remove need to provide PID/kernel name. Code already supports it,
just need to remove extra validation.
2. Ball-out in case PID is 0.
Link: https://lore.kernel.org/linux-rdma/20191002123245.18153-2-leon@kernel.org
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
131 lines
3.7 KiB
C
131 lines
3.7 KiB
C
// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
|
|
/*
|
|
* res-mr.c RDMA tool
|
|
* Authors: Leon Romanovsky <leonro@mellanox.com>
|
|
*/
|
|
|
|
#include "res.h"
|
|
#include <inttypes.h>
|
|
|
|
static int res_mr_line(struct rd *rd, const char *name, int idx,
|
|
struct nlattr **nla_line)
|
|
{
|
|
uint32_t rkey = 0, lkey = 0;
|
|
uint64_t iova = 0, mrlen;
|
|
char *comm = NULL;
|
|
uint32_t pdn = 0;
|
|
uint32_t mrn = 0;
|
|
uint32_t pid = 0;
|
|
|
|
if (!nla_line[RDMA_NLDEV_ATTR_RES_MRLEN])
|
|
return MNL_CB_ERROR;
|
|
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_RKEY])
|
|
rkey = mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_RKEY]);
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_LKEY])
|
|
lkey = mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_LKEY]);
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_IOVA])
|
|
iova = mnl_attr_get_u64(nla_line[RDMA_NLDEV_ATTR_RES_IOVA]);
|
|
|
|
mrlen = mnl_attr_get_u64(nla_line[RDMA_NLDEV_ATTR_RES_MRLEN]);
|
|
if (rd_is_filtered_attr(rd, "mrlen", mrlen,
|
|
nla_line[RDMA_NLDEV_ATTR_RES_MRLEN]))
|
|
goto out;
|
|
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_PID]) {
|
|
pid = mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_PID]);
|
|
comm = get_task_name(pid);
|
|
}
|
|
|
|
if (rd_is_filtered_attr(rd, "pid", pid,
|
|
nla_line[RDMA_NLDEV_ATTR_RES_PID]))
|
|
goto out;
|
|
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_MRN])
|
|
mrn = mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_MRN]);
|
|
if (rd_is_filtered_attr(rd, "mrn", mrn,
|
|
nla_line[RDMA_NLDEV_ATTR_RES_MRN]))
|
|
goto out;
|
|
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_PDN])
|
|
pdn = mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_PDN]);
|
|
if (rd_is_filtered_attr(rd, "pdn", pdn,
|
|
nla_line[RDMA_NLDEV_ATTR_RES_PDN]))
|
|
goto out;
|
|
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME])
|
|
/* discard const from mnl_attr_get_str */
|
|
comm = (char *)mnl_attr_get_str(
|
|
nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME]);
|
|
|
|
if (rd->json_output)
|
|
jsonw_start_array(rd->jw);
|
|
|
|
print_dev(rd, idx, name);
|
|
res_print_uint(rd, "mrn", mrn, nla_line[RDMA_NLDEV_ATTR_RES_MRN]);
|
|
print_key(rd, "rkey", rkey, nla_line[RDMA_NLDEV_ATTR_RES_RKEY]);
|
|
print_key(rd, "lkey", lkey, nla_line[RDMA_NLDEV_ATTR_RES_LKEY]);
|
|
print_key(rd, "iova", iova, nla_line[RDMA_NLDEV_ATTR_RES_IOVA]);
|
|
res_print_uint(rd, "mrlen", mrlen, nla_line[RDMA_NLDEV_ATTR_RES_MRLEN]);
|
|
res_print_uint(rd, "pdn", pdn, nla_line[RDMA_NLDEV_ATTR_RES_PDN]);
|
|
res_print_uint(rd, "pid", pid, nla_line[RDMA_NLDEV_ATTR_RES_PID]);
|
|
print_comm(rd, comm, nla_line);
|
|
|
|
print_driver_table(rd, nla_line[RDMA_NLDEV_ATTR_DRIVER]);
|
|
newline(rd);
|
|
|
|
out:
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_PID])
|
|
free(comm);
|
|
return MNL_CB_OK;
|
|
}
|
|
|
|
int res_mr_idx_parse_cb(const struct nlmsghdr *nlh, void *data)
|
|
{
|
|
struct nlattr *tb[RDMA_NLDEV_ATTR_MAX] = {};
|
|
struct rd *rd = data;
|
|
const char *name;
|
|
uint32_t idx;
|
|
|
|
mnl_attr_parse(nlh, 0, rd_attr_cb, tb);
|
|
if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_DEV_NAME])
|
|
return MNL_CB_ERROR;
|
|
|
|
name = mnl_attr_get_str(tb[RDMA_NLDEV_ATTR_DEV_NAME]);
|
|
idx = mnl_attr_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]);
|
|
|
|
return res_mr_line(rd, name, idx, tb);
|
|
}
|
|
|
|
int res_mr_parse_cb(const struct nlmsghdr *nlh, void *data)
|
|
{
|
|
struct nlattr *tb[RDMA_NLDEV_ATTR_MAX] = {};
|
|
struct nlattr *nla_table, *nla_entry;
|
|
struct rd *rd = data;
|
|
int ret = MNL_CB_OK;
|
|
const char *name;
|
|
uint32_t idx;
|
|
|
|
mnl_attr_parse(nlh, 0, rd_attr_cb, tb);
|
|
if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_DEV_NAME] ||
|
|
!tb[RDMA_NLDEV_ATTR_RES_MR])
|
|
return MNL_CB_ERROR;
|
|
|
|
name = mnl_attr_get_str(tb[RDMA_NLDEV_ATTR_DEV_NAME]);
|
|
idx = mnl_attr_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]);
|
|
nla_table = tb[RDMA_NLDEV_ATTR_RES_MR];
|
|
|
|
mnl_attr_for_each_nested(nla_entry, nla_table) {
|
|
struct nlattr *nla_line[RDMA_NLDEV_ATTR_MAX] = {};
|
|
|
|
ret = mnl_attr_parse_nested(nla_entry, rd_attr_cb, nla_line);
|
|
if (ret != MNL_CB_OK)
|
|
break;
|
|
|
|
ret = res_mr_line(rd, name, idx, nla_line);
|
|
if (ret != MNL_CB_OK)
|
|
break;
|
|
}
|
|
return ret;
|
|
}
|