mirror of
https://git.proxmox.com/git/mirror_iproute2
synced 2025-10-19 08:38:58 +00:00
aa5bd6a252
Eric reported that, with 10 million sockets, ss -emoi (about 1000 bytes
output per socket) can easily lead to OOM (buffer would grow to 10GB of
memory).
Limit the maximum size of the buffer to five chunks, 1M each. Render and
flush buffers whenever we reach that.
This might make the resulting blocks slightly unaligned between them, with
occasional loss of readability on lines occurring every 5k to 50k sockets
approximately. Something like (from ss -tu):
[...]
CLOSE-WAIT 32 0 192.168.1.50:35232 10.0.0.1:https
ESTAB 0 0 192.168.1.50:53820 10.0.0.1:https
ESTAB 0 0 192.168.1.50:46924 10.0.0.1:https
CLOSE-WAIT 32 0 192.168.1.50:35228 10.0.0.1:https
[...]
However, I don't actually expect any human user to scroll through that
amount of sockets, so readability should be preserved when it matters.
The bulk of the diffstat comes from moving field_next() around, as we now
call render() from it. Functionally, this is implemented by six lines of
code, most of them in field_next().
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Fixes:
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| arpd.c | ||
| ifstat.c | ||
| lnstat_util.c | ||
| lnstat.c | ||
| lnstat.h | ||
| Makefile | ||
| nstat.c | ||
| rtacct.c | ||
| ss.c | ||
| ssfilter.h | ||
| ssfilter.y | ||