mirror_iproute2/tc/q_cbs.c
Matteo Croce 8589eb4efd treewide: refactor help messages
Every tool in the iproute2 package have one or more function to show
an help message to the user. Some of these functions print the help
line by line with a series of printf call, e.g. ip/xfrm_state.c does
60 fprintf calls.
If we group all the calls to a single one and just concatenate strings,
we save a lot of libc calls and thus object size. The size difference
of the compiled binaries calculated with bloat-o-meter is:

        ip/ip:
        add/remove: 0/0 grow/shrink: 5/15 up/down: 103/-4796 (-4693)
        Total: Before=672591, After=667898, chg -0.70%
        ip/rtmon:
        add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-54 (-54)
        Total: Before=48879, After=48825, chg -0.11%
        tc/tc:
        add/remove: 0/2 grow/shrink: 31/10 up/down: 882/-6133 (-5251)
        Total: Before=351912, After=346661, chg -1.49%
        bridge/bridge:
        add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-459 (-459)
        Total: Before=70502, After=70043, chg -0.65%
        misc/lnstat:
        add/remove: 0/1 grow/shrink: 1/0 up/down: 48/-486 (-438)
        Total: Before=9960, After=9522, chg -4.40%
        tipc/tipc:
        add/remove: 0/0 grow/shrink: 1/1 up/down: 18/-62 (-44)
        Total: Before=79182, After=79138, chg -0.06%

While at it, indent some strings which were starting at column 0,
and use tabs where possible, to have a consistent style across helps.

Signed-off-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
2019-05-20 14:35:07 -07:00

142 lines
3.4 KiB
C

/*
* q_cbs.c CBS.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version
* 2 of the License, or (at your option) any later version.
*
* Authors: Vinicius Costa Gomes <vinicius.gomes@intel.com>
*
*/
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <fcntl.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <arpa/inet.h>
#include <string.h>
#include "utils.h"
#include "tc_util.h"
static void explain(void)
{
fprintf(stderr,
"Usage: ... cbs hicredit BYTES locredit BYTES sendslope BPS idleslope BPS\n"
" [offload 0|1]\n");
}
static void explain1(const char *arg, const char *val)
{
fprintf(stderr, "cbs: illegal value for \"%s\": \"%s\"\n", arg, val);
}
static int cbs_parse_opt(struct qdisc_util *qu, int argc,
char **argv, struct nlmsghdr *n, const char *dev)
{
struct tc_cbs_qopt opt = {};
struct rtattr *tail;
while (argc > 0) {
if (matches(*argv, "offload") == 0) {
NEXT_ARG();
if (opt.offload) {
fprintf(stderr, "cbs: duplicate \"offload\" specification\n");
return -1;
}
if (get_u8(&opt.offload, *argv, 0)) {
explain1("offload", *argv);
return -1;
}
} else if (matches(*argv, "hicredit") == 0) {
NEXT_ARG();
if (opt.hicredit) {
fprintf(stderr, "cbs: duplicate \"hicredit\" specification\n");
return -1;
}
if (get_s32(&opt.hicredit, *argv, 0)) {
explain1("hicredit", *argv);
return -1;
}
} else if (matches(*argv, "locredit") == 0) {
NEXT_ARG();
if (opt.locredit) {
fprintf(stderr, "cbs: duplicate \"locredit\" specification\n");
return -1;
}
if (get_s32(&opt.locredit, *argv, 0)) {
explain1("locredit", *argv);
return -1;
}
} else if (matches(*argv, "sendslope") == 0) {
NEXT_ARG();
if (opt.sendslope) {
fprintf(stderr, "cbs: duplicate \"sendslope\" specification\n");
return -1;
}
if (get_s32(&opt.sendslope, *argv, 0)) {
explain1("sendslope", *argv);
return -1;
}
} else if (matches(*argv, "idleslope") == 0) {
NEXT_ARG();
if (opt.idleslope) {
fprintf(stderr, "cbs: duplicate \"idleslope\" specification\n");
return -1;
}
if (get_s32(&opt.idleslope, *argv, 0)) {
explain1("idleslope", *argv);
return -1;
}
} else if (strcmp(*argv, "help") == 0) {
explain();
return -1;
} else {
fprintf(stderr, "cbs: unknown parameter \"%s\"\n", *argv);
explain();
return -1;
}
argc--; argv++;
}
tail = addattr_nest(n, 1024, TCA_OPTIONS);
addattr_l(n, 2024, TCA_CBS_PARMS, &opt, sizeof(opt));
addattr_nest_end(n, tail);
return 0;
}
static int cbs_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
{
struct rtattr *tb[TCA_CBS_MAX+1];
struct tc_cbs_qopt *qopt;
if (opt == NULL)
return 0;
parse_rtattr_nested(tb, TCA_CBS_MAX, opt);
if (tb[TCA_CBS_PARMS] == NULL)
return -1;
qopt = RTA_DATA(tb[TCA_CBS_PARMS]);
if (RTA_PAYLOAD(tb[TCA_CBS_PARMS]) < sizeof(*qopt))
return -1;
fprintf(f, "hicredit %d ", qopt->hicredit);
fprintf(f, "locredit %d ", qopt->locredit);
fprintf(f, "sendslope %d ", qopt->sendslope);
fprintf(f, "idleslope %d ", qopt->idleslope);
fprintf(f, "offload %d ", qopt->offload);
return 0;
}
struct qdisc_util cbs_qdisc_util = {
.id = "cbs",
.parse_qopt = cbs_parse_opt,
.print_qopt = cbs_print_opt,
};