Commit Graph

13 Commits

Author SHA1 Message Date
Phil Sutter
f89bb0210f Replace malloc && memset by calloc
This only replaces occurrences where the newly allocated memory is
cleared completely afterwards, as in other cases it is a theoretical
performance hit although code would be cleaner this way.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
2016-07-20 12:05:24 -07:00
Stephen Hemminger
acd1e437be misc: fix style issues
More checkpatch spring cleaning
2016-03-21 11:56:36 -07:00
Stephen Hemminger
b90b773ca6 lnstat: fix error handling
Error handling was silent and had leaks.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
2015-12-30 17:28:11 -08:00
Phil Sutter
d572ed4d0a get rid of remaining -Wunused-result warnings
Although not fundamentally necessary to check return codes in these
spots, preventing the warnings will put new ones into focus.

Signed-off-by: Phil Sutter <phil@nwl.cc>
2015-11-29 11:48:24 -08:00
Phil Sutter
db3ef44c54 lnstat: review lnstat_update()
Instead of calling rewind() and fgets() before every call to
scan_lines(), move them into scan_lines() itself.

This should also fix compat mode, as before the second call to
scan_lines() the first line was skipped unconditionally.

Signed-off-by: Phil Sutter <phil@nwl.cc>
2015-11-29 11:48:24 -08:00
Stephen Hemminger
92de1c2c82 remove unnecessary checks for NULL before free
Since free(NULL) is a no-op, it is safe to remove unnecesary
if checks.
2015-07-21 10:49:54 -07:00
Stephen Hemminger
ae665a522b Remove trailing whitespace
Go through source files and remove all trailing whitespace

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
2006-12-05 10:10:22 -08:00
shemminger
7339c0bb74 Could you please apply this patch.
* Fix lnstat : First column should not be summed

Thank you

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
2005-09-01 18:11:03 +00:00
osdl.net!shemminger
f5f1a6c583 Fix sum of first field (entries).
(Logical change 1.172)
2005-03-18 19:40:19 +00:00
osdl.net!shemminger
4c74f032f6 need to sum all lines on smp machine.
(Logical change 1.171)
2005-03-16 23:29:15 +00:00
osdl.net!shemminger
4677a54983 add const to find_field
(Logical change 1.102)
2004-10-19 20:47:13 +00:00
osdl.net!shemminger
8b3c3abb63 Initial revision 2004-10-19 20:21:14 +00:00
osdl.net!shemminger
056eb9d8dd (Logical change 1.98) 2004-10-19 20:21:14 +00:00