David Ward
a77905ef6a
tc: gred: Print usage text if no arguments appear after "gred"
...
This is more helpful to the user, since the command takes two forms,
and the message that would otherwise appear about missing parameters
assumes one of those forms.
Signed-off-by: David Ward <david.ward@ll.mit.edu>
2015-05-21 14:16:03 -07:00
David Ward
d73e0408e2
tc: gred: Fix whitespace issues in code
...
Signed-off-by: David Ward <david.ward@ll.mit.edu>
2015-05-21 14:16:03 -07:00
David Ward
d93c909a4c
tc: red, gred: Notify when using the default value for "bandwidth"
...
The "bandwidth" parameter is optional, but ensure the user is aware
of its default value, to proactively avoid configuration problems.
Signed-off-by: David Ward <david.ward@ll.mit.edu>
2015-05-21 14:16:03 -07:00
David Ward
6c99695da2
tc: red, gred: Fix format specifier in burst size warning
...
burst is an unsigned value.
Signed-off-by: David Ward <david.ward@ll.mit.edu>
2015-05-21 14:16:03 -07:00
David Ward
9d9a67c756
tc: red, gred: Rename overloaded variable wlog
...
It is used when parsing three different parameters, only one of
which is Wlog. Change the name to make the code less confusing.
Signed-off-by: David Ward <david.ward@ll.mit.edu>
2015-05-21 14:16:03 -07:00
Stephen Hemminger
3d0b7439df
whitespace cleanup
...
Remove all trailing whitespace and space before tabs.
2014-12-20 15:47:17 -08:00
Eric Dumazet
1b6f0bb5be
gred: support TCA_GRED_MAX_P attribute
...
TCA_GRED_MAX_P permits to express high resolution probabilities.
New output (on 3.3+ kernel) :
disc gred 9442: root refcnt 17
DP:0 (prio 1) Average Queue 0b Measured Queue 0b
Packet drops: 0 (forced 0 early 0)
Packet totals: 20 (bytes 2584)
limit 31460b min 3000b max 9000b ewma 5 probability 0.05 Scell_log 15
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
2012-01-20 08:12:24 -08:00
Eric Dumazet
ab15aeacf5
red: make burst optional
...
Documentation advises to set burst to (min+min+max)/(3*avpkt)
Let tc do this automatically if user doesnt provide burst himself.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
2011-12-01 09:23:49 -08:00
Stephen Hemminger
cb4bd0ec8d
Fix GRED options clearing
...
Bug reported where priorities of GRED DP's are ignored.
The option parsing sets opt then memset was clearing these
values.
2010-08-25 09:04:55 -07:00
Florian Westphal
8d8de1139c
tc: remove stale code
...
remove unused #define and "ok" statements.
Signed-off-by: Florian Westphal <fwestphal@astaro.com>
2010-01-21 10:13:01 -08:00
Florian Westphal
ddf216c863
tc: red, gred, tbf: more helpful error messages
...
$ tc qdisc add dev eth1 root tbf
RTNETLINK answers: Invalid argument
$ tc qdisc add dev eth1 root red
RTNETLINK answers: Invalid argument
with patch:
$ tc qdisc add dev eth1 root red
Required parameter (min, max, burst, limit, avpkt) is missing
$ tc qdisc add dev eth1 root tbf
Usage: ... tbf limit BYTES burst BYTES[/BYTES] rate KBPS ...
Signed-off-by: Florian Westphal <fw@strlen.de>
2010-01-21 10:12:57 -08:00
Stephen Hemminger
1558971d43
fix handling of GRED DPs args
2009-05-26 15:58:05 -07:00
Stephen Hemminger
ebde878097
Allow default DP of zero in gred
...
To emulate WRED behaviour, allow default DP of zero.
2009-05-26 15:15:01 -07:00
Stephen Hemminger
ae665a522b
Remove trailing whitespace
...
Go through source files and remove all trailing whitespace
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
2006-12-05 10:10:22 -08:00
osdl.net!shemminger
a5a6f1e80d
more ifdef excession.
...
(Logical change 1.158)
2005-03-10 20:26:08 +00:00
osdl.net!shemminger
b7024f2ef5
get rid of some old ifdef'd out code.
...
(Logical change 1.157)
2005-03-10 20:22:50 +00:00
4!tgraf
3b3ecd31c1
Use parse_rtattr_nested
...
(Logical change 1.129)
2005-01-18 22:11:58 +00:00
4!tgraf
228569c3ff
Use NLMSG_TAIL
...
(Logical change 1.127)
2005-01-18 01:24:18 +00:00
net[shemminger]!kaber
95812b56a5
: prevent tc crashes
...
(Logical change 1.81)
2004-09-28 18:35:49 +00:00
osdl.net!shemminger
f2f99e2eef
no longer need xstats stub
...
(Logical change 1.77)
2004-08-31 17:45:21 +00:00
osdl.org!shemminger
aba5acdfdb
(Logical change 1.3)
2004-04-15 20:56:59 +00:00
osdl.org!shemminger
86fdf0e47b
Initial revision
2004-04-15 20:56:59 +00:00