proxmox-mirrors/mirror_iproute2
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_iproute2 synced 2025-10-06 02:18:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tc: m_connmark: fix action error messages

Browse Source 
action m_connmark returns error messages identifying itself as the
'simple' action instead of 'connmark' action. e.g.

tc filter add dev eth0 protocol all u32 match u32 0 0 flowid 1:1 \
	action connmark index wrong
simple: Illegal "index"
bad action parsing
parse_action: bad value (3:connmark)!
Illegal "action"

In what is most likely a copy/paste error from the simple action example
code, fix connmark error messages to identify themselves as coming from
connmark.

tc filter add dev eth0 protocol all u32 match u32 0 0 flowid 1:1 \
	action connmark index wrong
connmark: Illegal "index"
bad action parsing
parse_action: bad value (3:connmark)!
Illegal "action"

While we're here also fixup the 'Illegal "Zone"' error code to say
'Illegal "zone"' instead of 'Illegal "index"'

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Kevin 'ldir' Darbyshire-Bryant 2019-03-15 10:50:45 +00:00 committed by Stephen Hemminger
parent f36f8fe535
commit ef1e02e6ac
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tc/m_connmark.c
View File

@ -73,7 +73,7 @@ parse_connmark(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
if (matches(*argv, "zone") == 0) { if (matches(*argv, "zone") == 0) {
NEXT_ARG(); NEXT_ARG();
if (get_u16(&sel.zone, *argv, 10)) { if (get_u16(&sel.zone, *argv, 10)) {
fprintf(stderr, "simple: Illegal \"index\"\n"); fprintf(stderr, "connmark: Illegal \"zone\"\n");
return -1; return -1;
} }
argc--; argc--;
@ -87,7 +87,7 @@ parse_connmark(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
if (matches(*argv, "index") == 0) { if (matches(*argv, "index") == 0) {
NEXT_ARG(); NEXT_ARG();
if (get_u32(&sel.index, *argv, 10)) { if (get_u32(&sel.index, *argv, 10)) {
fprintf(stderr, "simple: Illegal \"index\"\n"); fprintf(stderr, "connmark: Illegal \"index\"\n");
return -1; return -1;
} }
argc--; argc--;