proxmox-mirrors/mirror_iproute2
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_iproute2 synced 2025-10-04 19:20:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libnetlink: Add test for error code returned from netlink reply

Browse Source 
In case if some diag module is not present in the system,
say the kernel is not modern enough, we simply skip the
error code reported. Instead we should check for data
length in NLMSG_DONE and process unsupported case.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
This commit is contained in:
Cyrill Gorcunov 2016-11-02 16:14:55 +03:00 committed by Stephen Hemminger
parent bf9a0aff36
commit 9f66764e30
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/libnetlink.c
View File

@ -319,6 +319,22 @@ int rtnl_dump_filter_l(struct rtnl_handle *rth,
dump_intr = 1;
if (h->nlmsg_type == NLMSG_DONE) {
if (rth->proto == NETLINK_SOCK_DIAG) {
if (h->nlmsg_len < NLMSG_LENGTH(sizeof(int))) {
fprintf(stderr, "DONE truncated\n");
return -1;
} else {
int len = *(int *)NLMSG_DATA(h);
if (len < 0) {
errno = -len;
if (errno == ENOENT ||
errno == EOPNOTSUPP)
return -1;
perror("RTNETLINK answers");
return len;
}
}
}
found_done = 1;
break; /* process next filter */
}