proxmox-mirrors/mirror_iproute2
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_iproute2 synced 2025-10-05 22:02:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tc: use bits not mbits/sec in rate percent

Browse Source 
As /sys/class/net/<iface>/speed indicates a value in Mbits/sec, the
conversion is necessary to create the correct limits.

This guarantees the same result for the following commands in an
1000Mbit/sec device:

tc class add ... htb rate 500Mbit
tc class add ... htb rate 50%

Fixes: 927e3cfb52 ("tc: B.W limits can now be specified in %.")
Signed-off-by: Marcos Antonio Moraes <marcos.antonio@digirati.com.br>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Marcos Antonio Moraes 2019-02-07 13:29:54 -02:00 committed by Stephen Hemminger
parent 817204d0b0
commit 9e46c5c206
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tc/tc_util.c
View File

@ -195,7 +195,7 @@ static int parse_percent_rate(char *rate, size_t len,
{ {
long dev_mbit; long dev_mbit;
int ret; int ret;
double perc, rate_mbit; double perc, rate_bit;
char *str_perc = NULL; char *str_perc = NULL;
if (!dev[0]) { if (!dev[0]) {
@ -220,9 +220,9 @@ static int parse_percent_rate(char *rate, size_t len,
return -1; return -1;
} }
rate_mbit = perc * dev_mbit; rate_bit = perc * dev_mbit * 1000 * 1000;
ret = snprintf(rate, len, "%lf", rate_mbit); ret = snprintf(rate, len, "%lf", rate_bit);
if (ret <= 0 || ret >= len) { if (ret <= 0 || ret >= len) {
fprintf(stderr, "Unable to parse calculated rate\n"); fprintf(stderr, "Unable to parse calculated rate\n");
return -1; return -1;