mirror of
https://git.proxmox.com/git/mirror_iproute2
synced 2026-01-25 17:37:07 +00:00
routel: fix infinite loop in line parser
As noticed by one of the few users of routel script, it ends up in an infinite loop when they pull out the cable from the NIC used for some route. This is caused by its parser expecting the line of "ip route show" output consists of "key value" pairs (except for the initial target range), together with an old trap of Bourne style shells that "shift 2" does nothing if there is only one argument left. Some keywords, e.g. "linkdown", are not followed by a value. Improve the parser to (1) only set variables for keywords we care about (2) recognize (currently) known keywords without value This is still far from perfect (and certainly not future proof) but to fully fix the script, one would probably have to rewrite the logic completely (and I'm not sure it's worth the effort). Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
This commit is contained in:
parent
843fc90068
commit
6ec14f1abb
20
ip/routel
20
ip/routel
@ -32,10 +32,22 @@ ip route list table "$@" |
|
||||
esac
|
||||
while test $# != 0
|
||||
do
|
||||
key=$1
|
||||
val=$2
|
||||
eval "$key=$val"
|
||||
shift 2
|
||||
case "$1" in
|
||||
proto|via|dev|scope|src|table)
|
||||
key=$1
|
||||
val=$2
|
||||
eval "$key='$val'"
|
||||
shift 2
|
||||
;;
|
||||
dead|onlink|pervasive|offload|notify|linkdown|unresolved)
|
||||
shift
|
||||
;;
|
||||
*)
|
||||
# avoid infinite loop on unknown keyword without value at line end
|
||||
shift
|
||||
shift
|
||||
;;
|
||||
esac
|
||||
done
|
||||
echo "$network $via $src $proto $scope $dev $table"
|
||||
done | awk -F ' ' '
|
||||
|
||||
Loading…
Reference in New Issue
Block a user