From 23801209261b92ce12c960f54ffbaa90d16a617f Mon Sep 17 00:00:00 2001 From: David Ahern Date: Tue, 30 Oct 2018 13:59:05 -0700 Subject: [PATCH] ip rule: Require at least one argument for add 'ip rule add' with no additional arguments just adds another rule for the main table - which exists by default. Require at least 1 argument similar to delete. Signed-off-by: David Ahern Signed-off-by: Stephen Hemminger --- ip/iprule.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ip/iprule.c b/ip/iprule.c index 74805b6c..a85a4390 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -696,6 +696,11 @@ static int iprule_modify(int cmd, int argc, char **argv) }; if (cmd == RTM_NEWRULE) { + if (argc == 0) { + fprintf(stderr, + "\"ip rule add\" requires arguments.\n"); + return -1; + } req.n.nlmsg_flags |= NLM_F_CREATE|NLM_F_EXCL; req.frh.action = FR_ACT_TO_TBL; }