mirror_frr/zebra
Donald Sharp f096bae46b zebra: Handle crash when backpointer does not exist
=================================================================
==3058==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000010 (pc 0x7f5bf3ef7477 bp 0x7ffdfaa20d40 sp 0x7ffdfaa204c8 T0)
==3058==The signal is caused by a READ memory access.
==3058==Hint: address points to the zero page.
    #0 0x7f5bf3ef7476 in memcpy /build/glibc-OTsEL5/glibc-2.27/string/../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:134
    #1 0x4d158a in __asan_memcpy (/usr/lib/frr/zebra+0x4d158a)
    #2 0x7f5bf58da8ad in stream_put /home/qlyoung/frr/lib/stream.c:605:3
    #3 0x67d428 in zsend_ipset_entry_notify_owner /home/qlyoung/frr/zebra/zapi_msg.c:851:2
    #4 0x5c70b3 in zebra_pbr_add_ipset_entry /home/qlyoung/frr/zebra/zebra_pbr.c
    #5 0x68e1bb in zread_ipset_entry /home/qlyoung/frr/zebra/zapi_msg.c:2465:4
    #6 0x68f958 in zserv_handle_commands /home/qlyoung/frr/zebra/zapi_msg.c:2611:3
    #7 0x55666d in main /home/qlyoung/frr/zebra/main.c:309:2
    #8 0x7f5bf3e5db96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
    #9 0x4311d9 in _start (/usr/lib/frr/zebra+0x4311d9)

the ipset->backpointer was NULL as that the hash lookup failed to find
anything.  Prevent this crash from happening.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-01-06 20:25:54 -05:00
..
.gitignore *: cleanup .gitignore files 2018-09-08 21:30:42 +02:00
connected.c *: Convert connected_free to a double pointer 2019-11-02 16:13:44 -04:00
connected.h zebra: Do not use connection dest for bcast 2019-08-18 18:54:46 +02:00
debug.c zebra: Add detailed debugging command for NHT tracking 2019-03-27 16:22:22 -04:00
debug.h zebra: Add detailed debugging command for NHT tracking 2019-03-27 16:22:22 -04:00
if_ioctl_solaris.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
if_ioctl.c Revert "Ospf missing interface handling 2" 2019-06-23 19:46:39 -04:00
if_netlink.c zebra: Move the supports_nh bool to a better place 2019-10-25 11:13:41 -04:00
if_netlink.h vrrpd: protodown macvlan in backup state 2019-05-17 00:27:08 +00:00
if_sysctl.c *: spelchek 2018-10-25 20:10:57 +02:00
interface.c zebra: send RA lifetime of 0 before ceasing to advertise RAs 2019-12-03 15:46:34 +00:00
interface.h zebra: knob to make ra retransmit interval rfc compliant 2019-11-22 18:40:20 +00:00
ioctl_solaris.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
ioctl_solaris.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
ioctl.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
ioctl.h zebra: removing old intf address code 2019-04-22 13:49:27 -04:00
ipforward_proc.c *: generously apply const 2019-12-02 15:01:29 +01:00
ipforward_solaris.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
ipforward_sysctl.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
ipforward.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
irdp_interface.c *: s/TRUE/true/, s/FALSE/false/ 2019-07-01 17:26:05 +00:00
irdp_main.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
irdp_packet.c zebra: remove bs irdp error code 2019-07-03 00:27:14 +00:00
irdp.h *: strip trailing whitespace 2019-09-30 16:44:43 +00:00
kernel_netlink.c zebra: Don't error on nexthop object support check 2019-10-25 11:13:40 -04:00
kernel_netlink.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
kernel_socket.c zebra: Use nexthop object id on route delete 2019-10-25 11:13:42 -04:00
kernel_socket.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
label_manager.c zebra: Guard debug messages 2019-07-16 20:30:55 -04:00
label_manager.h zebra: label manager refactor 2019-07-10 15:20:27 +02:00
main.c Merge pull request #4765 from opensourcerouting/defaults-v2 2019-12-06 14:07:42 -05:00
Makefile build: convert zebra/ to non-recursive build 2017-07-31 23:03:30 +02:00
redistribute.c lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
redistribute.h zebra: revise redistribution delete to improve update case 2019-09-12 08:51:05 -04:00
rib.h lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
router-id.c zebra: add 'show router-id' 2019-12-17 15:05:56 -06:00
router-id.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
rt_netlink.c zebra: set RTNH_F_ONLINK in nexthop creation 2019-12-17 14:24:22 -05:00
rt_netlink.h zebra: Add functionality to parse RTM_NEWNEXTHOP and RTM_DELNEXTHOP messages 2019-10-25 11:13:36 -04:00
rt_socket.c zebra: BSD null routes were not being installed 2019-11-21 09:37:36 -05:00
rt.h zebra: Add base functionality for nexthop processing via the dataplane 2019-10-25 11:13:36 -04:00
rtadv.c zebra: send RA lifetime of 0 before ceasing to advertise RAs 2019-12-03 15:46:34 +00:00
rtadv.h zebra: send RA lifetime of 0 before ceasing to advertise RAs 2019-12-03 15:46:34 +00:00
rtread_getmsg.c zebra: Update rib_add to take a nexthop ID 2019-10-25 11:13:37 -04:00
rtread_netlink.c zebra: evpn remote delete fetch local entry 2018-12-31 14:40:31 -08:00
rtread_sysctl.c zebra: evpn remote delete fetch local entry 2018-12-31 14:40:31 -08:00
rule_netlink.c zebra: Don't bother ref'ing ifp in zebra_pbr_rule 2019-10-15 15:39:49 -04:00
rule_netlink.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
rule_socket.c zebra: Create zebra_dplane.c and .h 2018-09-19 18:29:55 -04:00
sample_plugin.c zebra: Add a sample dataplane plugin module 2019-10-31 16:24:16 -04:00
subdir.am zebra: Do not build mlag protobuf support if version 3 is not avail 2019-12-15 09:37:51 -05:00
table_manager.c *: list_delete_and_null() -> list_delete() 2018-10-02 11:40:52 +02:00
table_manager.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
testrib.conf zebra: Build the test client, can be useful, and add IPv6 to testrib.conf 2016-05-26 01:13:58 +00:00
zapi_msg.c zebra: Handle crash when backpointer does not exist 2020-01-06 20:25:54 -05:00
zapi_msg.h zebra: revise redistribution delete to improve update case 2019-09-12 08:51:05 -04:00
zebra_dplane.c Merge pull request #5452 from mjstapp/fix_notify_nhg 2019-12-13 14:11:34 -05:00
zebra_dplane.h zebra: support LSPs with multiple outgoing labels 2019-11-29 11:50:07 -03:00
zebra_errors.c zebra: default ns->info should be default zebra_ns 2019-11-15 12:33:35 -05:00
zebra_errors.h zebra: default ns->info should be default zebra_ns 2019-11-15 12:33:35 -05:00
zebra_fpm_dt.c lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
zebra_fpm_netlink.c lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
zebra_fpm_private.h Zebra: Build nelink message for RMAC updates 2019-06-17 12:05:38 -07:00
zebra_fpm_protobuf.c lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
zebra_fpm.c zebra: FPM should have a way of shutting down 2019-11-18 14:49:46 -05:00
zebra_l2.c zebra: Ensure master's ifname is known, even if slave comes up first 2019-08-13 16:29:40 +00:00
zebra_l2.h zebra: Ensure master's ifname is known, even if slave comes up first 2019-08-13 16:29:40 +00:00
zebra_memory.c zebra: use MTYPE_STATIC 2019-06-21 08:54:25 +02:00
zebra_memory.h zebra: use MTYPE_STATIC 2019-06-21 08:54:25 +02:00
zebra_mlag_private.c zebra: fix sign-compare warning in cumulus mlag 2019-12-11 11:41:54 +01:00
zebra_mlag_vty.c zebra: Do not build mlag protobuf support if version 3 is not avail 2019-12-15 09:37:51 -05:00
zebra_mlag_vty.h zebra: Do not build mlag protobuf support if version 3 is not avail 2019-12-15 09:37:51 -05:00
zebra_mlag.c zebra: Do not build mlag protobuf support if version 3 is not avail 2019-12-15 09:37:51 -05:00
zebra_mlag.h zebra: Do not build mlag protobuf support if version 3 is not avail 2019-12-15 09:37:51 -05:00
zebra_mpls_netlink.c zebra: convert PW updates to async dataplane 2019-01-25 10:45:57 -05:00
zebra_mpls_null.c zebra: convert PW updates to async dataplane 2019-01-25 10:45:57 -05:00
zebra_mpls_openbsd.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
zebra_mpls_vty.c bgpd, ospfd, pimd, zebra: Convert more use_json locations to bool 2018-09-04 17:39:04 +00:00
zebra_mpls.c Merge pull request #5416 from mjstapp/re_nhe_pointer 2019-12-04 14:11:04 -05:00
zebra_mpls.h zebra: support LSPs with multiple outgoing labels 2019-11-29 11:50:07 -03:00
zebra_mroute.c zebra: Add some additional vrf debug for retrieving mroute info 2018-09-17 09:22:31 -04:00
zebra_mroute.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
zebra_netns_id.c zebra: dead code (Coverity 1465497) 2018-10-02 15:45:44 +02:00
zebra_netns_id.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
zebra_netns_notify.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
zebra_netns_notify.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
zebra_nhg_private.h lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
zebra_nhg.c zebra: improve efficiency of depends_find() 2019-12-18 15:34:37 -05:00
zebra_nhg.h lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
zebra_ns.c zebra: XFREE ns->info directly to NULL it out 2019-11-15 12:33:35 -05:00
zebra_ns.h zebra: Move the supports_nh bool to a better place 2019-10-25 11:13:41 -04:00
zebra_pbr.c zebra: Don't bother ref'ing ifp in zebra_pbr_rule 2019-10-15 15:39:49 -04:00
zebra_pbr.h zebra: Don't bother ref'ing ifp in zebra_pbr_rule 2019-10-15 15:39:49 -04:00
zebra_ptm_redistribute.c zebra: Remove zclient->idinfo restrictions 2019-02-05 09:13:30 -05:00
zebra_ptm_redistribute.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
zebra_ptm.c Revert "Ospf missing interface handling 2" 2019-06-23 19:46:39 -04:00
zebra_ptm.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
zebra_pw.c lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
zebra_pw.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
zebra_rib.c zebra: null check re->nhe not re->nhe->nhg on attach 2019-12-16 16:37:14 -05:00
zebra_rnh.c *: revise zapi nexthop encoding 2019-12-06 10:17:20 -05:00
zebra_rnh.h zebra: nht resolution default configurable per vrf 2019-08-28 16:19:34 +02:00
zebra_routemap.c *: make all route_map_rule_cmd const 2019-11-30 00:38:32 +01:00
zebra_routemap.h add cplusplus guards to all zebra headers 2019-03-25 16:05:27 +01:00
zebra_router.c lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
zebra_router.h zebra: Fixing Comments in MLAG Read scheduling Events 2019-11-21 20:39:35 -08:00
zebra_snmp.c lib,zebra: use nhg_hash_entry pointer in route_entry 2019-12-04 08:13:52 -05:00
zebra_vrf.c zebra: separate zebra_vrf_lookup_table_with_id() 2019-11-01 16:06:19 -04:00
zebra_vrf.h zebra: separate zebra_vrf_lookup_table_with_id() 2019-11-01 16:06:19 -04:00
zebra_vty.c Merge pull request #5508 from ton31337/feature/show_ip_route_summary_json 2019-12-17 10:05:13 -05:00
zebra_vxlan_private.h zebra: print rmac and sys mac values 2019-11-22 07:53:35 -08:00
zebra_vxlan.c zebra: Refactor _add and _del to use a common function 2020-01-06 20:25:51 -05:00
zebra_vxlan.h Merge pull request #4977 from chiragshah6/evpn_dev1 2019-11-26 17:56:59 +01:00
zebra.conf.sample *: Remove cvs control points 2017-12-05 17:28:12 -05:00
zserv.c zebra: Fix show zebra client display to handle columns right 2019-11-22 19:59:40 -05:00
zserv.h Zebra: adding support for Zebra MLAG Functionality 2019-11-13 20:50:37 -08:00