mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-06-12 17:03:11 +00:00
efa354a978
When setting rule for access-list ( and prefix-list ) without sequence, it will automatically get a sequence by `acl_get_seq()`, and return `CMD_SUCCESS` for command even this sequence value is wrong. In this scene, `CMD_WARNING_CONFIG_FAILED` should be returned with a warning. So, add the check in `acl_get_seq()` and move `nb_cli_enqueue_change()` after the check of wrong sequence. Both `plist_remove_if_empty()` and `acl_remove_if_empty()` should ignore this check, there is no change on them. Before: ``` anlan(config)# access-list aa seq 4294967295 deny 6.6.6.6/32 anlan(config)# access-list aa deny 6.6.6.7/32 <- Return CMD_SUCCESS YANG error(s): Value "4294967300" is out of uint32's min/max bounds. Value "4294967300" is out of uint32's min/max bounds. Value "4294967300" is out of uint32's min/max bounds. Value "4294967300" is out of uint32's min/max bounds. Value "4294967300" is out of uint32's min/max bounds. YANG path: Schema location /frr-filter:lib/prefix-list/entry/sequence. % Failed to edit configuration. ``` After: ``` anlan(config)# access-list aa seq 4294967295 deny 6.6.6.6/32 anlan(config)# access-list aa deny 6.6.6.7/32 <- Return CMD_WARNING_CONFIG_FAILED % Malformed sequence value ``` Additionally, fixed the overflow issue on `acl_get_seq()` on **32bit** platforms. Just change the returned type of `acl_get_seq()` from `long` to `int64_t`. Before: ``` anlan(config)# access-list bb seq 4294967295 deny 6.6.6.6/32 anlan(config)# access-list bb deny 6.6.6.7/32 anlan(config)# do show run ... access-list bb seq 4294967295 deny 6.6.6.6/32 access-list bb seq 4 deny 6.6.6.7/32 <- Overflow ``` After: ``` anlan(config)# access-list bb seq 4294967295 deny 6.6.6.6/32 anlan(config)# access-list bb deny 6.6.6.7/32 % Malformed sequence value ``` Signed-off-by: anlan_cs <vic.lan@pica8.com> |
||
|---|---|---|
| .github | ||
| alpine | ||
| babeld | ||
| bfdd | ||
| bgpd | ||
| debian | ||
| doc | ||
| docker | ||
| eigrpd | ||
| fpm | ||
| gdb | ||
| grpc | ||
| include | ||
| isisd | ||
| ldpd | ||
| lib | ||
| m4 | ||
| mlag | ||
| nhrpd | ||
| ospf6d | ||
| ospfclient | ||
| ospfd | ||
| pathd | ||
| pbrd | ||
| pceplib | ||
| pimd | ||
| pkgsrc | ||
| python | ||
| qpb | ||
| redhat | ||
| ripd | ||
| ripngd | ||
| sharpd | ||
| snapcraft | ||
| staticd | ||
| tests | ||
| tools | ||
| vrrpd | ||
| vtysh | ||
| watchfrr | ||
| yang | ||
| zebra | ||
| .clang-format | ||
| .dir-locals.el | ||
| .dockerignore | ||
| .git-blame-ignore-revs | ||
| .gitignore | ||
| .pylintrc | ||
| .travis.yml | ||
| bootstrap.sh | ||
| buildtest.sh | ||
| config.version.in | ||
| configure.ac | ||
| COPYING | ||
| COPYING-LGPLv2.1 | ||
| Makefile.am | ||
| README.md | ||
| stamp-h.in | ||
| version.h | ||
FRRouting
FRR is free software that implements and manages various IPv4 and IPv6 routing protocols. It runs on nearly all distributions of Linux and BSD and supports all modern CPU architectures.
FRR currently supports the following protocols:
- BGP
- OSPFv2
- OSPFv3
- RIPv1
- RIPv2
- RIPng
- IS-IS
- PIM-SM/MSDP
- LDP
- BFD
- Babel
- PBR
- OpenFabric
- VRRP
- EIGRP (alpha)
- NHRP (alpha)
Installation & Use
For source tarballs, see the releases page.
For Debian and its derivatives, use the APT repository at https://deb.frrouting.org/.
Instructions on building and installing from source for supported platforms may be found in the developer docs.
Once installed, please refer to the user guide for instructions on use.
Community
The FRRouting email list server is located here and offers the following public lists:
| Topic | List |
|---|---|
| Development | dev@lists.frrouting.org |
| Users & Operators | frog@lists.frrouting.org |
| Announcements | announce@lists.frrouting.org |
For chat, we currently use Slack. You can join by clicking the "Slack" link under the Participate section of our website.
Contributing
FRR maintains developer's documentation which contains the project workflow and expectations for contributors. Some technical documentation on project internals is also available.
We welcome and appreciate all contributions, no matter how small!
Security
To report security issues, please use our security mailing list:
security [at] lists.frrouting.org