mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-05-30 15:17:09 +00:00

Updating interface addresses on autoconfigured VRRP instances when we receive notification that an interface is up will cause us to delete that VRRP instance because Zebra deletes all interface addresses when an interfaces goes down so when it comes back up it has no addresses which causes us to delete the instance, then Zebra subsequently sends us the addresses which causes the instance to get recreated, however in a non-owner scenario this will merely cause us to start in Backup, wait a while, transition to Master, protodown off our interface, get an interface up notification, delete all our ip addresses, destroy ourselves, receive address notifications, recreate ourselves, reenter Backup and cycle through it all over again. So we just have to assume that no addresses went away since this interface was last up. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
253 lines
6.6 KiB
C
253 lines
6.6 KiB
C
/*
|
|
* VRRP Zebra interfacing.
|
|
* Copyright (C) 2018-2019 Cumulus Networks, Inc.
|
|
* Quentin Young
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the Free
|
|
* Software Foundation; either version 2 of the License, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; see the file COPYING; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
#include <zebra.h>
|
|
|
|
#include "lib/if.h"
|
|
#include "lib/linklist.h"
|
|
#include "lib/log.h"
|
|
#include "lib/prefix.h"
|
|
#include "lib/vty.h"
|
|
#include "lib/zclient.h"
|
|
|
|
#include "vrrp.h"
|
|
#include "vrrp_debug.h"
|
|
#include "vrrp_zebra.h"
|
|
|
|
#define VRRP_LOGPFX "[ZEBRA] "
|
|
|
|
static struct zclient *zclient = NULL;
|
|
|
|
static void vrrp_zebra_debug_if_state(struct interface *ifp, vrf_id_t vrf_id,
|
|
const char *func)
|
|
{
|
|
DEBUGD(&vrrp_dbg_zebra,
|
|
"%s: %s index %d(%u) flags %ld metric %d mtu %d operative %d",
|
|
func, ifp->name, ifp->ifindex, vrf_id, (long)ifp->flags,
|
|
ifp->metric, ifp->mtu, if_is_operative(ifp));
|
|
}
|
|
|
|
static void vrrp_zebra_debug_if_dump_address(struct interface *ifp,
|
|
const char *func)
|
|
{
|
|
struct connected *ifc;
|
|
struct listnode *node;
|
|
|
|
DEBUGD(&vrrp_dbg_zebra, "%s: interface %s addresses:", func, ifp->name);
|
|
|
|
for (ALL_LIST_ELEMENTS_RO(ifp->connected, node, ifc)) {
|
|
struct prefix *p = ifc->address;
|
|
|
|
DEBUGD(&vrrp_dbg_zebra, "%s: interface %s address %s %s", func,
|
|
ifp->name, inet_ntoa(p->u.prefix4),
|
|
CHECK_FLAG(ifc->flags, ZEBRA_IFA_SECONDARY) ? "secondary"
|
|
: "primary");
|
|
}
|
|
}
|
|
|
|
|
|
static void vrrp_zebra_connected(struct zclient *zclient)
|
|
{
|
|
zclient_send_reg_requests(zclient, VRF_DEFAULT);
|
|
}
|
|
|
|
/* Router-id update message from zebra. */
|
|
static int vrrp_router_id_update_zebra(int command, struct zclient *zclient,
|
|
zebra_size_t length, vrf_id_t vrf_id)
|
|
{
|
|
struct prefix router_id;
|
|
|
|
zebra_router_id_update_read(zclient->ibuf, &router_id);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vrrp_zebra_if_add(int command, struct zclient *zclient,
|
|
zebra_size_t length, vrf_id_t vrf_id)
|
|
{
|
|
struct interface *ifp;
|
|
|
|
/*
|
|
* zebra api adds/dels interfaces using the same call
|
|
* interface_add_read below, see comments in lib/zclient.c
|
|
*/
|
|
ifp = zebra_interface_add_read(zclient->ibuf, vrf_id);
|
|
|
|
if (!ifp)
|
|
return 0;
|
|
|
|
vrrp_zebra_debug_if_state(ifp, vrf_id, __func__);
|
|
|
|
vrrp_if_add(ifp);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vrrp_zebra_if_del(int command, struct zclient *zclient,
|
|
zebra_size_t length, vrf_id_t vrf_id)
|
|
{
|
|
struct interface *ifp;
|
|
|
|
ifp = zebra_interface_state_read(zclient->ibuf, vrf_id);
|
|
|
|
if (!ifp)
|
|
return 0;
|
|
|
|
vrrp_zebra_debug_if_state(ifp, vrf_id, __func__);
|
|
|
|
vrrp_if_del(ifp);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vrrp_zebra_if_state_up(int command, struct zclient *zclient,
|
|
zebra_size_t length, vrf_id_t vrf_id)
|
|
{
|
|
struct interface *ifp;
|
|
|
|
/*
|
|
* zebra api notifies interface up/down events by using the same call
|
|
* zebra_interface_state_read below, see comments in lib/zclient.c ifp =
|
|
* zebra_interface_state_read(zclient->ibuf, vrf_id);
|
|
*/
|
|
ifp = zebra_interface_state_read(zclient->ibuf, vrf_id);
|
|
|
|
if (!ifp)
|
|
return 0;
|
|
|
|
vrrp_zebra_debug_if_state(ifp, vrf_id, __func__);
|
|
|
|
vrrp_if_up(ifp);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vrrp_zebra_if_state_down(int command, struct zclient *zclient,
|
|
zebra_size_t length, vrf_id_t vrf_id)
|
|
{
|
|
struct interface *ifp;
|
|
|
|
/*
|
|
* zebra api notifies interface up/down events by using the same call
|
|
* zebra_interface_state_read below, see comments in lib/zclient.c
|
|
*/
|
|
ifp = zebra_interface_state_read(zclient->ibuf, vrf_id);
|
|
|
|
if (!ifp)
|
|
return 0;
|
|
|
|
vrrp_zebra_debug_if_state(ifp, vrf_id, __func__);
|
|
|
|
vrrp_if_down(ifp);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vrrp_zebra_if_address_add(int command, struct zclient *zclient,
|
|
zebra_size_t length, vrf_id_t vrf_id)
|
|
{
|
|
struct connected *c;
|
|
|
|
/*
|
|
* zebra api notifies address adds/dels events by using the same call
|
|
* interface_add_read below, see comments in lib/zclient.c
|
|
*
|
|
* zebra_interface_address_read(ZEBRA_INTERFACE_ADDRESS_ADD, ...)
|
|
* will add address to interface list by calling
|
|
* connected_add_by_prefix()
|
|
*/
|
|
c = zebra_interface_address_read(command, zclient->ibuf, vrf_id);
|
|
|
|
if (!c)
|
|
return 0;
|
|
|
|
vrrp_zebra_debug_if_state(c->ifp, vrf_id, __func__);
|
|
vrrp_zebra_debug_if_dump_address(c->ifp, __func__);
|
|
|
|
vrrp_if_address_add(c->ifp);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vrrp_zebra_if_address_del(int command, struct zclient *client,
|
|
zebra_size_t length, vrf_id_t vrf_id)
|
|
{
|
|
struct connected *c;
|
|
|
|
/*
|
|
* zebra api notifies address adds/dels events by using the same call
|
|
* interface_add_read below, see comments in lib/zclient.c
|
|
*
|
|
* zebra_interface_address_read(ZEBRA_INTERFACE_ADDRESS_DELETE, ...)
|
|
* will remove address from interface list by calling
|
|
* connected_delete_by_prefix()
|
|
*/
|
|
c = zebra_interface_address_read(command, client->ibuf, vrf_id);
|
|
|
|
if (!c)
|
|
return 0;
|
|
|
|
vrrp_zebra_debug_if_state(c->ifp, vrf_id, __func__);
|
|
vrrp_zebra_debug_if_dump_address(c->ifp, __func__);
|
|
|
|
vrrp_if_address_del(c->ifp);
|
|
|
|
return 0;
|
|
}
|
|
|
|
void vrrp_zebra_radv_set(struct vrrp_router *r, bool enable)
|
|
{
|
|
DEBUGD(&vrrp_dbg_zebra,
|
|
VRRP_LOGPFX VRRP_LOGPFX_VRID
|
|
"Requesting Zebra to turn router advertisements %s for %s",
|
|
r->vr->vrid, enable ? "on" : "off", r->mvl_ifp->name);
|
|
|
|
zclient_send_interface_radv_req(zclient, VRF_DEFAULT, r->mvl_ifp,
|
|
enable, VRRP_RADV_INT);
|
|
}
|
|
|
|
int vrrp_zclient_send_interface_protodown(struct interface *ifp, bool down)
|
|
{
|
|
DEBUGD(&vrrp_dbg_zebra,
|
|
VRRP_LOGPFX "Requesting Zebra to set %s protodown %s", ifp->name,
|
|
down ? "on" : "off");
|
|
|
|
return zclient_send_interface_protodown(zclient, VRF_DEFAULT, ifp,
|
|
down);
|
|
}
|
|
|
|
void vrrp_zebra_init(void)
|
|
{
|
|
/* Socket for receiving updates from Zebra daemon */
|
|
zclient = zclient_new(master, &zclient_options_default);
|
|
|
|
zclient->zebra_connected = vrrp_zebra_connected;
|
|
zclient->router_id_update = vrrp_router_id_update_zebra;
|
|
zclient->interface_add = vrrp_zebra_if_add;
|
|
zclient->interface_delete = vrrp_zebra_if_del;
|
|
zclient->interface_up = vrrp_zebra_if_state_up;
|
|
zclient->interface_down = vrrp_zebra_if_state_down;
|
|
zclient->interface_address_add = vrrp_zebra_if_address_add;
|
|
zclient->interface_address_delete = vrrp_zebra_if_address_del;
|
|
|
|
zclient_init(zclient, 0, 0, &vrrp_privs);
|
|
|
|
zlog_notice("%s: zclient socket initialized", __PRETTY_FUNCTION__);
|
|
}
|