mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-05-28 15:33:34 +00:00
8c9d306c8d
[New LWP 2524] [New LWP 2539] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/opt/avi/bin/bgpd -f /run/frr/avi_ns3_bgpd.config -i /opt/avi/etc/avi_ns3_bgpd.'. Program terminated with signal SIGABRT, Aborted. [Current thread is 1 (Thread 0x7f92ac8f1740 (LWP 2524))] 0 0x00007f92acb3800b in raise () from /lib/x86_64-linux-gnu/libc.so.6 [Current thread is 1 (Thread 0x7f92ac8f1740 (LWP 2524))] 0 0x00007f92acb3800b in raise () from /lib/x86_64-linux-gnu/libc.so.6 1 0x00007f92acb17859 in abort () from /lib/x86_64-linux-gnu/libc.so.6 2 0x00007f92acb17729 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 3 0x00007f92acb28fd6 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6 4 0x00007f92accf2164 in pthread_mutex_lock () from /lib/x86_64-linux-gnu/libpthread.so.0 5 0x000055b46be1ef63 in bgp_keepalives_wake () at bgpd/bgp_keepalives.c:311 6 0x000055b46be1f111 in bgp_keepalives_stop (fpt=0x55b46cfacf20, result=<optimized out>) at bgpd/bgp_keepalives.c:323 7 0x00007f92acea9521 in frr_pthread_stop (fpt=0x55b46cfacf20, result=result@entry=0x0) at lib/frr_pthread.c:176 8 0x00007f92acea9586 in frr_pthread_stop_all () at lib/frr_pthread.c:188 9 0x000055b46bdde54a in bgp_pthreads_finish () at bgpd/bgpd.c:8150 10 0x000055b46bd696ca in bgp_exit (status=0) at bgpd/bgp_main.c:210 11 sigint () at bgpd/bgp_main.c:154 12 0x00007f92acecc1e9 in quagga_sigevent_process () at lib/sigevent.c:105 13 0x00007f92aced689a in thread_fetch (m=m@entry=0x55b46cf23540, fetch=fetch@entry=0x7fff95379238) at lib/thread.c:1487 14 0x00007f92aceb2681 in frr_run (master=0x55b46cf23540) at lib/libfrr.c:1010 15 0x000055b46bd676f4 in main (argc=11, argv=0x7fff953795a8) at bgpd/bgp_main.c:482 Root cause: This is due to race condition between main thread & keepalive thread during clean-up. This happens when the keepalive thread is processing a wake signal owning the mutex, when meanwhile the main thread tries to stop the keepalives thread. In main thread, the keepalive thread’s running bit (fpt->running) is set to false, without taking the mutex & then it blocks on mutex. Meanwhile, keepalive thread which owns the mutex sees that the running bit is false & executes bgp_keepalives_finish() which also frees up mutex. Main thread that is waiting on mutex with pthread_mutex_lock() will cause core while trying to access mutex. Fix: Take the lock in main thread while setting the fpt->running to false. Signed-off-by: Samanvitha B Bhargav <bsamanvitha@vmware.com>
82 lines
2.5 KiB
C
82 lines
2.5 KiB
C
/* BGP Keepalives.
|
|
* Implements a producer thread to generate BGP keepalives for peers.
|
|
* Copyright (C) 2017 Cumulus Networks, Inc.
|
|
* Quentin Young
|
|
*
|
|
* This file is part of FRRouting.
|
|
*
|
|
* FRRouting is free software; you can redistribute it and/or modify it under
|
|
* the terms of the GNU General Public License as published by the Free
|
|
* Software Foundation; either version 2, or (at your option) any later
|
|
* version.
|
|
*
|
|
* FRRouting is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
* WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
|
|
* FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
|
|
* details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; see the file COPYING; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef _FRR_BGP_KEEPALIVES_H
|
|
#define _FRR_BGP_KEEPALIVES_H
|
|
|
|
#include "frr_pthread.h"
|
|
#include "bgpd.h"
|
|
|
|
/**
|
|
* Turns on keepalives for a peer.
|
|
*
|
|
* This function adds the peer to an internal list of peers to generate
|
|
* keepalives for.
|
|
*
|
|
* At set intervals, a BGP KEEPALIVE packet is generated and placed on
|
|
* peer->obuf. This operation is thread-safe with respect to peer->obuf.
|
|
*
|
|
* peer->v_keepalive determines the interval. Changing this value before
|
|
* unregistering this peer with bgp_keepalives_off() results in undefined
|
|
* behavior.
|
|
*
|
|
* If the peer is already registered for keepalives via this function, nothing
|
|
* happens.
|
|
*/
|
|
extern void bgp_keepalives_on(struct peer *);
|
|
|
|
/**
|
|
* Turns off keepalives for a peer.
|
|
*
|
|
* Removes the peer from the internal list of peers to generate keepalives for.
|
|
*
|
|
* If the peer is already unregistered for keepalives, nothing happens.
|
|
*/
|
|
extern void bgp_keepalives_off(struct peer *);
|
|
|
|
/**
|
|
* Pre-run initialization function for keepalives pthread.
|
|
*
|
|
* Initializes synchronization primitives. This should be called before
|
|
* anything else to avoid race conditions.
|
|
*/
|
|
extern void bgp_keepalives_init(void);
|
|
|
|
/**
|
|
* Entry function for keepalives pthread.
|
|
*
|
|
* This function loops over an internal list of peers, generating keepalives at
|
|
* regular intervals as determined by each peer's keepalive timer.
|
|
*
|
|
* See bgp_keepalives_on() for additional details.
|
|
*
|
|
* @param arg pthread arg, not used
|
|
*/
|
|
extern void *bgp_keepalives_start(void *arg);
|
|
|
|
/**
|
|
* Stops the thread and blocks until it terminates.
|
|
*/
|
|
int bgp_keepalives_stop(struct frr_pthread *fpt, void **result);
|
|
|
|
#endif /* _FRR_BGP_KEEPALIVES_H */
|