mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-11-04 10:07:04 +00:00
25af5f0d79
Add some Coccinelle semantic patches we can use to automatically refactor code in the future. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
102 lines
2.0 KiB
Plaintext
102 lines
2.0 KiB
Plaintext
/// Remove casting the values returned by memory allocation functions
|
|
/// like XMALLOC and XCALLOC.
|
|
///
|
|
// This makes an effort to find cases of casting of values returned by #
|
|
// XMALLOC and XCALLOC and removes the casting as it is not required. The
|
|
// result in the patch case may need some reformatting.
|
|
//
|
|
// Confidence: High
|
|
// Copyright: (C) 2014 Himangi Saraogi GPLv2.
|
|
// Copyright: (C) 2017 Himanshu Jha GPLv2.
|
|
// Copyright: (C) 2019 Quentin Young GPLv2.
|
|
// Comments:
|
|
// Options: --no-includes --include-headers
|
|
//
|
|
|
|
virtual context
|
|
virtual patch
|
|
virtual org
|
|
virtual report
|
|
|
|
@initialize:python@
|
|
@@
|
|
import re
|
|
pattern = '__'
|
|
m = re.compile(pattern)
|
|
|
|
@r1 depends on context || patch@
|
|
type T;
|
|
@@
|
|
|
|
(T *)
|
|
\(XMALLOC\|XCALLOC\)(...)
|
|
|
|
//----------------------------------------------------------
|
|
// For context mode
|
|
//----------------------------------------------------------
|
|
|
|
@script:python depends on context@
|
|
t << r1.T;
|
|
@@
|
|
|
|
if m.search(t) != None:
|
|
cocci.include_match(False)
|
|
|
|
@depends on context && r1@
|
|
type r1.T;
|
|
@@
|
|
|
|
* (T *)
|
|
\(XMALLOC\|XCALLOC\)(...)
|
|
|
|
//----------------------------------------------------------
|
|
// For patch mode
|
|
//----------------------------------------------------------
|
|
|
|
@script:python depends on patch@
|
|
t << r1.T;
|
|
@@
|
|
|
|
if m.search(t) != None:
|
|
cocci.include_match(False)
|
|
|
|
@depends on patch && r1@
|
|
type r1.T;
|
|
@@
|
|
|
|
- (T *)
|
|
\(XMALLOC\|XCALLOC\)(...)
|
|
|
|
//----------------------------------------------------------
|
|
// For org and report mode
|
|
//----------------------------------------------------------
|
|
|
|
@r2 depends on org || report@
|
|
type T;
|
|
position p;
|
|
@@
|
|
|
|
(T@p *)
|
|
\(XMALLOC\|XCALLOC\)(...)
|
|
|
|
@script:python depends on org@
|
|
p << r2.p;
|
|
t << r2.T;
|
|
@@
|
|
|
|
if m.search(t) != None:
|
|
cocci.include_match(False)
|
|
else:
|
|
coccilib.org.print_safe_todo(p[0], t)
|
|
|
|
@script:python depends on report@
|
|
p << r2.p;
|
|
t << r2.T;
|
|
@@
|
|
|
|
if m.search(t) != None:
|
|
cocci.include_match(False)
|
|
else:
|
|
msg="WARNING: casting value returned by memory allocation function to (%s *) is useless." % (t)
|
|
coccilib.report.print_report(p[0], msg)
|