mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-05-25 10:08:09 +00:00
100ef15262
router bgp 65001
no bgp ebgp-requires-policy
neighbor 192.168.1.2 remote-as external
neighbor 192.168.1.2 timers 3 10
address-family ipv4 unicast
neighbor 192.168.1.2 route-map r2 in
exit-address-family
!
ip prefix-list p1 seq 5 permit 172.16.255.31/32
!
route-map r2 permit 10
match ip address prefix-list p1
set as-path exclude 65003
route-map r2 permit 20
set as-path exclude all
!
we make the following commands
bgp as-path access-list FIRST permit ^65
bgp as-path access-list SECOND permit 2
route-map r2 permit 6
set as-path exclude as-path-access-list SECOND
and then
no bgp as-path access-list SECOND permit 2
clear bgp *
we have the following crash in bgp
Stack trace of thread 536083:
#0 0x00007f87f8aacfe1 raise (libpthread.so.0 + 0x12fe1)
#1 0x00007f87f8cf6870 core_handler (libfrr.so.0 +
0xf6870)
#2 0x00007f87f8aad140 __restore_rt (libpthread.so.0 +
0x13140)
#3 0x00007f87f89a5122 __GI___regexec (libc.so.6 +
0xdf122)
#4 0x000055d7f198b4a7 aspath_filter_exclude_acl (bgpd +
0x2054a7)
#5 0x000055d7f1902187 route_set_aspath_exclude (bgpd +
0x17c187)
#6 0x00007f87f8ce54b0 route_map_apply_ext (libfrr.so.0
+ 0xe54b0)
#7 0x000055d7f18da925 bgp_input_modifier (bgpd +
0x154925)
#8 0x000055d7f18e0647 bgp_update (bgpd + 0x15a647)
#9 0x000055d7f18e4772 bgp_nlri_parse_ip (bgpd +
0x15e772)
#10 0x000055d7f18c38ae bgp_nlri_parse (bgpd + 0x13d8ae)
#11 0x000055d7f18c6b7a bgp_update_receive (bgpd +
0x140b7a)
#12 0x000055d7f18c8ff3 bgp_process_packet (bgpd +
0x142ff3)
#13 0x00007f87f8d0dce0 thread_call (libfrr.so.0 +
0x10dce0)
#14 0x00007f87f8cacb28 frr_run (libfrr.so.0 + 0xacb28)
#15 0x000055d7f18435da main (bgpd + 0xbd5da)
#16 0x00007f87f88e9d0a __libc_start_main (libc.so.6 +
0x23d0a)
#17 0x000055d7f18415fa _start (bgpd + 0xbb5fa)
analysis
crash is due to the fact that there were always a pointer from
as-path exclude to deleted as-path access list.
fix
we add a backpointer mechanism to manage the dependency beetween
as-path access-list and aspath exclude.
Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
165 lines
6.3 KiB
C
165 lines
6.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/* AS path related definitions.
|
|
* Copyright (C) 1997, 98, 99 Kunihiro Ishiguro
|
|
*/
|
|
|
|
#ifndef _QUAGGA_BGP_ASPATH_H
|
|
#define _QUAGGA_BGP_ASPATH_H
|
|
|
|
#include "lib/json.h"
|
|
#include "bgpd/bgp_route.h"
|
|
#include "bgpd/bgp_filter.h"
|
|
|
|
/* AS path segment type. */
|
|
#define AS_SET 1
|
|
#define AS_SEQUENCE 2
|
|
#define AS_CONFED_SEQUENCE 3
|
|
#define AS_CONFED_SET 4
|
|
|
|
/* Private AS range defined in RFC2270. */
|
|
#define BGP_PRIVATE_AS_MIN 64512U
|
|
#define BGP_PRIVATE_AS_MAX UINT16_MAX
|
|
|
|
/* Private 4 byte AS range defined in RFC6996. */
|
|
#define BGP_PRIVATE_AS4_MIN 4200000000U
|
|
#define BGP_PRIVATE_AS4_MAX 4294967294U
|
|
|
|
/* we leave BGP_AS_MAX as the 16bit AS MAX number. */
|
|
#define BGP_AS_ZERO 0
|
|
#define BGP_AS_MAX UINT16_MAX
|
|
#define BGP_AS4_MAX 4294967295U
|
|
/* Transition 16Bit AS as defined by IANA */
|
|
#define BGP_AS_TRANS 23456U
|
|
|
|
#define BGP_AS_IS_PRIVATE(ASN) \
|
|
(((ASN) >= BGP_PRIVATE_AS_MIN && (ASN) <= BGP_PRIVATE_AS_MAX) \
|
|
|| ((ASN) >= BGP_PRIVATE_AS4_MIN && (ASN) <= BGP_PRIVATE_AS4_MAX))
|
|
|
|
/* AS_PATH segment data in abstracted form, no limit is placed on length */
|
|
struct assegment {
|
|
struct assegment *next;
|
|
as_t *as;
|
|
unsigned short length;
|
|
uint8_t type;
|
|
};
|
|
|
|
/* AS path may be include some AsSegments. */
|
|
struct aspath {
|
|
/* Reference count to this aspath. */
|
|
unsigned long refcnt;
|
|
|
|
/* segment data */
|
|
struct assegment *segments;
|
|
|
|
/* AS path as a json object */
|
|
json_object *json;
|
|
|
|
/* String expression of AS path. This string is used by vty output
|
|
and AS path regular expression match. */
|
|
char *str;
|
|
unsigned short str_len;
|
|
|
|
/* AS notation used by string expression of AS path */
|
|
enum asnotation_mode asnotation;
|
|
};
|
|
|
|
#define ASPATH_STR_DEFAULT_LEN 32
|
|
|
|
/* `set as-path exclude ASn' */
|
|
struct aspath_exclude {
|
|
struct aspath *aspath;
|
|
bool exclude_all;
|
|
char *exclude_aspath_acl_name;
|
|
struct as_list *exclude_aspath_acl;
|
|
};
|
|
|
|
/* Prototypes. */
|
|
extern void aspath_init(void);
|
|
extern void aspath_finish(void);
|
|
extern struct aspath *aspath_parse(struct stream *s, size_t length,
|
|
int use32bit,
|
|
enum asnotation_mode asnotation);
|
|
|
|
extern struct aspath *aspath_dup(struct aspath *aspath);
|
|
extern struct aspath *aspath_aggregate(struct aspath *as1, struct aspath *as2);
|
|
extern struct aspath *aspath_prepend(struct aspath *as1, struct aspath *as2);
|
|
extern struct aspath *aspath_filter_exclude(struct aspath *source,
|
|
struct aspath *exclude_list);
|
|
extern struct aspath *aspath_filter_exclude_all(struct aspath *source);
|
|
extern struct aspath *aspath_filter_exclude_acl(struct aspath *source,
|
|
struct as_list *acl_list);
|
|
extern struct aspath *aspath_add_seq_n(struct aspath *aspath, as_t asno,
|
|
unsigned num);
|
|
extern struct aspath *aspath_add_seq(struct aspath *aspath, as_t asno);
|
|
extern struct aspath *aspath_add_confed_seq(struct aspath *aspath, as_t asno);
|
|
extern bool aspath_cmp(const void *as1, const void *as2);
|
|
extern bool aspath_cmp_left(const struct aspath *aspath1,
|
|
const struct aspath *aspath2);
|
|
extern bool aspath_cmp_left_confed(const struct aspath *as1,
|
|
const struct aspath *as2);
|
|
extern struct aspath *aspath_delete_confed_seq(struct aspath *aspath);
|
|
extern struct aspath *aspath_empty(enum asnotation_mode asnotation);
|
|
extern struct aspath *aspath_empty_get(void);
|
|
extern struct aspath *aspath_str2aspath(const char *str,
|
|
enum asnotation_mode asnotation);
|
|
extern void aspath_str_update(struct aspath *as, bool make_json);
|
|
extern void aspath_free(struct aspath *aspath);
|
|
extern struct aspath *aspath_intern(struct aspath *aspath);
|
|
extern void aspath_unintern(struct aspath **aspath);
|
|
extern const char *aspath_print(struct aspath *aspath);
|
|
extern void aspath_print_vty(struct vty *vty, struct aspath *aspath);
|
|
extern void aspath_print_all_vty(struct vty *vty);
|
|
extern unsigned int aspath_key_make(const void *p);
|
|
extern unsigned int aspath_get_first_as(struct aspath *aspath);
|
|
extern unsigned int aspath_get_last_as(struct aspath *aspath);
|
|
extern int aspath_loop_check(struct aspath *aspath, as_t asno);
|
|
extern int aspath_loop_check_confed(struct aspath *aspath, as_t asno);
|
|
extern bool aspath_private_as_check(struct aspath *aspath);
|
|
extern struct aspath *aspath_replace_regex_asn(struct aspath *aspath,
|
|
struct as_list *acl_list,
|
|
as_t our_asn);
|
|
extern struct aspath *aspath_replace_specific_asn(struct aspath *aspath,
|
|
as_t target_asn,
|
|
as_t our_asn);
|
|
extern struct aspath *aspath_replace_all_asn(struct aspath *aspath,
|
|
as_t our_asn);
|
|
extern struct aspath *aspath_replace_private_asns(struct aspath *aspath,
|
|
as_t asn, as_t peer_asn);
|
|
extern struct aspath *aspath_remove_private_asns(struct aspath *aspath,
|
|
as_t peer_asn);
|
|
extern bool aspath_firstas_check(struct aspath *aspath, as_t asno);
|
|
extern bool aspath_confed_check(struct aspath *aspath);
|
|
extern bool aspath_left_confed_check(struct aspath *aspath);
|
|
extern unsigned long aspath_count(void);
|
|
extern unsigned int aspath_count_hops(const struct aspath *aspath);
|
|
extern bool aspath_check_as_sets(struct aspath *aspath);
|
|
extern bool aspath_check_as_zero(struct aspath *aspath);
|
|
extern unsigned int aspath_count_confeds(struct aspath *aspath);
|
|
extern unsigned int aspath_size(struct aspath *aspath);
|
|
extern as_t aspath_highest(struct aspath *aspath);
|
|
extern as_t aspath_leftmost(struct aspath *aspath);
|
|
extern size_t aspath_put(struct stream *s, struct aspath *aspath, int use32bit);
|
|
|
|
extern struct aspath *aspath_reconcile_as4(struct aspath *aspath,
|
|
struct aspath *as4path);
|
|
extern bool aspath_has_as4(struct aspath *aspath);
|
|
|
|
/* For SNMP BGP4PATHATTRASPATHSEGMENT, might be useful for debug */
|
|
extern uint8_t *aspath_snmp_pathseg(struct aspath *aspath, size_t *varlen);
|
|
|
|
extern void bgp_compute_aggregate_aspath(struct bgp_aggregate *aggregate,
|
|
struct aspath *aspath);
|
|
|
|
extern void bgp_compute_aggregate_aspath_hash(struct bgp_aggregate *aggregate,
|
|
struct aspath *aspath);
|
|
extern void bgp_compute_aggregate_aspath_val(struct bgp_aggregate *aggregate);
|
|
extern void bgp_remove_aspath_from_aggregate(struct bgp_aggregate *aggregate,
|
|
struct aspath *aspath);
|
|
extern void bgp_remove_aspath_from_aggregate_hash(
|
|
struct bgp_aggregate *aggregate,
|
|
struct aspath *aspath);
|
|
|
|
extern void bgp_aggr_aspath_remove(void *arg);
|
|
|
|
#endif /* _QUAGGA_BGP_ASPATH_H */
|