mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-05-02 01:15:33 +00:00
2f7cc7bcd3
isisd relies on its YANG module to prevent the same SID index from being configured multiple times for different prefixes. It's possible, however, to have different routers assigning the same SID index for different prefixes. When that happens, we say we have a Prefix-SID collision, which is ultimately a misconfiguration issue. The problem with Prefix-SID collisions is that the Prefix-SID that is processed later overwrites the previous ones. Then, once the Prefix-SID collision is fixed in the configuration, the overwritten Prefix-SID isn't reinstalled since it's already marked as installed and it didn't change. To prevent such inconsistency from happening, add a safeguard in the SPF code to detect Prefix-SID collisions and handle them appropriately (i.e. log a warning + ignore the Prefix-SID Sub-TLV since it's already in use by another prefix). That way, once the configuration is fixed, no Prefix-SID label entry will be missing in the LFIB. Reported-by: Emanuele Di Pascale <emanuele@voltanet.io> Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
82 lines
2.9 KiB
C
82 lines
2.9 KiB
C
/*
|
|
* IS-IS Rout(e)ing protocol - isis_spf.h
|
|
* IS-IS Shortest Path First algorithm
|
|
*
|
|
* Copyright (C) 2001,2002 Sampo Saaristo
|
|
* Tampere University of Technology
|
|
* Institute of Communications Engineering
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public Licenseas published by the Free
|
|
* Software Foundation; either version 2 of the License, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; see the file COPYING; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef _ZEBRA_ISIS_SPF_H
|
|
#define _ZEBRA_ISIS_SPF_H
|
|
|
|
#include "isisd/isis_lfa.h"
|
|
|
|
struct isis_spftree;
|
|
|
|
enum spf_type {
|
|
SPF_TYPE_FORWARD = 1,
|
|
SPF_TYPE_REVERSE,
|
|
SPF_TYPE_TI_LFA,
|
|
};
|
|
|
|
struct isis_spf_adj {
|
|
uint8_t id[ISIS_SYS_ID_LEN + 1];
|
|
struct isis_adjacency *adj;
|
|
uint32_t metric;
|
|
struct isis_ext_subtlvs *subtlvs;
|
|
struct {
|
|
uint8_t desig_is_id[ISIS_SYS_ID_LEN + 1];
|
|
struct isis_lsp *lsp_pseudo;
|
|
} lan;
|
|
uint8_t flags;
|
|
#define F_ISIS_SPF_ADJ_BROADCAST 0x01
|
|
#define F_ISIS_SPF_ADJ_OLDMETRIC 0x02
|
|
};
|
|
|
|
struct isis_spftree *isis_spftree_new(struct isis_area *area,
|
|
struct lspdb_head *lspdb,
|
|
const uint8_t *sysid, int level,
|
|
enum spf_tree_id tree_id,
|
|
enum spf_type type, uint8_t flags);
|
|
struct isis_vertex *isis_spf_prefix_sid_lookup(struct isis_spftree *spftree,
|
|
struct isis_prefix_sid *psid);
|
|
void isis_spf_invalidate_routes(struct isis_spftree *tree);
|
|
void isis_spf_verify_routes(struct isis_area *area,
|
|
struct isis_spftree **trees);
|
|
void isis_spftree_del(struct isis_spftree *spftree);
|
|
void spftree_area_init(struct isis_area *area);
|
|
void spftree_area_del(struct isis_area *area);
|
|
struct isis_lsp *isis_root_system_lsp(struct lspdb_head *lspdb,
|
|
const uint8_t *sysid);
|
|
#define isis_spf_schedule(area, level) \
|
|
_isis_spf_schedule((area), (level), __func__, \
|
|
__FILE__, __LINE__)
|
|
int _isis_spf_schedule(struct isis_area *area, int level,
|
|
const char *func, const char *file, int line);
|
|
void isis_print_spftree(struct vty *vty, struct isis_spftree *spftree);
|
|
void isis_print_routes(struct vty *vty, struct isis_spftree *spftree,
|
|
bool prefix_sid, bool backup);
|
|
void isis_spf_init(void);
|
|
void isis_spf_print(struct isis_spftree *spftree, struct vty *vty);
|
|
void isis_run_spf(struct isis_spftree *spftree);
|
|
struct isis_spftree *isis_run_hopcount_spf(struct isis_area *area,
|
|
uint8_t *sysid,
|
|
struct isis_spftree *spftree);
|
|
|
|
#endif /* _ZEBRA_ISIS_SPF_H */
|