proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-06-03 18:47:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
97a1fdf20f
mirror_frr/ospfd
History
Donald Sharp aa5ced0ac8 isisd, lib, ospfd, pathd: Null out free'd pointer 
The commands:

router isis 1
  mpls-te on
  no mpls-te on
  mpls-te on
  no mpls-te on
!

Will crash

Valgrind gives us this:
==652336== Invalid read of size 8
==652336==    at 0x49AB25C: typed_rb_min (typerb.c:495)
==652336==    by 0x4943B54: vertices_const_first (link_state.h:424)
==652336==    by 0x493DCE4: vertices_first (link_state.h:424)
==652336==    by 0x493DADC: ls_ted_del_all (link_state.c:1010)
==652336==    by 0x47E77B: isis_instance_mpls_te_destroy (isis_nb_config.c:1871)
==652336==    by 0x495BE20: nb_callback_destroy (northbound.c:1131)
==652336==    by 0x495B5AC: nb_callback_configuration (northbound.c:1356)
==652336==    by 0x4958127: nb_transaction_process (northbound.c:1473)
==652336==    by 0x4958275: nb_candidate_commit_apply (northbound.c:906)
==652336==    by 0x49585B8: nb_candidate_commit (northbound.c:938)
==652336==    by 0x495CE4A: nb_cli_classic_commit (northbound_cli.c:64)
==652336==    by 0x495D6C5: nb_cli_apply_changes_internal (northbound_cli.c:250)
==652336==  Address 0x6f928e0 is 272 bytes inside a block of size 320 free'd
==652336==    at 0x48399AB: free (vg_replace_malloc.c:538)
==652336==    by 0x494BA30: qfree (memory.c:141)
==652336==    by 0x493D99D: ls_ted_del (link_state.c:997)
==652336==    by 0x493DC20: ls_ted_del_all (link_state.c:1018)
==652336==    by 0x47E77B: isis_instance_mpls_te_destroy (isis_nb_config.c:1871)
==652336==    by 0x495BE20: nb_callback_destroy (northbound.c:1131)
==652336==    by 0x495B5AC: nb_callback_configuration (northbound.c:1356)
==652336==    by 0x4958127: nb_transaction_process (northbound.c:1473)
==652336==    by 0x4958275: nb_candidate_commit_apply (northbound.c:906)
==652336==    by 0x49585B8: nb_candidate_commit (northbound.c:938)
==652336==    by 0x495CE4A: nb_cli_classic_commit (northbound_cli.c:64)
==652336==    by 0x495D6C5: nb_cli_apply_changes_internal (northbound_cli.c:250)
==652336==  Block was alloc'd at
==652336==    at 0x483AB65: calloc (vg_replace_malloc.c:760)
==652336==    by 0x494B6F8: qcalloc (memory.c:116)
==652336==    by 0x493D7D2: ls_ted_new (link_state.c:967)
==652336==    by 0x47E4DD: isis_instance_mpls_te_create (isis_nb_config.c:1832)
==652336==    by 0x495BB29: nb_callback_create (northbound.c:1034)
==652336==    by 0x495B547: nb_callback_configuration (northbound.c:1348)
==652336==    by 0x4958127: nb_transaction_process (northbound.c:1473)
==652336==    by 0x4958275: nb_candidate_commit_apply (northbound.c:906)
==652336==    by 0x49585B8: nb_candidate_commit (northbound.c:938)
==652336==    by 0x495CE4A: nb_cli_classic_commit (northbound_cli.c:64)
==652336==    by 0x495D6C5: nb_cli_apply_changes_internal (northbound_cli.c:250)
==652336==    by 0x495D23E: nb_cli_apply_changes (northbound_cli.c:268)

Let's null out the pointer.  After this change.  Valgrind no longer reports issues
and isisd no longer crashes.

Fixes: #10939
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-03-31 15:59:46 -04:00
..
.gitignore *: cleanup .gitignore files 2018-09-08 21:30:42 +02:00
ChangeLog.opaque.txt Initial revision 2003-02-03 16:31:16 +00:00
Makefile build: non-recursive ospf* 2017-08-04 11:09:50 +02:00
ospf_abr.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_abr.h ospfd: fix NSSA translator 2020-11-18 23:23:14 -08:00
ospf_api.c ospfd: Correct Coverity defects 2021-05-19 09:48:54 +02:00
ospf_api.h ospfd: Correct Coverity defects 2021-05-19 09:48:54 +02:00
ospf_apiserver.c ospfd: Convert enum event to enum ospf_apiserver_event 2022-03-02 09:17:57 -05:00
ospf_apiserver.h ospfd: Convert enum event to enum ospf_apiserver_event 2022-03-02 09:17:57 -05:00
ospf_asbr.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_asbr.h ospfd: adjust type of "aggr_delay_interval" 2022-01-28 20:11:40 -05:00
ospf_ase.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_ase.h *: reindent 2017-07-17 14:04:07 +02:00
ospf_bfd.c lib: remove enabled flag for bfd sessions 2021-04-22 16:39:29 +03:00
ospf_bfd.h ospfd: rework BFD integration 2021-03-23 10:18:42 -03:00
ospf_dump_api.c ospfd: replace inet_ntoa 2020-10-22 13:37:25 -04:00
ospf_dump_api.h *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_dump.c ospfd: Convert output to host order from network order for route_tag 2022-01-31 12:51:18 -05:00
ospf_dump.h ospfd: Adding apropriate ism state in ptop neighbors. 2021-10-26 05:36:20 -07:00
ospf_errors.c ospfd: Add Segment Routing Local Block 2020-08-20 14:37:40 +02:00
ospf_errors.h ospfd: Add Segment Routing Local Block 2020-08-20 14:37:40 +02:00
ospf_ext.c Merge pull request #9683 from volta-networks/sr-minor-fixes 2021-11-20 14:53:09 +03:00
ospf_ext.h ospfd: Add Segment Routing Local Block 2020-08-20 14:37:40 +02:00
ospf_flood.c ospfd: Summarised External LSA is not flushed in one scenario 2021-08-17 02:15:42 -07:00
ospf_flood.h ospfd: introduce support for Graceful Restart (restarting mode) 2021-07-05 11:43:02 -03:00
ospf_gr_helper.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_gr.c ospfd,ospf6d: Add missing newline for graceful-restart prepare CLI 2022-03-09 22:56:53 +02:00
ospf_gr.h ospfd: introduce support for Graceful Restart (restarting mode) 2021-07-05 11:43:02 -03:00
ospf_ia.c ospfd: replace inet_ntoa 2020-10-22 13:37:25 -04:00
ospf_ia.h *: reindent 2017-07-17 14:04:07 +02:00
ospf_interface.c ospfd: Core in ospf_if_down during shutdown. 2022-02-04 10:26:54 +02:00
ospf_interface.h ospfd: Cleanup ospf_interface.h to work with our standards 2021-08-06 10:46:48 -04:00
ospf_ism.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_ism.h *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_ldp_sync.c Merge pull request #10447 from ton31337/fix/json_with_whitespaces 2022-03-13 18:19:33 -04:00
ospf_ldp_sync.h ldpd, isisd, ospfd: Remove periodic ldp-sync hello message 2020-12-09 14:11:38 -05:00
ospf_lsa.c ospfd: Default route becomes stale route in nbrs even after flush from originator. 2022-03-21 02:55:29 -07:00
ospf_lsa.h *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_lsdb.c ospfd: Use AF_UNSPEC instead of setting to 0 2022-02-07 13:20:43 -05:00
ospf_lsdb.h ospfd: replace pqueue_* with DECLARE_SKIPLIST 2019-04-27 19:33:45 +02:00
ospf_main.c *: Convert quagga_signal_X to frr_signal_X 2021-11-11 14:41:27 -05:00
ospf_memory.c *: require semicolon after DEFINE_MTYPE & co 2021-03-17 06:18:17 +01:00
ospf_memory.h *: require semicolon after DEFINE_MTYPE & co 2021-03-17 06:18:17 +01:00
ospf_neighbor.c ospfd: Fix assert related to capability opaque 2021-09-29 19:37:33 +00:00
ospf_neighbor.h ospfd: rename the graceful restart header 2021-07-05 11:43:02 -03:00
ospf_network.c ospfd: don't exit when socket is not created 2021-07-27 16:10:35 +03:00
ospf_network.h ospfd: basic support for VRF NETNS backend 2018-02-27 11:11:24 +01:00
ospf_nsm.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_nsm.h *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_opaque.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_opaque.h Merge pull request #9368 from donaldsharp/ospf_ensure_lsa_length 2021-10-29 13:37:09 +03:00
ospf_packet.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_packet.h *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_ri.c ospfd: fix display of plain-text data on "show ... json" commands 2021-10-08 10:03:01 -03:00
ospf_ri.h ospfd: Correct Coverity defects 2021-05-19 09:48:54 +02:00
ospf_route.c lib, ospfd, ospf6d, zebra: add OSPF opaque route attributes 2022-01-15 17:22:27 +01:00
ospf_route.h lib, ospfd, ospf6d, zebra: add OSPF opaque route attributes 2022-01-15 17:22:27 +01:00
ospf_routemap_nb_config.c *: make sure config.h or zebra.h is first 2021-04-23 12:06:35 +02:00
ospf_routemap_nb.c *: make sure config.h or zebra.h is first 2021-04-23 12:06:35 +02:00
ospf_routemap_nb.h ospfd: North-bound implementation for ospfd rmaps 2021-03-30 22:59:30 +03:00
ospf_routemap.c ospfd: don't use if_lookup_by_name_all_vrf 2021-10-15 03:44:42 +03:00
ospf_snmp.c ospfd: Use AF_UNSPEC instead of setting to 0 2022-02-07 13:20:43 -05:00
ospf_spf.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospf_spf.h ospfd: introduce support for Graceful Restart (restarting mode) 2021-07-05 11:43:02 -03:00
ospf_sr.c ospfd: show running-config displays also srgb on some cases 2022-03-25 15:18:34 +01:00
ospf_sr.h ospfd: validate input SRGB and SRLB 2021-09-28 10:40:32 +02:00
ospf_te.c isisd, lib, ospfd, pathd: Null out free'd pointer 2022-03-31 15:59:46 -04:00
ospf_te.h ospfd: Add Link-State support 2021-03-23 15:39:29 +01:00
ospf_ti_lfa.c *: Replace IPV4_MAX_PREFIXLEN to IPV4_MAX_BITLEN 2021-07-01 17:44:09 +03:00
ospf_ti_lfa.h ospfd: Add support for TI-LFA node protection 2021-01-19 15:32:13 +00:00
ospf_vty.c ospfd: Show neighbor state in full format (e.g. Full/DR instead of Full) 2022-03-30 22:28:39 +03:00
ospf_vty.h ospfd: TI-LFA basic infrastructure and algorithms 2021-01-19 15:32:13 +00:00
ospf_zebra.c ospfd: fix ospf default route wrongly sent back 2022-03-25 15:40:46 +01:00
ospf_zebra.h ospfd: introduce support for Graceful Restart (restarting mode) 2021-07-05 11:43:02 -03:00
OSPF-ALIGNMENT.txt *: Remove cvs control points 2017-12-05 17:28:12 -05:00
ospfd.c *: Change thread->func to return void instead of int 2022-02-23 19:56:04 -05:00
ospfd.h ospfd: adjust type of "aggr_delay_interval" 2022-01-28 20:11:40 -05:00
subdir.am build: fix AM_LDFLAGS usage (and gcov) 2021-07-21 17:10:08 +02:00