mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-08-05 14:31:51 +00:00

When running the bgp_bmp_2 vrf test, peer vrf up/down events from the pre and post policy are received with a wrong peer distinguisher value. > {"peer_type": "route distinguisher instance", "policy": "pre-policy", > "ipv6": true, "peer_ip": "192:168::2", "peer_distinguisher": "0:0", > "peer_asn": 65502, "peer_bgp_id": "192.168.0.2", "timestamp": > "2024-10-16 21:59:53.111962", "bmp_log_type": "peer up", "local_ip": > "192:168::1", "local_port": 179, "remote_port": 50836, "seq": 5} RFC7854 mentions in 4.2 that if the peer is a "RD Instance Peer", it is set to the route distinguisher of the particular instance the peer belongs to. Fix this by modifying the BMP client, update the peer distinguisher value by filling the peer distinguisher in the bmp_peerstate function. > {"peer_type": "route distinguisher instance", "policy": "pre-policy", > "ipv6": true, "peer_ip": "192:168::2", "peer_distinguisher": "444:1", > "peer_asn": 65502, "peer_bgp_id": "192.168.0.2", "timestamp": > "2024-10-16 21:59:53.111962", "bmp_log_type": "peer up", "local_ip": > "192:168::1", "local_port": 179, "remote_port": 50836, "seq": 5} Add a test to check that peer_distinguisher value is not 0:0 when an RD instance is set. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
231 lines
6.3 KiB
Python
231 lines
6.3 KiB
Python
#!/usr/bin/env python
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
# Copyright 2023, 6wind
|
|
import json
|
|
import os
|
|
|
|
from lib import topotest
|
|
from lib.topogen import get_topogen
|
|
from lib.topolog import logger
|
|
|
|
# remember the last sequence number of the logging messages
|
|
SEQ = 0
|
|
|
|
|
|
def bmp_reset_seq():
|
|
global SEQ
|
|
SEQ = 0
|
|
|
|
|
|
def get_bmp_messages(bmp_collector, bmp_log_file):
|
|
"""
|
|
Read the BMP logging messages.
|
|
"""
|
|
messages = []
|
|
text_output = bmp_collector.run(f"cat {bmp_log_file}")
|
|
|
|
for m in text_output.splitlines():
|
|
# some output in the bash can break the message decoding
|
|
try:
|
|
messages.append(json.loads(m))
|
|
except Exception as e:
|
|
logger.warning(str(e) + " message: {}".format(str(m)))
|
|
continue
|
|
|
|
if not messages:
|
|
logger.error("Bad BMP log format, check your BMP server")
|
|
|
|
return messages
|
|
|
|
|
|
def bmp_update_seq(bmp_collector, bmp_log_file):
|
|
global SEQ
|
|
|
|
messages = get_bmp_messages(bmp_collector, bmp_log_file)
|
|
|
|
if len(messages):
|
|
SEQ = messages[-1]["seq"]
|
|
|
|
|
|
def bmp_update_expected_files(
|
|
bmp_actual,
|
|
expected_prefixes,
|
|
bmp_log_type,
|
|
policy,
|
|
step,
|
|
bmp_client,
|
|
bmp_log_folder,
|
|
):
|
|
tgen = get_topogen()
|
|
|
|
with open(
|
|
f"{bmp_log_folder}/tmp/bmp-{bmp_log_type}-{policy}-step{step}.json", "w"
|
|
) as json_file:
|
|
json.dump(bmp_actual, json_file, indent=4)
|
|
|
|
out = bmp_client.vtysh_cmd("show bgp vrf vrf1 ipv4 json", isjson=True)
|
|
filtered_out = {
|
|
"routes": {
|
|
prefix: route_info
|
|
for prefix, route_info in out["routes"].items()
|
|
if prefix in expected_prefixes
|
|
}
|
|
}
|
|
if bmp_log_type == "withdraw":
|
|
for pfx in expected_prefixes:
|
|
if "::" in pfx:
|
|
continue
|
|
filtered_out["routes"][pfx] = None
|
|
|
|
# ls {bmp_log_folder}/tmp/show*json | while read file; do egrep -v 'prefix|network|metric|ocPrf|version|weight|peerId|vrf|Version|valid|Reason|fe80' $file >$(basename $file); echo >> $(basename $file); done
|
|
with open(
|
|
f"{bmp_log_folder}/tmp/show-bgp-ipv4-{bmp_log_type}-step{step}.json", "w"
|
|
) as json_file:
|
|
json.dump(filtered_out, json_file, indent=4)
|
|
|
|
out = tgen.gears["r1"].vtysh_cmd("show bgp vrf vrf1 ipv6 json", isjson=True)
|
|
filtered_out = {
|
|
"routes": {
|
|
prefix: route_info
|
|
for prefix, route_info in out["routes"].items()
|
|
if prefix in expected_prefixes
|
|
}
|
|
}
|
|
if bmp_log_type == "withdraw":
|
|
for pfx in expected_prefixes:
|
|
if "::" not in pfx:
|
|
continue
|
|
filtered_out["routes"][pfx] = None
|
|
|
|
with open(
|
|
f"{bmp_log_folder}/tmp/show-bgp-ipv6-{bmp_log_type}-step{step}.json", "w"
|
|
) as json_file:
|
|
json.dump(filtered_out, json_file, indent=4)
|
|
|
|
|
|
def bmp_check_for_prefixes(
|
|
expected_prefixes,
|
|
bmp_log_type,
|
|
policy,
|
|
step,
|
|
bmp_collector,
|
|
bmp_log_folder,
|
|
bmp_client,
|
|
expected_json_path,
|
|
update_expected_json,
|
|
loc_rib,
|
|
):
|
|
"""
|
|
Check for the presence of the given prefixes in the BMP server logs with
|
|
the given message type and the set policy.
|
|
|
|
"""
|
|
global SEQ
|
|
|
|
bmp_log_file = f"{bmp_log_folder}/bmp.log"
|
|
# we care only about the new messages
|
|
messages = [
|
|
m
|
|
for m in sorted(
|
|
get_bmp_messages(bmp_collector, bmp_log_file), key=lambda d: d["seq"]
|
|
)
|
|
if m["seq"] > SEQ
|
|
]
|
|
|
|
# create empty initial files
|
|
# for step in $(seq 1); do
|
|
# for i in "update" "withdraw"; do
|
|
# for j in "pre-policy" "post-policy" "loc-rib"; do
|
|
# echo '{"null": {}}'> bmp-$i-$j-step$step.json
|
|
# done
|
|
# done
|
|
# done
|
|
|
|
ref_file = f"{expected_json_path}/bmp-{bmp_log_type}-{policy}-step{step}.json"
|
|
expected = json.loads(open(ref_file).read())
|
|
|
|
# Build actual json from logs
|
|
actual = {}
|
|
for m in messages:
|
|
if (
|
|
"bmp_log_type" in m.keys()
|
|
and "ip_prefix" in m.keys()
|
|
and m["ip_prefix"] in expected_prefixes
|
|
and m["bmp_log_type"] == bmp_log_type
|
|
and m["policy"] == policy
|
|
):
|
|
policy_dict = actual.setdefault(m["policy"], {})
|
|
bmp_log_type_dict = policy_dict.setdefault(m["bmp_log_type"], {})
|
|
|
|
# Add or update the ip_prefix dictionary with filtered key-value pairs
|
|
bmp_log_type_dict[m["ip_prefix"]] = {
|
|
k: v
|
|
for k, v in sorted(m.items())
|
|
# filter out variable keys
|
|
if k not in ["timestamp", "seq", "nxhp_link-local"]
|
|
}
|
|
|
|
# build expected JSON files
|
|
if (
|
|
update_expected_json
|
|
and actual
|
|
and set(actual.get(policy, {}).get(bmp_log_type, {}).keys())
|
|
== set(expected_prefixes)
|
|
):
|
|
bmp_update_expected_files(
|
|
actual,
|
|
expected_prefixes,
|
|
bmp_log_type,
|
|
policy,
|
|
step,
|
|
bmp_client,
|
|
bmp_log_folder,
|
|
)
|
|
|
|
return topotest.json_cmp(actual, expected, exact=True)
|
|
|
|
|
|
def bmp_check_for_peer_message(
|
|
expected_peers, bmp_log_type, bmp_collector, bmp_log_file, is_rd_instance=False
|
|
):
|
|
"""
|
|
Check for the presence of a peer up message for the peer
|
|
"""
|
|
global SEQ
|
|
|
|
# we care only about the new messages
|
|
messages = [
|
|
m
|
|
for m in sorted(
|
|
get_bmp_messages(bmp_collector, bmp_log_file), key=lambda d: d["seq"]
|
|
)
|
|
if m["seq"] > SEQ
|
|
]
|
|
|
|
# get the list of pairs (prefix, policy, seq) for the given message type
|
|
peers = []
|
|
for m in messages:
|
|
if is_rd_instance and m["peer_distinguisher"] == "0:0":
|
|
continue
|
|
if (
|
|
"peer_ip" in m.keys()
|
|
and m["peer_ip"] != "0.0.0.0"
|
|
and m["bmp_log_type"] == bmp_log_type
|
|
):
|
|
if is_rd_instance and m["peer_type"] != "route distinguisher instance":
|
|
continue
|
|
peers.append(m["peer_ip"])
|
|
elif m["policy"] == "loc-rib" and m["bmp_log_type"] == bmp_log_type:
|
|
peers.append("0.0.0.0")
|
|
|
|
# check for prefixes
|
|
for ep in expected_peers:
|
|
if ep not in peers:
|
|
msg = "The peer {} is not present in the {} log messages."
|
|
logger.debug(msg.format(ep, bmp_log_type))
|
|
return False
|
|
|
|
SEQ = messages[-1]["seq"]
|
|
return True
|