mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-11-03 06:28:33 +00:00
8da8689d91
ISSUES 1. When an interface goes down, the zclient callbacks are invoked in the following order: (a) address_delete() that removes the connected address list: ifp->connected, (b) interface_down() that performs "fast external fallover" operation. The operation relies on ifp->connected to look for peers that should be brought down. That's a cyclic dependency. 2. 'ttl-security' configuration handler sets peer->ttl to MAXTTL (so that BGP packets are sent with TTL=255, as per the requirement of ttl-security). This, however, is incompatible with 'fast external fallover' as the fallover operation checks for (ttl == 1) to determine directly connected peers. 3. The current fallover operation does not work for IPv6 address family. PATCH 1. The patch removes the dependency on 'ifp->connected' list for fast fallover. The peer already contains a nexthop structure that reflects the peering address. The nexthop structure has a pointer to the interface (ifp) that peering address resolves to. Everytime the TCP connection succeeds, the ifp is updated. The patch uses this ifp in the interface_down() callback for a match for the peers that should be brought down. 2. The evaluation for directly connected peering is enhanced as 'peer->ttl == 1' OR 'peer->gtsm_hops == 1'. Thus a ttl-security configuration on the peer with one hop is directly connected and should be brought down under 'fast external fallover'. 3. Because of fix (1), IPv6 address family works automatically. Signed-off-by: Pradosh Mohapatra <pmohapat@cumulusnetworks.com> Reviewed-by: Dinesh G Dutt <ddutt@cumulusnetworks.com> Signed-off-by: David Lamparter <equinox@opensourcerouting.org> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| BGP4-MIB.txt | ||
| bgp_advertise.c | ||
| bgp_advertise.h | ||
| bgp_aspath.c | ||
| bgp_aspath.h | ||
| bgp_attr.c | ||
| bgp_attr.h | ||
| bgp_btoa.c | ||
| bgp_clist.c | ||
| bgp_clist.h | ||
| bgp_community.c | ||
| bgp_community.h | ||
| bgp_damp.c | ||
| bgp_damp.h | ||
| bgp_debug.c | ||
| bgp_debug.h | ||
| bgp_dump.c | ||
| bgp_dump.h | ||
| bgp_ecommunity.c | ||
| bgp_ecommunity.h | ||
| bgp_filter.c | ||
| bgp_filter.h | ||
| bgp_fsm.c | ||
| bgp_fsm.h | ||
| bgp_main.c | ||
| bgp_mpath.c | ||
| bgp_mpath.h | ||
| bgp_mplsvpn.c | ||
| bgp_mplsvpn.h | ||
| bgp_network.c | ||
| bgp_network.h | ||
| bgp_nexthop.c | ||
| bgp_nexthop.h | ||
| bgp_open.c | ||
| bgp_open.h | ||
| bgp_packet.c | ||
| bgp_packet.h | ||
| bgp_regex.c | ||
| bgp_regex.h | ||
| bgp_route.c | ||
| bgp_route.h | ||
| bgp_routemap.c | ||
| bgp_snmp.c | ||
| bgp_snmp.h | ||
| bgp_table.c | ||
| bgp_table.h | ||
| bgp_vty.c | ||
| bgp_vty.h | ||
| bgp_zebra.c | ||
| bgp_zebra.h | ||
| bgpd.c | ||
| bgpd.conf.sample | ||
| bgpd.conf.sample2 | ||
| bgpd.h | ||
| IMPLEMENTATION.txt | ||
| Makefile.am | ||