mirror_frr/ospfd
Donald Sharp 85d25587bf eigrpd, ospfd, pimd: Fix assumption that interface may not be up
Commit: ddbf3e6060

This commit modified the interface up handling code in
ZAPI such that the zclient handled the decoding for you.
Prior to this commit ospf assumed that it could use the
old ifp pointer to know state before reading the stream.
This lead to a situation where ospf would `smartly` track
and do the right thing in this situation.  This commit
changed this assumption and in certain scenarios, say
a interface was changed after it was already up would
lead to situations where ospf would not properly handle
the new interface up.

Modify ospf to track data that is important to it in
it's interface->info pointer.

This code pattern was followed in both eigrp and pim.
In eigrp's case it was just behaving weirdly in any event
so fixing this pattern is not a big deal.  In pim's
case it was not properly using this so it's a no-op
to fix.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-12-04 14:23:20 -05:00
..
.gitignore *: cleanup .gitignore files 2018-09-08 21:30:42 +02:00
ChangeLog.opaque.txt Initial revision 2003-02-03 16:31:16 +00:00
Makefile build: non-recursive ospf* 2017-08-04 11:09:50 +02:00
ospf_abr.c ospfd: handling of OSPF_AREA_RANGE_ADVERTISE flag 2018-09-24 21:46:16 -07:00
ospf_abr.h *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_api.c ospfd: Remove ORIGINAL_CODING check 2019-11-19 07:47:19 -05:00
ospf_api.h ospfd: Remove ORIGINAL_CODING check 2019-11-19 07:47:19 -05:00
ospf_apiserver.c ospfd: nbr->oi is never null 2019-11-21 18:47:13 -05:00
ospf_apiserver.h *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_asbr.c ospfd: Add/fix some debugs to handle vrf 2019-11-19 07:47:19 -05:00
ospf_asbr.h ospfd: Remove unused function 2018-08-21 08:40:51 -04:00
ospf_ase.c *: strip trailing whitespace 2019-09-30 16:44:43 +00:00
ospf_ase.h *: reindent 2017-07-17 14:04:07 +02:00
ospf_bfd.c ospf: BFD down not tearing down OSPF adjacency for point-to-point network 2019-10-31 11:11:44 +00:00
ospf_bfd.h bgpd/ospfd: make bgp and ospf json response a bit more consistent 2018-08-30 12:40:18 +00:00
ospf_dump_api.c *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_dump_api.h *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_dump.c ospfd: The ip header dump is crazy long and useless 2019-11-19 07:47:19 -05:00
ospf_dump.h ospfd: The ip header dump is crazy long and useless 2019-11-19 07:47:19 -05:00
ospf_errors.c *: Fix spelling errors pointed out by debian packaging 2019-08-19 10:36:53 -04:00
ospf_errors.h ospfd: ospfd core if hello packet exceeds link MTU 2019-01-27 20:27:58 -08:00
ospf_ext.c *: list_delete_and_null() -> list_delete() 2018-10-02 11:40:52 +02:00
ospf_ext.h *: conform with COMMUNITY.md formatting rules, via 'make indent' 2018-03-06 14:04:32 -05:00
ospf_flood.c ospfd: nbr->oi is never null 2019-11-21 18:47:13 -05:00
ospf_flood.h ospfd: OSPFv2 VRF Support 2017-10-03 09:15:19 -07:00
ospf_ia.c bgpd isisd ospf6d ospfd: variable shadowing fixes 2018-09-12 16:44:36 +02:00
ospf_ia.h *: reindent 2017-07-17 14:04:07 +02:00
ospf_interface.c eigrpd, ospfd, pimd: Fix assumption that interface may not be up 2019-12-04 14:23:20 -05:00
ospf_interface.h eigrpd, ospfd, pimd: Fix assumption that interface may not be up 2019-12-04 14:23:20 -05:00
ospf_ism.c *: generously apply const 2019-12-02 15:01:29 +01:00
ospf_ism.h ospfd: Do not turn on write thread unless we have something in it 2019-08-30 16:48:07 -04:00
ospf_lsa.c *: generously apply const 2019-12-02 15:01:29 +01:00
ospf_lsa.h Revert "ospfd: remove default origin max age lsa" 2019-08-02 11:29:03 +02:00
ospf_lsdb.c ospfd: replace pqueue_* with DECLARE_SKIPLIST 2019-04-27 19:33:45 +02:00
ospf_lsdb.h ospfd: replace pqueue_* with DECLARE_SKIPLIST 2019-04-27 19:33:45 +02:00
ospf_main.c *: generously apply const 2019-12-02 15:01:29 +01:00
ospf_memory.c OSPF: Add support to multi-area to Router Info. 2018-11-09 10:09:47 +01:00
ospf_memory.h OSPF: Add support to multi-area to Router Info. 2018-11-09 10:09:47 +01:00
ospf_neighbor.c ospfd: nbr->oi is never null 2019-11-21 18:47:13 -05:00
ospf_neighbor.h *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_network.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
ospf_network.h ospfd: basic support for VRF NETNS backend 2018-02-27 11:11:24 +01:00
ospf_nsm.c *: generously apply const 2019-12-02 15:01:29 +01:00
ospf_nsm.h *: reindent 2017-07-17 14:04:07 +02:00
ospf_opaque.c ospfd: Function order caused use after free. 2019-11-11 10:17:31 -05:00
ospf_opaque.h *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_packet.c ospfd: nbr->oi is never null 2019-11-21 18:47:13 -05:00
ospf_packet.h ospfd: tighten up what functions can be used outside of ospf_packet.c 2019-08-30 16:48:07 -04:00
ospf_ri.c *: remove trailing newlines from zlog messages 2019-03-14 18:41:15 +00:00
ospf_ri.h OSPF: Add support to multi-area to Router Info. 2018-11-09 10:09:47 +01:00
ospf_route.c *: generously apply const 2019-12-02 15:01:29 +01:00
ospf_route.h *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_routemap.c *: make all route_map_rule_cmd const 2019-11-30 00:38:32 +01:00
ospf_snmp.c ospfd: nbr->oi is never null 2019-11-21 18:47:13 -05:00
ospf_spf.c *: s/TRUE/true/, s/FALSE/false/ 2019-07-01 17:26:05 +00:00
ospf_spf.h ospfd: replace pqueue_* with DECLARE_SKIPLIST 2019-04-27 19:33:45 +02:00
ospf_sr.c ospfd: avoid installing SR FTNs twice 2019-09-10 00:37:00 -03:00
ospf_sr.h zebra: identify MPLS FTNs by route type and instance 2019-09-06 21:06:11 -03:00
ospf_te.c *: generously apply const 2019-12-02 15:01:29 +01:00
ospf_te.h *: use C99 standard fixed-width integer types 2018-03-27 15:13:34 -04:00
ospf_vty.c ospfd: interface name and ip address can be 32 bytes 2019-12-04 14:23:20 -05:00
ospf_vty.h ospfd: buffer termination (Coverity 23089) 2018-06-14 17:43:19 +02:00
ospf_zebra.c *: Convert connected_free to a double pointer 2019-11-02 16:13:44 -04:00
ospf_zebra.h *: Convert zapi->interface_delete to ifp callback 2019-09-19 13:34:06 -04:00
OSPF-ALIGNMENT.txt *: Remove cvs control points 2017-12-05 17:28:12 -05:00
ospfd.c ospfd: Add a function to return the name of the vrf we are in. 2019-11-19 07:47:19 -05:00
ospfd.conf.sample Initial revision 2002-12-13 20:15:29 +00:00
ospfd.h ospfd: Add a function to return the name of the vrf we are in. 2019-11-19 07:47:19 -05:00
subdir.am build: fix a whole bunch of *FLAGS 2019-01-30 19:13:51 +01:00