mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-05-21 09:57:24 +00:00
b68885f9b7
Introducing a 3rd state for route_map_apply library function: RMAP_NOOP Traditionally route map MATCH rule apis were designed to return a binary response, consisting of either RMAP_MATCH or RMAP_NOMATCH. (Route-map SET rule apis return RMAP_OKAY or RMAP_ERROR). Depending on this response, the following statemachine decided the course of action: State1: If match cmd returns RMAP_MATCH then, keep existing behaviour. If routemap type is PERMIT, execute set cmds or call cmds if applicable, otherwise PERMIT! Else If routemap type is DENY, we DENYMATCH right away State2: If match cmd returns RMAP_NOMATCH, continue on to next route-map. If there are no other rules or if all the rules return RMAP_NOMATCH, return DENYMATCH We require a 3rd state because of the following situation: The issue - what if, the rule api needs to abort or ignore a rule?: "match evpn vni xx" route-map filter can be applied to incoming routes regardless of whether the tunnel type is vxlan or mpls. This rule should be N/A for mpls based evpn route, but applicable to only vxlan based evpn route. Also, this rule should be applicable for routes with VNI label only, and not for routes without labels. For example, type 3 and type 4 EVPN routes do not have labels, so, this match cmd should let them through. Today, the filter produces either a match or nomatch response regardless of whether it is mpls/vxlan, resulting in either permitting or denying the route.. So an mpls evpn route may get filtered out incorrectly. Eg: "route-map RM1 permit 10 ; match evpn vni 20" or "route-map RM2 deny 20 ; match vni 20" With the introduction of the 3rd state, we can abort this rule check safely. How? The rules api can now return RMAP_NOOP to indicate that it encountered an invalid check, and needs to abort just that rule, but continue with other rules. As a result we have a 3rd state: State3: If match cmd returned RMAP_NOOP Then, proceed to other route-map, otherwise if there are no more rules or if all the rules return RMAP_NOOP, then, return RMAP_PERMITMATCH. Signed-off-by: Lakshman Krishnamoorthy <lkrishnamoor@vmware.com> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| AUTHORS | ||
| fabricd.c | ||
| fabricd.conf.sample | ||
| fabricd.h | ||
| isis_adjacency.c | ||
| isis_adjacency.h | ||
| isis_bfd.c | ||
| isis_bfd.h | ||
| isis_bpf.c | ||
| isis_circuit.c | ||
| isis_circuit.h | ||
| isis_cli.c | ||
| isis_cli.h | ||
| isis_common.h | ||
| isis_constants.h | ||
| isis_csm.c | ||
| isis_csm.h | ||
| isis_dlpi.c | ||
| isis_dr.c | ||
| isis_dr.h | ||
| isis_dynhn.c | ||
| isis_dynhn.h | ||
| isis_errors.c | ||
| isis_errors.h | ||
| isis_events.c | ||
| isis_events.h | ||
| isis_flags.c | ||
| isis_flags.h | ||
| isis_lsp.c | ||
| isis_lsp.h | ||
| isis_main.c | ||
| isis_memory.c | ||
| isis_memory.h | ||
| isis_misc.c | ||
| isis_misc.h | ||
| isis_mt.c | ||
| isis_mt.h | ||
| isis_network.h | ||
| isis_northbound.c | ||
| isis_pdu_counter.c | ||
| isis_pdu_counter.h | ||
| isis_pdu.c | ||
| isis_pdu.h | ||
| isis_pfpacket.c | ||
| isis_redist.c | ||
| isis_redist.h | ||
| isis_route.c | ||
| isis_route.h | ||
| isis_routemap.c | ||
| isis_routemap.h | ||
| isis_spf_private.h | ||
| isis_spf.c | ||
| isis_spf.h | ||
| isis_te.c | ||
| isis_te.h | ||
| isis_tlvs.c | ||
| isis_tlvs.h | ||
| isis_tx_queue.c | ||
| isis_tx_queue.h | ||
| isis_vty_fabricd.c | ||
| isis_zebra.c | ||
| isis_zebra.h | ||
| isisd.c | ||
| isisd.conf.sample | ||
| isisd.h | ||
| iso_checksum.c | ||
| iso_checksum.h | ||
| Makefile | ||
| README | ||
| subdir.am | ||
Constraints o Maximum number of interfaces 255