mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-08-06 10:54:47 +00:00
5f37d86f83
Subject: [zebra 18677] zebra initialisation bug and patch Hi All, I have found a bug in zebra that prevents its routing table and interface database from being initialised properly. The problem occurs when a request is made via the netlink socket but the kernel produces a EWOULDBLOCK/EAGAIN when the result is trying to be retrieved via a recvmsg(). Zebra does not do anything about this and continues to function (with an empty routing table and interface list) as if nothing has happened. With no such information the routing protocol dosn't work! Two functions are called during the initialisation of Zebra: interface_lookup_netlink() and netlink_route_read() - obtaining the interfaces and routing table from the kernel respectively. These are the only time these functions are called. These functions, interface_lookup_netlink() and netlink_route_read(), use netlink_parse_info() to recieve the data from the netlink socket. The problem is, netlink_parse_info() returns (without error) when its call to recvmsg() results in an errno EWOULDBLOCK/EAGAIN. This behaviour is expected by other funtions calling netlink_parse_info() - netlink_parse_info is simply recalled at a later stage. However, on initialisation it is never recalled. Since zebra is expected to nothing else during initialisation it was easiest to temporarily change the netlink socket to BLOCK and wait indefinently until the kernel responds with the required information. Attached is a patch with these changes. Comments and questions are welcome. Please inform me if this patch is added to the Zebra source. --israel |
||
|---|---|---|
| bgpd | ||
| doc | ||
| guile | ||
| init | ||
| lib | ||
| ospf6d | ||
| ospfclient | ||
| ospfd | ||
| ports | ||
| redhat | ||
| ripd | ||
| ripngd | ||
| tools | ||
| vtysh | ||
| zebra | ||
| .cvsignore | ||
| acconfig.h | ||
| AUTHORS | ||
| ChangeLog | ||
| config.guess | ||
| config.sub | ||
| configure.ac | ||
| configure.in | ||
| COPYING | ||
| COPYING.LIB | ||
| depcomp | ||
| INSTALL | ||
| install-sh | ||
| Makefile.am | ||
| missing | ||
| mkinstalldirs | ||
| NEWS | ||
| README | ||
| REPORTING-BUGS | ||
| SERVICES | ||
| stamp-h.in | ||
| TODO | ||
| update-autotools | ||
GNU Zebra is free software that manages various IPv4 and IPv6 routing protocols. Currently GNU Zebra supports BGP4, BGP4+, OSPFv2, OSPFv3, RIPv1, RIPv2, and RIPng. See the file INSTALL for building and installation instructions. See the file REPORTING-BUGS to report bugs. GNU Zebra is free software. See the file COPYING for copying conditions.