Go to file
Daniel Walton 5f007459f6 bgpd: peer-group members 'activate' when they shouldn't
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by:   Donald Sharp <sharpd@cumulusnetworks.com>

Today if you configure the following where the 'fabric' peer-group has
been deactivated for ipv4 unicast and then assign swp1/swp2 to that
peer-group we end up activating those two peers for ipv4 unicast.

conf t
no router bgp 100
router bgp 100
  neighbor fabric peer-group
  neighbor fabric capability extended-nexthop
  neighbor fabric remote-as external
  !
  address-family ipv4 unicast
    no neighbor fabric activate
  !
  neighbor swp1 interface peer-group fabric
  neighbor swp2 interface peer-group fabric
  neighbor 1.1.1.1 peer-group fabric
end

cel-redxp-10# show run bgp
!
router bgp 100
 neighbor fabric peer-group
 neighbor fabric remote-as external
 neighbor fabric capability extended-nexthop
 neighbor swp1 interface peer-group fabric
 neighbor swp2 interface peer-group fabric
 neighbor 1.1.1.1 peer-group fabric
 !
 address-family ipv4 unicast
  no neighbor fabric activate
  neighbor swp1 activate
  neighbor swp2 activate
 exit-address-family
!
cel-redxp-10#

With the patch we do not activate swp1/swp2

cel-redxp-10# show run bgp
!
router bgp 100
 neighbor fabric peer-group
 neighbor fabric remote-as external
 neighbor fabric capability extended-nexthop
 neighbor swp1 interface peer-group fabric
 neighbor swp2 interface peer-group fabric
 neighbor 1.1.1.1 peer-group fabric
 !
 address-family ipv4 unicast
  no neighbor fabric activate
 exit-address-family
!
cel-redxp-10#
2017-07-07 19:09:22 +00:00
babeld *: fix excess docstring 2017-07-05 15:33:00 -04:00
bgpd bgpd: peer-group members 'activate' when they shouldn't 2017-07-07 19:09:22 +00:00
debian debian: python3-dev is now a build requirement for main package 2017-06-27 18:09:38 -07:00
doc doc: update build docs for ubuntu 2017-07-05 15:30:19 -04:00
eigrpd eigrpd: Fix zclient cleanup on shutdown 2017-06-30 10:30:34 -04:00
fpm *: make consistent & update GPLv2 file headers 2017-05-15 16:37:41 +02:00
gdb gdb: Add a directory of files with gdb macros 2016-05-26 15:33:30 +00:00
init build: delete .cvsignore files 2011-12-13 14:27:01 +04:00
isisd *: fix excess docstring 2017-07-05 15:33:00 -04:00
ldpd lib: more show thread cpu 2017-06-29 23:40:56 +00:00
lib Merge pull request #778 from qlyoung/fix-excess-docstring 2017-07-07 13:31:08 -04:00
m4 build: find & use threading library 2017-03-31 17:59:48 +02:00
nhrpd *: update hash_create(), hash_create_size() 2017-07-01 19:18:37 -04:00
ospf6d *: fix excess docstring 2017-07-05 15:33:00 -04:00
ospfclient lib: more show thread cpu 2017-06-29 23:40:56 +00:00
ospfd *: fix excess docstring 2017-07-05 15:33:00 -04:00
pimd *: fix excess docstring 2017-07-05 15:33:00 -04:00
pkgsrc eigrp: Initial Commit 2017-03-08 23:07:46 -05:00
ports pimd: merge pimd as of 2015-01-19 2016-05-25 20:38:32 -04:00
python *: rebase vty_outln() -> master 2017-06-29 17:38:59 +00:00
qpb *: make consistent & update GPLv2 file headers 2017-05-15 16:37:41 +02:00
redhat Merge remote-tracking branch 'origin/stable/2.0' 2017-06-28 19:10:20 -04:00
ripd *: fix excess docstring 2017-07-05 15:33:00 -04:00
ripngd ripngd: Fix zclient cleanup on shutdown 2017-06-30 10:32:01 -04:00
snapcraft snapcraft: fix minor typo 2017-05-15 12:28:56 -04:00
solaris Rename: freerangerouting --> frrouting 2017-03-30 14:24:05 -04:00
tests *: update hash_create(), hash_create_size() 2017-07-01 19:18:37 -04:00
tools Merge pull request #707 from donaldsharp/debian_babel 2017-06-19 21:58:36 -04:00
vtysh *: fix excess docstring 2017-07-05 15:33:00 -04:00
watchfrr *: use vty_outln 2017-06-29 17:31:28 +00:00
zebra Merge pull request #778 from qlyoung/fix-excess-docstring 2017-07-07 13:31:08 -04:00
.gitignore python: clidef.py 2017-06-14 19:29:26 +02:00
AUTHORS Initial revision 2002-12-13 20:15:29 +00:00
bootstrap.sh autoreconf -i 2007-02-06 19:28:28 +00:00
buildtest.sh buildtest.sh: Change name from quagga to frr 2017-01-20 00:36:29 +07:00
ChangeLog Rename: freerangerouting --> frrouting 2017-03-30 14:24:05 -04:00
common.am python: clidef.py 2017-06-14 19:29:26 +02:00
COMMUNITY.md *: make consistent & update GPLv2 file headers 2017-05-15 16:37:41 +02:00
configure.ac lib: add statistics for hash tables 2017-07-01 19:18:06 -04:00
COPYING *: make consistent & update GPLv2 file headers 2017-05-15 16:37:41 +02:00
COPYING-LGPLv2.1 build: remove LGPL v2.0, add LGPL v2.1 2016-11-15 17:19:38 +09:00
defaults.h *: make consistent & update GPLv2 file headers 2017-05-15 16:37:41 +02:00
Makefile.am python: clidef.py 2017-06-14 19:29:26 +02:00
NEWS release: 0.99.24 2016-06-03 15:56:44 -04:00
README README: add references to EIGRP and NHRP. 2017-05-12 22:51:45 +02:00
README.NetBSD build: remove $Format tags 2016-12-20 17:54:03 +01:00
render_md.py build: number sections in COMMUNITY.md HTML 2016-12-05 19:08:00 +01:00
REPORTING-BUGS Rename: freerangerouting --> frrouting 2017-03-30 14:24:05 -04:00
SERVICES babeld/eigrpd: flip VTY ports & fix rpm 2017-06-13 14:36:55 +02:00
stamp-h.in Initial revision 2002-12-13 20:15:29 +00:00
update-autotools * README.NetBSD: use update-autotools instead of autoreconf 2007-02-02 16:52:38 +00:00

FRRouting is free software that manages various IPv4 and IPv6 routing
protocols.

Currently FRRouting supports BGP4, BGP4+, OSPFv2, OSPFv3, RIPv1,
RIPv2, RIPng, PIM-SM/MSDP and LDP as well as very early support for IS-IS,
EIGRP and NHRP.

See the file REPORTING-BUGS to report bugs.

Free RRRouting is free software. See the file COPYING for copying conditions.

Public email discussion can be found at https://lists.frrouting.org/listinfo

Our public slack channel is at https://frrouting.slack.com