5254bb1550
In the CLI code, each cmd_token has both a "text" field, containing the full token text (e.g. "unicast"), and an "arg" field, containing the original text entered by the user (which might be an abbreviation, like "uni" instead of "unicast"). To avoid the need to handle abbreviations, the recommended pattern for DEFUN commands is to use the "text" value of fixed parameters and the "arg" value of everything else. Using DEFPY, however, the CLI parameters are automagically turned into C variables which are initialized under the hood (so that they're conveniently ready for use). The problem is that this initialization was always using the "arg" value of the parameters, which was leading to problems like these: debian# show ipv6 route isi Unknown route type debian# debian# conf t debian(config)# router isis 1 debian(config-router)# redistribute ipv4 st level-1 % Configuration failed. Invalid value "st" in "protocol" element. YANG path: /frr-isisd:isis/instance[area-tag='1']/redistribute/ipv4[protocol='st']/protocol To fix these problems (and probably others too), make DEFPY commands auto-detect the type of the input parameters and use either the "arg" or "text" value from the cmd_tokens accordingly. Signed-off-by: Renato Westphal <renato@opensourcerouting.org> |
||
|---|---|---|
| .github | ||
| alpine | ||
| babeld | ||
| bfdd | ||
| bgpd | ||
| debianpkg | ||
| doc | ||
| docker | ||
| eigrpd | ||
| fpm | ||
| gdb | ||
| include | ||
| isisd | ||
| ldpd | ||
| lib | ||
| m4 | ||
| nhrpd | ||
| ospf6d | ||
| ospfclient | ||
| ospfd | ||
| pbrd | ||
| pimd | ||
| pkgsrc | ||
| ports | ||
| python | ||
| qpb | ||
| redhat | ||
| ripd | ||
| ripngd | ||
| sharpd | ||
| snapcraft | ||
| solaris | ||
| staticd | ||
| tests | ||
| tools | ||
| vtysh | ||
| watchfrr | ||
| yang | ||
| zebra | ||
| .clang-format | ||
| .dir-locals.el | ||
| .dockerignore | ||
| .gitignore | ||
| bootstrap.sh | ||
| buildtest.sh | ||
| config.version.in | ||
| configure.ac | ||
| COPYING | ||
| COPYING-LGPLv2.1 | ||
| defaults.h | ||
| Makefile.am | ||
| README.md | ||
| stamp-h.in | ||
FRRouting
FRR is free software that implements and manages various IPv4 and IPv6 routing protocols. It runs on nearly all distributions of Linux and BSD as well as Solaris and supports all modern CPU architectures.
FRR currently supports the following protocols:
- BGP
- OSPFv2
- OSPFv3
- RIPv1
- RIPv2
- RIPng
- IS-IS
- PIM-SM/MSDP
- LDP
- BFD
- Babel
- EIGRP (alpha)
- NHRP (alpha)
Installation & Use
Packages are available for various distributions on our releases page.
Snaps are also available here.
Instructions on building and installing from source for supported platforms may be found here.
Once installed, please refer to the user guide for instructions on use.
Community
The FRRouting email list server is located here and offers the following public lists:
| Topic | List |
|---|---|
| Development | dev@lists.frrouting.org |
| Users & Operators | frog@lists.frrouting.org |
| Announcements | announce@lists.frrouting.org |
For chat, we currently use Slack. Please email the mailing list to request an invite as we do not issue automatic invites.
Contributing
FRR maintains developer's documentation which contains the project workflow and expectations for contributors. Some technical documentation on project internals is also available.
We welcome and appreciate all contributions, no matter how small!
Security
To report security issues, please use our security mailing list:
security [at] lists.frrouting.org