mirror_frr/tests/topotests/bgp_suppress_fib
Donald Sharp 3fdb2079f6 bgpd: Ensure suppress-fib-pending works with network statements
The flag for telling BGP that a route is expected to be installed
first before notifying a peer was always being set upon receipt
of a path that could be accepted as bestpath.  This is not correct:
imagine that you have a peer sending you a route and you have a
network statement that covers the same route.  Irrelevant if the
network statement would win the flag on the dest was being set
in bgp_update.  Thus you could get into a situation where
the network statement path wins but since the flag is set on
the node, it will never be announced to a peer.

Let's just move the setting of the flag into bgp_zebra_announce
and _withdraw.  In _announce set the flag to TRUE when suppress-fib
is enabled.  In _withdraw just always unset the flag as that a withdrawal
does not need to wait for rib removal before announcing.  This will
cover the case when a network statement is added after the route has
been learned from a peer.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-03-22 11:35:28 -04:00
..
r1 bgpd: Allow network XXX to work with bgp suppress-fib-pending 2022-10-12 14:56:27 -04:00
r2 bgpd: Allow network XXX to work with bgp suppress-fib-pending 2022-10-12 14:56:27 -04:00
r3 bgpd: Allow network XXX to work with bgp suppress-fib-pending 2022-10-12 14:56:27 -04:00
test_bgp_suppress_fib.py bgpd: Ensure suppress-fib-pending works with network statements 2023-03-22 11:35:28 -04:00