mirror_frr/pimd
Donald Sharp 85d25587bf eigrpd, ospfd, pimd: Fix assumption that interface may not be up
Commit: ddbf3e6060

This commit modified the interface up handling code in
ZAPI such that the zclient handled the decoding for you.
Prior to this commit ospf assumed that it could use the
old ifp pointer to know state before reading the stream.
This lead to a situation where ospf would `smartly` track
and do the right thing in this situation.  This commit
changed this assumption and in certain scenarios, say
a interface was changed after it was already up would
lead to situations where ospf would not properly handle
the new interface up.

Modify ospf to track data that is important to it in
it's interface->info pointer.

This code pattern was followed in both eigrp and pim.
In eigrp's case it was just behaving weirdly in any event
so fixing this pattern is not a big deal.  In pim's
case it was not properly using this so it's a no-op
to fix.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-12-04 14:23:20 -05:00
..
.gitignore *: cleanup .gitignore files 2018-09-08 21:30:42 +02:00
AUTHORS pimd: Remove unnecessary QuaggaId 2016-12-21 20:26:03 -05:00
CAVEATS pimd: added mtrace caveat 2018-02-27 14:03:39 +01:00
COMMANDS pimd: show ip igmp statistics command 2018-05-04 17:05:19 +02:00
COPYING pimd: merge pimd as of 2015-01-19 2016-05-25 20:38:32 -04:00
DEBUG pimd: Cleanup the headers. 2017-01-19 10:01:02 -05:00
LINUX_KERNEL_MROUTE_MFC pimd: Remove unnecessary QuaggaId 2016-12-21 20:26:03 -05:00
Makefile build: non-recursive pimd 2017-09-07 16:20:42 +02:00
mtracebis_netlink.c pimd ripd ripngd: variable shadowing fixes 2018-09-12 12:55:31 +02:00
mtracebis_netlink.h *: conform with COMMUNITY.md formatting rules, via 'make indent' 2018-03-06 14:04:32 -05:00
mtracebis_routeget.c *: fix config.h/zebra.h include order 2018-09-08 21:30:42 +02:00
mtracebis_routeget.h pimd: Multicast traceroute client and router 2018-02-19 23:13:55 +01:00
mtracebis.c pimd: Cleanup mtracebis.c header inclusion a tiny bit 2019-06-02 16:07:48 -04:00
pim_assert.c pimd: Slightly loosen pim assert message length tests 2019-09-10 10:53:15 -04:00
pim_assert.h *: reindent 2017-07-17 14:04:07 +02:00
pim_bfd.c bfdd: Handling local and remote admin-down 2019-10-28 21:38:20 -07:00
pim_bfd.h bgpd/ospfd: make bgp and ospf json response a bit more consistent 2018-08-30 12:40:18 +00:00
pim_br.c *: ALLOC calls cannot fail 2018-08-11 17:14:58 +02:00
pim_br.h *: reindent 2017-07-17 14:04:07 +02:00
pim_bsm.c pimd: fix bsm buflen check to include pim hdr 2019-11-19 21:54:02 -05:00
pim_bsm.h pimd: Forwarding the stored BSM to new neighbor or restarted neighbor 2019-05-14 21:42:22 -07:00
pim_cmd.c Merge pull request #5328 from satheeshkarra/pim_mlag 2019-11-22 08:51:47 -05:00
pim_cmd.h pimd : Add support for MLAG Register & Un-register 2019-11-13 19:46:52 -08:00
pim_errors.c pimd: PIM_[ERR|WARN] -> EC_PIM 2018-09-13 19:12:58 +00:00
pim_errors.h pimd: PIM_[ERR|WARN] -> EC_PIM 2018-09-13 19:12:58 +00:00
pim_hello.c *: strip trailing whitespace 2019-09-30 16:44:43 +00:00
pim_hello.h *: reindent 2017-07-17 14:04:07 +02:00
pim_iface.c eigrpd, ospfd, pimd: Fix assumption that interface may not be up 2019-12-04 14:23:20 -05:00
pim_iface.h *: Add infrastructure to support zapi interface callbacks 2019-09-19 13:34:06 -04:00
pim_ifchannel.c pimd: debug igmp trace turns on non igmp debugs 2019-11-12 09:38:04 -05:00
pim_ifchannel.h lib: hashing functions should take const arguments 2019-05-14 21:23:08 +00:00
pim_igmp_join.h pimd: Only need 1 return from a function 2018-08-02 10:09:09 -04:00
pim_igmp_mtrace.c pimd: pim_nexthop_lookup should return true/false 2019-04-02 08:20:36 -04:00
pim_igmp_mtrace.h pimd: adding querying of state to mtrace 2018-04-24 18:47:50 +02:00
pim_igmp_stats.c *: fix config.h/zebra.h include order 2018-09-08 21:30:42 +02:00
pim_igmp_stats.h pimd: show ip igmp statistics command 2018-05-04 17:05:19 +02:00
pim_igmp.c pimd: Cleanup igmp debugs a tiny bit 2019-11-12 09:38:04 -05:00
pim_igmp.h pimd: Added cli to generate igmp query. 2019-06-24 03:15:10 -07:00
pim_igmpv2.c pimd: show ip igmp statistics command 2018-05-04 17:05:19 +02:00
pim_igmpv2.h *: reindent 2017-07-17 14:04:07 +02:00
pim_igmpv3.c pimd: Cleanup igmp debugs a tiny bit 2019-11-12 09:38:04 -05:00
pim_igmpv3.h *: reindent 2017-07-17 14:04:07 +02:00
pim_instance.c pimd : Add support for MLAG Register & Un-register 2019-11-13 19:46:52 -08:00
pim_instance.h pimd : Add support for MLAG Register & Un-register 2019-11-13 19:46:52 -08:00
pim_int.c *: reindent 2017-07-17 14:04:07 +02:00
pim_int.h *: make consistent & update GPLv2 file headers 2017-05-15 16:37:41 +02:00
pim_join.c pimd: Various buffer overflow reads and crashes 2019-11-19 20:30:24 -05:00
pim_join.h *: reindent 2017-07-17 14:04:07 +02:00
pim_jp_agg.c pimd: debug igmp trace turns on non igmp debugs 2019-11-12 09:38:04 -05:00
pim_jp_agg.h *: reindent 2017-07-17 14:04:07 +02:00
pim_macro.c *: s/TRUE/true/, s/FALSE/false/ 2019-07-01 17:26:05 +00:00
pim_macro.h *: reindent 2017-07-17 14:04:07 +02:00
pim_main.c *: make frr_yang_module_info const 2019-11-30 00:38:32 +01:00
pim_memory.c pimd: BSM related memory definition to static and function reordering 2019-05-14 21:37:35 -07:00
pim_memory.h pimd: BSM related memory definition to static and function reordering 2019-05-14 21:37:35 -07:00
pim_mlag.c zebra,pim : Fixing Review comments in PIM_MLAG 2019-11-19 08:54:11 -08:00
pim_mlag.h pimd, lib: adding support for MLAG Message processing at PIM 2019-11-13 20:43:15 -08:00
pim_mroute.c *: generously apply const 2019-12-02 15:01:29 +01:00
pim_mroute.h pimd: Fix linux build on older kernels 2017-07-24 13:52:57 -04:00
pim_msdp_packet.c *: style for EC replacements 2018-09-13 19:38:57 +00:00
pim_msdp_packet.h pimd: Make msdp struct pim_instance * aware 2017-07-24 13:51:37 -04:00
pim_msdp_socket.c *: frr_elevate_privs -> frr_with_privs 2019-09-03 17:18:35 +02:00
pim_msdp_socket.h pimd: Make msdp struct pim_instance * aware 2017-07-24 13:51:37 -04:00
pim_msdp.c pimd: strcpy -> strlcpy 2019-05-29 18:03:26 +00:00
pim_msdp.h pimd: Remove pim_msdp_config_write as it was never used 2019-01-04 12:23:39 -05:00
pim_msg.c pimd: PIM Msg header includes N bit as defined by RFC 2019-05-14 21:40:50 -07:00
pim_msg.h pimd: handle endianness in pim header structure 2019-07-10 11:46:40 +08:00
pim_neighbor.c *: Convert prefix_free to double pointer 2019-11-02 16:13:44 -04:00
pim_neighbor.h *: reindent 2017-07-17 14:04:07 +02:00
pim_nht.c *: Fix spelling errors pointed out by debian packaging 2019-08-19 10:36:53 -04:00
pim_nht.h Merge pull request #4239 from sarav511/rp 2019-05-28 10:26:28 -05:00
pim_oil.c pimd: Add pim_channel_oil_change_iif 2019-07-18 07:54:04 -04:00
pim_oil.h pimd: Add pim_channel_oil_change_iif 2019-07-18 07:54:04 -04:00
pim_pim.c pimd: Fix possible read beyond end of data received 2019-11-19 08:22:50 -05:00
pim_pim.h *: reindent 2017-07-17 14:04:07 +02:00
pim_register.c pimd: debug igmp trace turns on non igmp debugs 2019-11-12 09:38:04 -05:00
pim_register.h pimd: extern pim_null_register_send 2019-04-20 08:33:22 -07:00
pim_routemap.c bgpd, lib, ospf6d, ospfd, pimd, zebra: Rework routemap event callback 2019-05-10 18:43:21 -04:00
pim_rp.c pimd: Various buffer overflow reads and crashes 2019-11-19 20:30:24 -05:00
pim_rp.h pimd: rp_new & rp_del split into 2 tier functions & implement rp_change 2019-05-14 21:35:45 -07:00
pim_rpf.c pimd: debug igmp trace turns on non igmp debugs 2019-11-12 09:38:04 -05:00
pim_rpf.h pimd: Remove unnecessary boolean to pim_rpf_update 2019-06-07 13:27:29 -04:00
pim_signals.c Treewide: use ANSI function definitions 2019-01-24 11:21:59 +01:00
pim_signals.h *: make consistent & update GPLv2 file headers 2017-05-15 16:37:41 +02:00
pim_sock.c pimd: Mark Default TOS Values for PIM & IGMP Outgoing packets 2019-09-23 23:03:12 -07:00
pim_sock.h pimd: pim_socket_join_source is only called from one place 2018-08-02 10:09:09 -04:00
pim_ssm.c *: remove null check before XFREE 2019-02-25 23:00:46 +00:00
pim_ssm.h pimd: Cleanup pim_ssm.c to use 'struct pim_instance *' 2017-07-24 13:51:36 -04:00
pim_ssmpingd.c pimd: Create a struct pim_router and move thread master into it 2019-01-04 12:21:00 -05:00
pim_ssmpingd.h pimd: Make pim_ssmpingd.c 'struct pim_instance' aware 2017-07-24 13:51:37 -04:00
pim_static.c pimd: Add pim_channel_oil_change_iif 2019-07-18 07:54:04 -04:00
pim_static.h pimd: Put 'struct pim_instance *' as the first function parameter 2017-07-24 13:51:41 -04:00
pim_str.c lib: move SG prefix2str APIs from pimd to lib 2019-04-20 08:33:20 -07:00
pim_str.h lib: move SG prefix2str APIs from pimd to lib 2019-04-20 08:33:20 -07:00
pim_time.c Treewide: use ANSI function definitions 2019-01-24 11:21:59 +01:00
pim_time.h *: make consistent & update GPLv2 file headers 2017-05-15 16:37:41 +02:00
pim_tlv.c pimd: Various buffer overflow reads and crashes 2019-11-19 20:30:24 -05:00
pim_tlv.h *: reindent 2017-07-17 14:04:07 +02:00
pim_upstream.c pimd: debug igmp trace turns on non igmp debugs 2019-11-12 09:38:04 -05:00
pim_upstream.h pimd: Always create upstream reference when adding channel oil 2019-07-18 07:56:37 -04:00
pim_util.c pimd: add support for boundaries 2017-09-26 13:00:52 -04:00
pim_util.h pimd: add support for boundaries 2017-09-26 13:00:52 -04:00
pim_version.c *: reindent 2017-07-17 14:04:07 +02:00
pim_version.h *: reindent 2017-07-17 14:04:07 +02:00
pim_vty.c pimd: sh config is showing detail debug, though not configured 2019-08-26 23:38:26 -07:00
pim_vty.h lib, pimd: Remove PIM_NODE as it is not needed 2018-01-30 03:21:42 -05:00
pim_vxlan_instance.h pimd: definition of pim-evpn origination and termination devices 2019-04-20 08:33:21 -07:00
pim_vxlan.c *: s/TRUE/true/, s/FALSE/false/ 2019-07-01 17:26:05 +00:00
pim_vxlan.h pimd: hidden command to set MLAG parameters 2019-04-20 08:33:23 -07:00
pim_zebra.c Merge pull request #5328 from satheeshkarra/pim_mlag 2019-11-22 08:51:47 -05:00
pim_zebra.h *: Convert from ->interface_up to the interface callback 2019-09-19 13:34:06 -04:00
pim_zlookup.c pimd: Allow zlookup socket to drain 2019-06-06 16:23:09 -04:00
pim_zlookup.h pimd, zebra: Encode nexthop vrf in message 2018-11-01 19:24:59 -04:00
pimd.c pimd: Free up zlookup structure late 2019-03-14 17:03:26 -04:00
pimd.conf.sample pimd: Remove unnecessary QuaggaId 2016-12-21 20:26:03 -05:00
pimd.h pimd : Add support for MLAG Register & Un-register 2019-11-13 19:46:52 -08:00
README pimd: Fix README file for FRR 2017-01-19 08:57:17 -05:00
subdir.am pimd : Add support for MLAG Register & Un-register 2019-11-13 19:46:52 -08:00
test_igmpv3_join.c pimd: Fix indentation issue that slipped in? 2017-08-30 07:39:01 -04:00
TODO pimd: Cleanup TODO file 2018-02-26 21:33:02 -05:00
TROUBLESHOOTING pimd: merge pimd as of 2015-01-19 2016-05-25 20:38:32 -04:00

INTRODUCTION

        qpimd aims to implement a PIM (Protocol Independent Multicast)
	daemon for the FRR Routing Suite.

	qpimd implements PIM-SM (Sparse Mode) of RFC 4601.
        Additionally MSDP has been implemented.

	In order to deliver end-to-end multicast routing control
	plane, qpimd includes the router-side of IGMPv[2|3] (RFC 3376).

LICENSE

        qpimd - pimd for FRR
        Copyright (C) 2008 Everton da Silva Marques

        qpimd is free software; you can redistribute it and/or modify
        it under the terms of the GNU General Public License as
        published by the Free Software Foundation; either version 2,
        or (at your option) any later version.

        qpimd is distributed in the hope that it will be useful, but
        WITHOUT ANY WARRANTY; without even the implied warranty of
        MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
        GNU General Public License for more details.

        You should have received a copy of the GNU General Public
        License along with qpimd; see the file COPYING.  If not, write
        to the Free Software Foundation, Inc., 59 Temple Place - Suite
        330, Boston, MA 02111-1307, USA.

HOME SITE

        qpimd lives at:

        https://github.com/freerangerouting/frr

PLATFORMS

	qpimd has been tested with Debian Jessie.

REQUIREMENTS

	qpimd requires FRR (2.0 or higher)


CONFIGURATION COMMANDS

	See available commands in the file pimd/COMMANDS.

KNOWN CAVEATS

	See list of known caveats in the file pimd/CAVEATS.

SUPPORT

	Please post comments, questions, patches, bug reports at the
	support site:

        https://freerangerouting/frr

RELATED WORK

	igmprt:	An IGMPv3-router implementation
	- http://www.loria.fr/~lahmadi/igmpv3-router.html

	USC pimd: PIMv2-SM daemon
	- http://netweb.usc.edu/pim/pimd (URL broken in 2008-12-23)
	- http://packages.debian.org/source/sid/pimd (from Debian)

	troglobit pimd: This is the original USC pimd from
	http://netweb.usc.edu/pim/. In January 16, 2010 it was revived
	with the intention to collect patches floating around in
	Debian, Gentoo, Lintrack and other distribution repositories
	and to provide a central point of collaboration.
	- http://github.com/troglobit/pimd

	zpimd: zpimd is not dependent of zebra or any other routing daemon
	- ftp://robur.slu.se/pub/Routing/Zebra
	- http://sunsite2.icm.edu.pl/pub/unix/routing/zpimd

	mrd6: an IPv6 Multicast Router for Linux systems
	- http://fivebits.net/proj/mrd6/

	MBGP: Implementation of RFC 2858 for Quagga
	- git://git.coplanar.net/~balajig/quagga
	- http://www.gossamer-threads.com/lists/quagga/dev/18000

REFERENCES

	IANA Protocol Independent Multicast (PIM) Parameters
	http://www.iana.org/assignments/pim-parameters/pim-parameters.txt

	Address Family Numbers
	http://www.iana.org/assignments/address-family-numbers

                              -- END --