mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-05-28 15:33:34 +00:00
4d474fa329
837d16c ("*: use array_size() helper macro") accidentally changed one of
the expressions in the backtrace code, which afterwards read:
zlog_backtrace_sigsafe():
if (((size = backtrace(array,array_size(array)) <= 0) ||
which boils down to: (size = backtrace(...) <= 0). The braces were
intended to go: (size = backtrace(...)) <= 0.
All in all, this makes a nice textbook example of the original author
being too clever (trying to save a single line by pulling the assignment
into the condition) and the next person touching the code tripping over
it...
This code occurs another time in zlog_backtrace() where it is actually
correct. Pulling out the assignment nonetheless. Also, new test
program.
Cc: Andrew J. Schorr <ajschorr@alumni.princeton.edu>
Cc: Balaji.G <balajig81@gmail.com>
Cc: Scott Feldman <sfeldma@cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
62 lines
1.6 KiB
C
62 lines
1.6 KiB
C
/*
|
|
* SEGV / backtrace handling test.
|
|
*
|
|
* copied from test-sig.c
|
|
*
|
|
* Copyright (C) 2013 by David Lamparter, Open Source Routing.
|
|
* Copyright (C) 2013 by Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* This file is part of Quagga
|
|
*
|
|
* Quagga is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2, or (at your option) any
|
|
* later version.
|
|
*
|
|
* Quagga is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Quagga; see the file COPYING. If not, write to the Free
|
|
* Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
|
|
* 02111-1307, USA.
|
|
*/
|
|
|
|
#include <zebra.h>
|
|
#include <sigevent.h>
|
|
#include "lib/log.h"
|
|
#include "lib/memory.h"
|
|
|
|
struct quagga_signal_t sigs[] =
|
|
{
|
|
};
|
|
|
|
struct thread_master *master;
|
|
|
|
int
|
|
threadfunc (struct thread *thread)
|
|
{
|
|
int *null = NULL;
|
|
*null += 1;
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
main (void)
|
|
{
|
|
master = thread_master_create ();
|
|
signal_init (master, array_size(sigs), sigs);
|
|
|
|
zlog_default = openzlog("testsegv", ZLOG_NONE,
|
|
LOG_CONS|LOG_NDELAY|LOG_PID, LOG_DAEMON);
|
|
zlog_set_level (NULL, ZLOG_DEST_SYSLOG, ZLOG_DISABLED);
|
|
zlog_set_level (NULL, ZLOG_DEST_STDOUT, LOG_DEBUG);
|
|
zlog_set_level (NULL, ZLOG_DEST_MONITOR, ZLOG_DISABLED);
|
|
|
|
thread_execute (master, threadfunc, 0, 0);
|
|
|
|
exit (0);
|
|
}
|