proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-11-04 04:50:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,864 Commits 4 Branches 191 Tags 114 MiB
f7b2e630e4
Commit Graph

11864 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
paco
cab3b126ca
bgpd: dead code removal (Coverity 1399389) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 18:17:56 +02:00
Donald Sharp
9c96d82fd2
Merge pull request #2424 from pacovn/Coverity_1399270_Dereference_after_null_check 
bgpd: null check (Coverity 1399270)
 2018-06-13 12:13:57 -04:00
paco
657f9948ed
tools: return check (Coverity 1143220) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 18:07:36 +02:00
paco
cc32742c09
bgpd: null check (Coverity 1399270) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 17:15:21 +02:00
paco
9eaec2ae4b
lib: out-of-bounds access (Coverity 1457145) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 17:08:38 +02:00
Donald Sharp
558c7c80bf
Merge pull request #2421 from pacovn/Coverity_1399232_Logically_dead_code 
ospfd: dead code (Coverity 1399232)
 2018-06-13 10:45:48 -04:00
paco
e1be9119f8
tools: out-of-bounds access (Coverity 1399290) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 16:33:51 +02:00
paco
a37befa70b
ospfd: dereference check (Clang scan-build) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 15:49:36 +02:00
Donald Sharp
03f290185b zebra: Cleanup code to test for failure once 
Cleanup the zebra code to test for failure for reading
from stream once instead of once to see if we should
debug and once for the actual failure.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-13 09:19:37 -04:00
paco
92692be16a
ospfd: dead code (Coverity 1399232) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 14:30:06 +02:00
Donald Sharp
b65928513f
Merge pull request #2420 from pacovn/Coverity_1399246_Logically_dead_code 
bgpd: dead code (Coverity 1399246)
 2018-06-13 08:08:45 -04:00
paco
d6ceaca343
bgpd: dead code (Coverity 1399246) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 12:25:45 +02:00
Rafael Zalamena
4872687a28
Merge pull request #2414 from donaldsharp/bsd_failure 
zebra: Fix compilation of bsd
 2018-06-12 17:51:03 -03:00
Quentin Young
24a21176ce pbrd: use PBR_STR 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-12 20:28:04 +00:00
Quentin Young
2e7c93acec doc: document pbr table range & a couple others 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-12 20:27:38 +00:00
Quentin Young
ef18ed6e93 pbrd: remove json options 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-12 20:27:30 +00:00
Quentin Young
1cbf0616b8
Merge pull request #2412 from opensourcerouting/lintian-warn-fix 
debianpkg: Add additional lintian override for Ubuntu 18.04
 2018-06-12 16:22:38 -04:00
Rafael Zalamena
d4d1a5b884
Merge pull request #2407 from donaldsharp/bgp_spelunk 
Bgp crash fix for topotests
 2018-06-12 17:11:15 -03:00
Rafael Zalamena
5f7c2b0918
Merge pull request #2411 from qlyoung/fix-vtysh-config-write 
vtysh: fix config write
 2018-06-12 16:59:35 -03:00
Quentin Young
7bec514c7e pbrd: allow configurable table id range 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-12 19:51:12 +00:00
Donald Sharp
f47598b0f0 zebra: Fix compilation of bsd 
Actually return a value.

Fixes: #2413
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-12 15:50:39 -04:00
Donald Sharp
bf383464ea bgpd: Ensure that bgp_delete bgp pointer is non-null 
Crash w/ an assert if someone calls bgp_delete with a
NULL parameter as opposed to crashing when we dereference
the pointer a bit later.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-12 15:12:48 -04:00
Donald Sharp
1f4b2cce95 bgpd: bgp_default may be null 
The bgp_default variable when saved to the side might actually
be NULL.

Ticket: CM-21119
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-12 15:12:48 -04:00
Donald Sharp
0e42e319d5 bgpd: Fix crash when shutdown 
The process of BGP shutdown hard free's memory irrelevant to
the fact that another process may be using that memory still
in route leaking scenario's.

As a temporary fix find the default instance and free it
last.

Ticket: CM-21068
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-12 15:12:48 -04:00
Donald Sharp
c93a3b77e6 bgpd: Move extra free code and fix a bug. 
The bgp_info_extra_free code was the correct place to free
up data associated with the bgp_info pointer when we are
deleting the bgp_info node.

Additionally, if we have a parent pointer, we may not have a net
pointer.  So make sure we do.

Finally clean up the bgp_info_extra_free code so it is a bit
easier to read.  Use variables instead of multiple level
of casting.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-12 15:12:48 -04:00
Martin Winter
310ac9398e debianpkg: Add additional lintian override for Ubuntu 18.04 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-06-12 12:06:00 -07:00
Quentin Young
b7ae6ac4db vtysh: fix config write 
Changing vtysh to use vty_out() for everything broke writing to config
files.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-12 18:14:52 +00:00
paco
f0ed6beaf2
lib: OoB access (Coverity 1448806, 1448810) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-12 19:26:13 +02:00
Lou Berger
f205fcdbb2 vtysh: in user mode, don't show 'enable not allowed', also block writeconfig 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-06-12 12:33:25 -04:00
Jafar Al-Gharaibeh
e789c0337c
Merge pull request #2402 from qlyoung/germx-hand-sanitizer-kills-99-percent-of-germs 
*: disable all sanitizers for clippy build
 2018-06-12 11:11:55 -05:00
Jafar Al-Gharaibeh
ef3428731e
Merge pull request #2379 from qlyoung/docuser 
Improve introductory user docs
 2018-06-12 11:04:26 -05:00
Jafar Al-Gharaibeh
e6731bccbe
Merge pull request #2384 from qlyoung/docs-bgp-update 
doc: massive cleanup of bgp.rst
 2018-06-12 10:57:36 -05:00
Lou Berger
9efdc68724
Merge pull request #2392 from chiragshah6/evpn_dev 
bgpd: accept vni rd_rt command for default vrf only
 2018-06-12 11:50:43 -04:00
Donald Sharp
81030cc3f7
Merge pull request #2399 from pacovn/Coverity_1469894_Dereference_null_return_value 
lib: null return value check (Coverity 1469894)
 2018-06-12 11:50:18 -04:00
Arthur Jones
15ecc92750 tests: use BUILT_SOURCES in tests/Makefile.am for automake 1.16.1 
When trying to run make check using automake 1.16.1, we get:

CC isisd/test_fuzz_isis_tlv-test_fuzz_isis_tlv.o
isisd/test_fuzz_isis_tlv.c:1:10: fatal error: test_fuzz_isis_tlv_tests.h: No such file or directory
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Makefile:1096: recipe for target 'isisd/test_fuzz_isis_tlv-test_fuzz_isis_tlv.o' failed
make[1]: *** [isisd/test_fuzz_isis_tlv-test_fuzz_isis_tlv.o] Error 1
make[1]: Leaving directory '/src/frr-frr-5.0/tests'
Makefile:1220: recipe for target 'check-am' failed
make: *** [check-am] Error 2

From reading the automake docs, it looks like there may be a more
reliable way to express built files in the Makefile.am using BUILT_SOURCES.
Using this method, we seem to build fine now on 1.16.1 and this
has been tested on Ubuntu 18.04, CentOS 7 and Alpine edge (which uses
automake 1.16.1).

Issue: https://github.com/FRRouting/frr/issues/2403
Signed-off-by: Arthur Jones <arthur.jones@riverbed.com>
 2018-06-12 08:05:00 -07:00
Donald Sharp
2a4269ccd8
Merge pull request #2404 from pacovn/Coverity_1455338_Dereference_null_return_value 
eigrpd: null return value check (Coverity 1455338)
 2018-06-12 10:47:48 -04:00
Rafael Zalamena
b4ba87ebb3
Merge pull request #2406 from pacovn/Coverity_1465495_Out-of-bounds_read 
zebra: Out-of-bounds read (Coverity 1465495)
 2018-06-12 11:45:11 -03:00
paco
9f227e4c91
lib: null return value check (Coverity 1469894) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-12 16:37:36 +02:00
Donald Sharp
efb02f8814
Merge pull request #2405 from pacovn/Coverity_1399236_Logically_dead_code 
ospfd: logically dead code (Coverity 1399236)
 2018-06-12 09:59:37 -04:00
paco
939a62a54d
eigrpd: null return value check (Coverity 1455338) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-12 15:39:30 +02:00
paco
aa360de7a3
zebra: Out-of-bounds read (Coverity 1465495) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-12 15:27:44 +02:00
paco
b42664f473
ospfd: logically dead code (Coverity 1399236) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-12 14:41:19 +02:00
Quentin Young
63162a1203
Merge pull request #2397 from pacovn/Coverity_1469896_Dereference_after_null_check 
vtysh: null dereference (Coverity 1469896)
 2018-06-11 16:30:49 -04:00
Quentin Young
01491ab251
Merge pull request #2398 from pacovn/Coverity_1469895_Dereference_after_null_check 
lib: null dereference (Coverity 1469895)
 2018-06-11 16:27:42 -04:00
Quentin Young
57f949f4e8
Merge pull request #2396 from pacovn/Coverity_1469897_1469893_Out-of-bounds_access 
bgpd: OoB access (Coverity 1469897, 1469893)
 2018-06-11 15:48:10 -04:00
paco
8224c6cf9b
lib: null dereference (Coverity 1469895) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-11 20:02:58 +02:00
paco
a0c14c5400
vtysh: null dereference (Coverity 1469896) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-11 19:42:03 +02:00
paco
11f9b4505c
bgpd: OoB access (Coverity 1469897, 1469893) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-11 19:07:13 +02:00
Chirag Shah
a2a8153f4e bgpd: accept vni rd_rt command for default vrf 
L2VNI route-distinguisher and route-target configuartions
should only applied under DEFAULT VRF bgpd instance.

Add newline to each vni display.

router bgp 65006
  address-family l2vpn evpn
    vni 1000101
      route-target import 1:1000101

do not allow under
router bgp 65006 vrf RED

Ticket:CM-20204
Reviewed By:
Testing Done:

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2018-06-09 17:35:37 -07:00
Donald Sharp
7af380695a
Merge pull request #2390 from pacovn/Coverity_1221459_Use_after_free 
spf6d: fix use after free (Coverity 1221459)
 2018-06-08 14:57:02 -04:00