proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-12 07:48:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
18,250 Commits 4 Branches 191 Tags 125 MiB
f20b3184b8
Commit Graph

18250 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Stephen Worley
ce0e698017 linux: Update our netlink headers for nexthop group support 
The linux kernel is adding support for nexthop groups. Update our
includes to reflect new types and structs we should be listening
for from the kernel.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
 2019-10-25 11:13:35 -04:00
Donald Sharp
22bcedb231 zebra: Add code to create/remove nexthop groups 
Add some code to create/remove nexthop groups.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
 2019-10-25 11:13:35 -04:00
Donald Sharp
4e49c8b8a7 zebra: Add ability to find(create) and release a nhg from a re 
Add some code to allow us to do lookups and releases of
nexthop groups from zebra.  At this point we do not do anything
with it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-25 11:13:35 -04:00
Donald Sharp
c8ee3cdb39 zebra: Add some basic flags to the zebra nexthop group 
We need to track if a nexthop group is valid and installed,
so create some basic flags to track this.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-25 11:13:35 -04:00
Donald Sharp
21be136402 zebra: Add show command to dump nexthop-group information for Zebra 
Just a simple addition of a command to dump the nexthop group information.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-25 11:13:35 -04:00
Donald Sharp
69171da262 zebra: Add hash of nexthop groups 
This commit does nothing more than just create a hash structure
that we will use to track nexthop groups.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-25 11:13:35 -04:00
Donald Sharp
253283d742 pimd: result was already tested against PIM_GROUP_BAD_ADDR_MASK_COMBO 
The result variable was already tested against PIM_GROUP_BAD_ADDR_MASK_COMBO
earlier in the function.  No need to do the same thing twice.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-25 07:07:49 -04:00
Donald Sharp
4d19a911c5 pimd: All paths have already derefed pim->global_scope.bsrp_table 
All paths leading to this point in the code have already deref'ed
the pim->global_scope.bsrp_table.  No point in testing for
validness now.  This was caught by Coverity.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-25 07:05:11 -04:00
Donald Sharp
adc62ec8b7 lib: va_copy must have a va_end to free memory 
All va_copy() calls must have a va_end() call.
Caught by Coverity

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-25 07:01:59 -04:00
Donatas Abraitis
b550350618 nhrp: Make sure no ip nhrp map <something> works as expected 
We passed peer as NULL and nothing happened.

exit2-debian-9# conf
exit2-debian-9(config)# int gre1
exit2-debian-9(config-if)# ip nhrp map 1.1.1.1 local
exit2-debian-9(config-if)# ip nhrp map 2.2.2.2 3.3.3.3
exit2-debian-9(config-if)# do sh run
...
!
interface gre1
 ip nhrp map 1.1.1.1 local
 ip nhrp map 2.2.2.2 3.3.3.3
!
...
exit2-debian-9(config-if)# no ip nhrp map 1.1.1.1
exit2-debian-9(config-if)# do sh run
...
!
interface gre1
 ip nhrp map 2.2.2.2 3.3.3.3
!

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2019-10-25 13:05:49 +03:00
Donatas Abraitis
e1a3c0effa
Merge pull request #5213 from mjstapp/fix_sysctl_h 
lib: Remove include of deprecated sysctl.h
 2019-10-25 08:40:28 +03:00
Donald Sharp
7647930dc7
Merge pull request #5200 from ton31337/feature/doc_access-list_sequence_numbers 
doc: Update documentation for access-list with sequence numbers
 2019-10-24 21:24:56 -04:00
Donald Sharp
49085521fa zebra: Prevent possible uninited value 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-24 20:15:56 -04:00
Donald Sharp
29f7fc8788 pimd: Cast up to 64 bit to prevent overflow 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-24 20:00:01 -04:00
Donald Sharp
35a3030297 pimd: Initialize nht_p variable 
nht_p.family and .prefixlen have code paths where we may not
initialize.  Fix.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-24 19:35:46 -04:00
Donald Sharp
3bb29c4e9b pimd: Check return code of pim_msg_send() 
The pim_msg_send() return code was not being checked.  Make
consistent with it's usage everywhere else.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-24 19:31:27 -04:00
Donald Sharp
68a4422da4 lib: vrf lookup may be NULL 
The vrf lookup may be NULL, so let's protect against this.
Found in coverity

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-24 18:44:48 -04:00
Donatas Abraitis
9ebe7ac966
Merge pull request #5220 from dslicenc/remove-afi-safi-msg 
bgpd: remove error message for unkown afi/safi combination
 2019-10-24 18:19:13 +03:00
Donatas Abraitis
3f8aebe012
Merge pull request #5219 from pguibert6WIND/interface_same_name 
staticd: check tuple (vrf, name) when interface events received
 2019-10-24 17:01:56 +03:00
Don Slice
8e5509b04b bgpd: remove error message for unkown afi/safi combination 
Problem reported with error messages appearing in the log
complaining about invalid afi/safi combinations.  Determined
that the error messages were recently added in the function
that turns afi and safi values to strings.  Unfortunately,
the function is called from places using FOREACH_AFI_SAFI,
which spins thru every afi and safi number including some
that are not legal together (ipv4 evpn and l2vpn multicast
for example.)   This fix removes these error messages since
it is not necessarily an error to call it with invalid
combinations.

Ticket: CM-26883
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
 2019-10-24 11:29:40 +00:00
Renato Westphal
f935dca78f
Merge pull request #5203 from qlyoung/fix-vrrp-error-alternations 
vrrpd: fix startup error message reporting
 2019-10-23 21:16:04 -03:00
Renato Westphal
9951e1c711
Merge pull request #5217 from mjstapp/fix_bgp_evpn_pi 
bgpd: clarify evpn datastruct use for SA
 2019-10-23 21:02:00 -03:00
Renato Westphal
5d98d948d2
Merge pull request #5214 from donaldsharp/vrrp_doc 
doc: Update supported platforms matrix w/ vrrpd
 2019-10-23 21:00:25 -03:00
Renato Westphal
a783c421f9
Merge pull request #5202 from Orange-OpenSource/isis-TE 
isisd: Correct missing advertisement of TE parameters
 2019-10-23 20:59:29 -03:00
Philippe Guibert
9eb8b14c85 staticd: check tuple (vrf, name) when interface events received 
with network namespace vrf backend, there is possibilities that the same
interface name can be used across two different vrfs. Then, enforce the
check when static daemon receives interface events. Adding to the
interface name, check for the vrf id, too.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2019-10-23 18:50:56 +02:00
Mark Stapp
bd0254af6c bgpd: clarify evpn datastruct use for SA 
Clear up an SA report by clarifying a function call in the evpn
code.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-10-23 11:56:35 -04:00
Donatas Abraitis
a0903cd24c bgpd: Override peer's TTL only if peer-group is configured with TTL 
When a peer-group is configured for an already configured eBGP neighbor,
ebgp-multihop command is removed for that peer.

This fix remains configured peer's ebgp-multihop value if peer-group does
not have ebgp-multihop configured.

!
router bgp 100
 neighbor A8 peer-group
 neighbor A9 peer-group
 neighbor A9 ebgp-multihop 12
 neighbor 3.3.3.3 remote-as 123
 neighbor 3.3.3.3 ebgp-multihop 255
 neighbor 4.4.4.4 remote-as 123
 !

spine1-debian-9#
spine1-debian-9# conf
spine1-debian-9(config)# router bgp 100
spine1-debian-9(config-router)# neighbor 3.3.3.3 peer-group A8
spine1-debian-9(config-router)# do sh run

!
router bgp 100
 neighbor A8 peer-group
 neighbor A9 peer-group
 neighbor A9 ebgp-multihop 12
 neighbor 3.3.3.3 remote-as 123
 neighbor 3.3.3.3 peer-group A8
 neighbor 3.3.3.3 ebgp-multihop 255
 neighbor 4.4.4.4 remote-as 123
!

spine1-debian-9(config-router)# neighbor 4.4.4.4 peer-group A9
spine1-debian-9(config-router)# do sh run

!
router bgp 100
 neighbor A8 peer-group
 neighbor A9 peer-group
 neighbor A9 ebgp-multihop 12
 neighbor 3.3.3.3 remote-as 123
 neighbor 3.3.3.3 peer-group A8
 neighbor 3.3.3.3 ebgp-multihop 255
 neighbor 4.4.4.4 remote-as 123
 neighbor 4.4.4.4 peer-group A9
!

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2019-10-23 18:04:14 +03:00
Donald Sharp
36d687f6fa doc: Update supported platforms matrix w/ vrrpd 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-23 09:11:45 -04:00
Mark Stapp
15e84e5abb lib: Remove include of deprecated sysctl.h 
Stop including deprecated header file; appears to be unused and
it has been deprecated in recent linux.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-10-23 09:08:21 -04:00
Quentin Young
3e6fd94f83
Merge pull request #5204 from ghasemnaddaf/vrrp_updates 
doc: vrrp vip must not be on parent interface
 2019-10-22 11:27:29 -04:00
Donatas Abraitis
4b0d7efeea
Merge pull request #5193 from qlyoung/doc-release-fixes 
Document release procedure
 2019-10-22 09:57:12 +03:00
Ghasem Naddaf
9965000665 doc: vrrp vip must not be on parent interface 
Signed-off-by: Ghasem Naddaf <ghasem.naddaf@gmail.com>
 2019-10-21 14:58:16 -07:00
Quentin Young
00c3cf9c2a vrrpd: fix startup error message reporting 
Due to some extremely shoddy programming on my part, the error messages
for certain errors was pretty much always wrong. We would start with the
correct error message, then on the next check, regardless of whether it
passed or failed, we would null out the error message, then on the next
one set it again (to the wrong message), then null it, and just keep
alternating. So errors were sometimes not being reported, sometimes
being reported correctly (if the condition parity happened to match the
appropriate condition), and sometimes being reported correctly.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-10-21 19:04:30 +00:00
Olivier Dugeon
9f62f0435e isisd: Correct missing advertisement of TE param. 
Traffic Engineering parameters are correctly advertised in LSP when
'mpls-te on' CLI command is present in the startup config file.

However, if IS-IS is started without TE enable at startup and
'mpls-te on' command is issued after, TE link parameters are never
announced. The patch correct this issue.

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
 2019-10-21 18:44:20 +02:00
Quentin Young
972d752122 doc: strip ws, shell -> console 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-10-21 16:11:09 +00:00
Donatas Abraitis
fc830a812b doc: Update documentation for access-list with sequence numbers 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2019-10-21 18:04:39 +03:00
Kuldeep Kashyap
4a252f7205 tests: Enhance BGP Path attribute test cases 
1. Added steps to modify BGP path attributes and verify
best path is changed

Signed-off-by: Kuldeep Kashyap <kashyapkas@gmail.com>
 2019-10-21 09:48:20 +05:30
Kuldeep Kashyap
c7bb8a05ff tests: Enhance BGP Path attribute APIs 
Modified affacted APIs to supported BGP Path attributes modification
and verification

Signed-off-by: Kuldeep Kashyap <kuldeepkas@gmail.com>
 2019-10-21 09:47:00 +05:30
Donatas Abraitis
acf061a9ab
Merge pull request #5108 from donaldsharp/sendbuffer_size_bgp 
Sendbuffer size bgp
 2019-10-20 12:09:42 +03:00
Mark Stapp
0a764122e1
Merge pull request #5184 from sworleys/Kernel-Route-Update 
zebra: Rib Update Event Scheduler For Un-managed Routes, etc.
 2019-10-19 12:01:47 -04:00
Russ White
12bea6d575
Merge pull request #4850 from lkrishnamoor/show_cli 
bgpd: Adding new bgp evpn cli's for ip-prefix lookup
 2019-10-18 21:30:37 -04:00
Stephen Worley
2a18114787 zebra: On if down/addr-del, process kernel routes 
Since we don't have a daemon who's job is to handle kernel
routes and we don't get an explicit route delete anymore if
nexthops become unreachable from the kernel, zebra must
re-process kernel routes itself to make sure they are still valid.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
 2019-10-18 16:59:34 -04:00
Stephen Worley
a8c427ee39 zebra: Check active on OLD system/kernel routes 
We can assume that system/kernel routes are valid indeed
if this is our first time procesing them. But since we don't
get explicit deletion events for kernel routes anymore, we
have to be prepared to process them if the nexthop becomes
unreachable for instance. Therefore, if the route is not NEW,
then don't assume its valid.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
 2019-10-18 16:59:34 -04:00
Stephen Worley
2a99ab95e6 zebra: Handle rib updates as a thread event 
If we need to batch process the rib (all tables or specific
vrf), do so as a scheduled thread event rather than immediately
handling it. Further, add context to the events so that you
narrow down to certain route types you want to reprocess.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
 2019-10-18 16:59:25 -04:00
Quentin Young
f4bcc72f99 doc: update release procedure docs 
Add a lot of detail and update some outdated stuff.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-10-18 18:50:10 +00:00
Quentin Young
b41f3f0a21 doc: fix messed up topotests docs 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-10-18 18:50:10 +00:00
Quentin Young
757c868b4b
Merge pull request #5180 from mjstapp/fix_nhrp_sa 
nhrpd: clean up SA warning
 2019-10-18 13:16:02 -04:00
Donald Sharp
4dcc227611 zebra: Dissallow a /32 or /128 through itself 
Do not allow an upper level protocol to send a route to
zebra that is a /32 or a /128 that recurses through itself.

Current behavior:
donna.cumulusnetworks.com# show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

K>* 0.0.0.0/0 [0/104] via 10.0.2.2, enp0s3, 01:05:28
C>* 10.0.2.0/24 is directly connected, enp0s3, 00:01:50
C>* 192.168.209.0/24 is directly connected, enp0s8, 01:05:28
C>* 192.168.210.0/24 is directly connected, enp0s9, 01:05:28
D>* 192.168.210.43/32 [150/0] via 192.168.210.44, enp0s9, 01:01:57
D   192.168.210.44/32 [150/0] via 192.168.210.44 inactive, 01:05:15
C>* 192.168.212.0/24 is directly connected, enp0s10, 01:05:28
donna.cumulusnetworks.com# sharp install routes 40.0.0.1 nexthop 192.168.210.44
% Command incomplete: sharp install routes 40.0.0.1 nexthop 192.168.210.44
donna.cumulusnetworks.com# sharp install routes 40.0.0.1 nexthop 192.168.210.44 1
donna.cumulusnetworks.com# end
donna.cumulusnetworks.com# show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

K>* 0.0.0.0/0 [0/104] via 10.0.2.2, enp0s3, 01:05:51
C>* 10.0.2.0/24 is directly connected, enp0s3, 00:00:12
D>* 40.0.0.1/32 [150/0] via 192.168.210.44, enp0s9, 00:00:03
C>* 192.168.209.0/24 is directly connected, enp0s8, 01:05:51
C>* 192.168.210.0/24 is directly connected, enp0s9, 01:05:51
D>* 192.168.210.43/32 [150/0] via 192.168.210.44, enp0s9, 01:02:20
D   192.168.210.44/32 [150/0] via 192.168.210.44 inactive, 01:05:38
C>* 192.168.212.0/24 is directly connected, enp0s10, 01:05:51
donna.cumulusnetworks.com#

Fixed behavior:

donna.cumulusnetworks.com# sharp install routes 192.168.210.44 nexthop 192.168.210.44 1
donna.cumulusnetworks.com# show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

K>* 0.0.0.0/0 [0/104] via 10.0.2.2, enp0s3, 00:00:15
C>* 10.0.2.0/24 is directly connected, enp0s3, 00:00:15
C>* 192.168.209.0/24 is directly connected, enp0s8, 00:00:15
C>* 192.168.210.0/24 is directly connected, enp0s9, 00:00:15
D   192.168.210.44/32 [150/0] via 192.168.210.44 inactive, 00:00:03
C>* 192.168.212.0/24 is directly connected, enp0s10, 00:00:15
donna.cumulusnetworks.com# sharp install routes 40.0.0.1 nexthop 192.168.210.44 1
donna.cumulusnetworks.com# show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

K>* 0.0.0.0/0 [0/104] via 10.0.2.2, enp0s3, 00:00:24
C>* 10.0.2.0/24 is directly connected, enp0s3, 00:00:24
D>* 40.0.0.1/32 [150/0] via 192.168.210.44, enp0s9, 00:00:02
C>* 192.168.209.0/24 is directly connected, enp0s8, 00:00:24
C>* 192.168.210.0/24 is directly connected, enp0s9, 00:00:24
D   192.168.210.44/32 [150/0] via 192.168.210.44 inactive, 00:00:12
C>* 192.168.212.0/24 is directly connected, enp0s10, 00:00:24
donna.cumulusnetworks.com#

This behavior came up from discussion around issue #5159.  Where
OSPF was receiving a route through itself as part of the router link
lsa.  I currently think that ospf should probably dissallow this in ospf
but we should also do the right thing in zebra.  If we do not allow this
change we can have situations where ordering of routes into zebra suddenly
matters.

Fixes: #5159
Signed-off-by: Donald Sharp <sharpd@cumulsunetworks.com>
 2019-10-18 10:37:28 -04:00
Renato Westphal
dfd7b62ddd
Merge pull request #5172 from donaldsharp/sa_clean_and_clean 
Sa clean and clean
 2019-10-17 23:14:31 -03:00
Renato Westphal
ca83094d26
Merge pull request #5182 from qlyoung/fix-doc-index-read-quanta 
doc: fix read-quanta .. index copy-paste err
 2019-10-17 23:11:05 -03:00