Renato Westphal
c125d1d41e
babeld/nhrpd: ignore ipv6 srcdest routes
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-23 17:45:17 -03:00
Renato Westphal
34b054ba6d
*: remove leftovers from "router zebra"
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-23 17:45:17 -03:00
Renato Westphal
89a8b5cada
vnc/eigrpd/isisd: check for the correct message types
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-23 17:45:17 -03:00
Renato Westphal
153856bbe9
lib: remove redundant zebra messages
...
This also fixes a bug of ipv6 routes advertised by the VNC code being
ignored by zebra.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-23 17:45:17 -03:00
Renato Westphal
d00061ea32
*: reduce excessive indentation in a few places
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-23 17:45:17 -03:00
Quentin Young
e1b9b080b8
Merge pull request #1030 from opensourcerouting/bgpd-fd-leak
...
bgpd: fix file descriptor leak
2017-08-23 15:45:53 -04:00
David Lamparter
9d1c265929
zebra: don't print 0.0.0.0:0 for FPM config
...
Fixes : #319
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-23 20:17:45 +02:00
Renato Westphal
5ecf554009
bgpd: fix file descriptor leak
...
Bug introduced by commit 37d361e7
. Removing the call to bgp_close()
from bgp_delete() was a mistake.
Reported-by: Don Slice <dslice@cumulusnetworks.com>
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-22 20:09:26 -03:00
Donald Sharp
c25445c820
Merge pull request #1028 from opensourcerouting/mpls_label_stack
...
zebra: increase maximum label stack depth
2017-08-22 18:25:23 -04:00
Renato Westphal
5e8c8947e3
zebra: increase maximum label stack depth
...
* Bump MPLS_MAX_LABELS from 2 to 16;
* Adjust the static_nh_label structure and the mpls_label2str() function;
* On OpenBSD, print an error message when trying to push more than one
label at once (kernel limitation). While here, add support for MPLSv6
FTNs in OpenBSD.
This is not the full package. We still can't pop multiple labels at once,
or do things like swap a label and push other ones. We'll address that
in the future.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-22 17:37:58 -03:00
Quentin Young
d23d6de866
ospf6d: add no
forms for interface commands
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-22 16:07:30 -04:00
Daniel Walton
e889891d8b
bgpd: 'show ip bgp regex' needs to be VRF aware
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-08-22 19:33:22 +00:00
Daniel Walton
7b2ff25031
bgpd: remove json option from 'sh ip bgp' commands that do not support it
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-08-22 19:11:31 +00:00
Daniel Walton
318cac96ef
bgpd: Memory wasting in zebra by non used MPLS FECs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-08-22 18:14:50 +00:00
David Lamparter
feda3ca36c
*: update git-reindent-branch.py
...
- autodetect whether it's on master or stable/3.0
- grab .clang-format from master
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-22 18:51:31 +02:00
David Lamparter
1d84515ca9
Merge pull request #1025 from qlyoung/no-ospf
...
ospfd, ospf6d: cleanup some `no` commands
2017-08-22 17:55:01 +02:00
Donald Sharp
569ab7a544
Merge pull request #1023 from opensourcerouting/route-node-const
...
lib: fix const-check in route_node
2017-08-22 11:44:45 -04:00
Quentin Young
da010bd011
Merge pull request #1024 from opensourcerouting/minor_fixes
...
Minor fixes
2017-08-22 11:21:02 -04:00
Quentin Young
3257307337
ospfd, ospf6d: cleanup some no
commands
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-22 10:55:12 -04:00
Renato Westphal
a5fdb4c510
isisd: return proper error codes in some commands
...
CMD_ERR_AMBIGUOUS should only be used internally by the CLI.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-22 11:18:10 -03:00
Renato Westphal
f0c4b8e1c8
zebra: redistribute srcdest routes to the client daemons
...
Somehow we missed these bits from the original srcdest patchset.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-22 10:57:55 -03:00
Renato Westphal
b81ef7b30a
zebra: fix display of static routes pointing to nonexistent interfaces
...
Bug introduced a couple of weeks ago by myself. Only happens when the
route has an IP nexthop + a nexthop interface.
Example:
debian(config)# ip route 10.0.1.0/24 172.16.1.10 fake1
debian(config)# do sh run
Building configuration...
[snip]
!
ip route 10.0.1.0/24 172.16.1.10 unknown
!
end
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-22 10:52:07 -03:00
David Lamparter
acf3a851b9
lib: fix const-check in route_node
...
route_node->lock is "const" if --enable-dev-build is used. This is done
to deter people from messing with internals of the route_table...
unfortunately, the inline'd route_[un]lock_node runs into this.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-22 15:27:08 +02:00
Lou Berger
3f54388956
Merge pull request #939 from jbonor/optimization
...
Optimization
2017-08-22 09:01:20 -04:00
David Lamparter
57a553fd9c
Merge pull request #1012 from donaldsharp/eigrp_send_version
...
eigrpd: Setup eigrp to send FRR version
2017-08-22 14:59:22 +02:00
Donald Sharp
cacec09618
Merge pull request #1016 from opensourcerouting/cli-minor
...
minor cli foo (hashtable stats, pseudowire show)
2017-08-22 08:54:18 -04:00
Lou Berger
16e07d14e8
Merge pull request #1021 from opensourcerouting/privs-terminate
...
zprivs terminate
2017-08-21 16:55:33 -04:00
David Lamparter
4093d47b99
lib: terminate capabilities only if initialized
...
zprivs_caps_init() is called conditionally, apply the same condition on
terminate.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-21 21:53:46 +02:00
David Lamparter
8e9e4bd4bf
bgpd: don't zprivs_terminate() twice
...
zprivs_terminate() is called from bgp_exit()
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-21 20:20:41 +02:00
David Lamparter
53b997359f
build: fix --disable-snmp
...
--disable-foo results in "no" as value in $enable_foo
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-21 14:55:22 +02:00
David Lamparter
40818cec85
lib: move hashstats under debug, show per-daemon
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-21 14:41:02 +02:00
David Lamparter
d261dd7ea1
zebra: put pseudowire show cmd under mpls
...
Let's group this where it belongs and not clutter the commands too much.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-21 14:33:24 +02:00
David Lamparter
add57540ba
Merge pull request #1009 from donaldsharp/show_cmds
...
Show cmds
2017-08-21 14:30:41 +02:00
David Lamparter
baf7538dc7
Merge pull request #1008 from donaldsharp/check_for_daemon_existence
...
tools: Always ensure that the daemon exists at startup
2017-08-21 14:23:15 +02:00
David Lamparter
56f11e60fb
Merge pull request #1007 from donaldsharp/clear_help_str
...
bgpd: Fix bgp clear help string
2017-08-21 14:22:54 +02:00
David Lamparter
82cc2e9dee
Merge pull request #1002 from dwalton76/vtysh-exit-non-zero
...
vtysh: vtysh -f FOO should exit non-zero if it hits an error
2017-08-21 14:22:35 +02:00
Donald Sharp
63b02a77ca
Merge pull request #929 from opensourcerouting/hooks-doc-irdp
...
hook improvements, more hooks, doc example, IRDP cleanup
2017-08-21 07:47:17 -04:00
Donald Sharp
87f6dc504d
*: Add 'show debugging' command from vtysh
...
Allow vtysh to query every daemon about its
debugging status in one go.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-21 07:23:59 -04:00
Donald Sharp
7292d8510f
vtysh: Convert 'show logging' to use helper function.
...
The 'show logging' command was not using the 'show_per_daemon'
function for some reason.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-21 07:21:50 -04:00
Mitesh Kanjariya
71349e0358
zebra: lookup link by ifindex
...
Frr has an assumption that when interface A links to B,
we already know about B. But that might be true always.
It is probably purely depends on the configuration
and how the interfaces are hashed in Kernel.
FRR seems to sometimes get "A is linked to B" before it knows about B,
in that case, the linkage between the data structure for A & B won't be proper.
Ticket: CM-17679
Review: ccr-6628
Testing: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-20 06:10:38 -07:00
Mitesh Kanjariya
f51d8a274b
zebra: Delete AUTO macs when neigh list is empty
...
Ticket: CM-17660
Review: CCR-6624
Testing: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-20 05:53:15 -07:00
Donnie Savage
3c8954852c
Merge pull request #1013 from donaldsharp/versions
...
Changes look fine
2017-08-20 07:55:54 -04:00
Donald Sharp
2bdd6c8707
Merge pull request #1014 from diivious/ext-crash
...
Fixed issue with eigrp crashing when an external is received
2017-08-20 06:21:14 -04:00
Donnie Savage (dsavage)
c283f389d1
eigrpd: fix crash when external route is received
...
When an external route is received, eigrpd will crash. For now,
quietly discard the TLV. Work must be done to handle tlv
processing and changes needed to FSM so it understands an
external should not be chooses if an internal exist.
Signed-off-by: Donnie Savage <diivious@hotmail.com>
2017-08-19 21:45:49 -04:00
Donald Sharp
f7856a4466
isisd: Remove unused version
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-19 21:23:14 -04:00
Donald Sharp
3b4e6bd594
ospf6d: Remove ospf6d version string
...
This version string has not been updated in over 11 years.
I cannot see any viable reason that we should use or update
or anything with this value, remove.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-19 21:21:00 -04:00
Donald Sharp
ca9e3d23f6
eigrpd: Fix code comments
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-19 21:07:54 -04:00
Donald Sharp
01cbe587b0
eigrpd: Setup eigrp to send FRR version
...
Send to our peer the major/minor version of FRR that we are
working with. I decided to use FRR instead of the os major/minor
because the os itself doesn't tell you what version of EIGRP
you are actually using.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-19 20:56:50 -04:00
Donnie Savage
bd8110e50c
Merge pull request #1011 from donaldsharp/tlv_crash
...
Tlv crash
2017-08-19 20:39:45 -04:00
Donald Sharp
cf2f4daee3
eigrpd: Pass in actual used parameter to header creation
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-19 14:39:07 -04:00