proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-06-03 04:27:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
26,797 Commits 4 Branches 191 Tags 125 MiB
ed284e2338
Commit Graph

26797 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rafael Zalamena
4000805713 topotests: skip daemons without configuration 
Lets not start daemons without configurations.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:38:36 -03:00
Rafael Zalamena
20ec1f7038 topotests: remove code that checks for version 
We version the tests with FRR so we no longer need to check for version.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:38:25 -03:00
Rafael Zalamena
0a5b9d7158 topotests: use new OSPFv3 interface area syntax 
The old one is not VRF aware and is being deprecated.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:38:17 -03:00
Rafael Zalamena
582bf957fd topotests: reduce MSDP topology 
Meanwhile we don't get all MSDP features (MSDP route validation via BGP
AS Path as described in RFC 4611 Section 2), kill one of the links of
the topology to avoid intermittent test failures due to different
traffic route.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:35:45 -03:00
Mobashshera Rasool
d125213c8a ospfd: NSSA area should not exchange Type-4 LSAs in DD 
Problem Statement:
==================
OSPF Peer gets stuck in EXSTART with ARISTA Device.

Root Cause:
=================
First peer is form with Arista device in normal area and then
the area type is changed to NSSA. Due to this Type-4 and Type-5
LSAs advertised by Arista router is still present in
the OSPF DB. While DD exchange the Type-5 LSAs are omitted but
the Type-4 LSAs are not omitted due to which Arista device gets
stuck in EXSTART and it keeps moving between EXCHANGE And EXSTART.

Fix:
=================
When the area is NSSA, we should not send Type-4 LSAs in DD
exchange packet.

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
 2021-08-06 05:15:10 -07:00
Ryoga
f7cafbb717 bgpd: fix typo in ensure_vrf_tovpn_sid 
In eusure_vrf_tovpn_sid, there is a check to ensure not to select both
SID index and SID auto mode. But, this current check is wrong and not
meaningful.

Signed-off-by: proelbtn <contact@proelbtn.com>
 2021-08-06 11:53:42 +09:00
Igor Ryzhov
882bae36a0 pathd: fix indentation and redundant space in index config 
Before:
```
segment-routing
 traffic-eng
  segment-list SL1
 index  10 mpls label 16010
```

After:
```
segment-routing
 traffic-eng
  segment-list SL1
   index 10 mpls label 16010
```

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-05 23:47:27 +03:00
Igor Ryzhov
dfbabd45f8 pathd: fix indentation for mpls-te config 
Before:
```
segment-routing
 traffic-eng
 mpls-te on
 mpls-te import ospfv2
```

After:
```
segment-routing
 traffic-eng
  mpls-te on
  mpls-te import ospfv2
```

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-05 23:45:44 +03:00
Mark Stapp
6696b16bf0
Merge pull request #9302 from ton31337/fix/comments 
bgpd: Fix misleading comments for some parts
 2021-08-05 14:39:38 -04:00
Donald Sharp
5dbd69cc9f
Merge pull request #9023 from idryzhov/static-nb 
staticd: simplify the northbound code
 2021-08-05 09:38:00 -04:00
Donatas Abraitis
639caccfeb bgpd: Fix misleading comments for some parts 
Mostly just retrun => return and misleading comments at all.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-08-05 16:29:52 +03:00
Donatas Abraitis
9a339b7fc5 doc: Specify how aggregate-address works for BGP 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-08-05 09:08:29 +03:00
anlan_cs
46a8c34324 ospfd: fix coverity warning of one field initialization 
Add the initialization of prefixlen field in struct prefix.

Signed-off-by: anlan_cs <anlan_cs@tom.com>
 2021-08-04 21:20:20 -04:00
Mark Stapp
5f10f7804f
Merge pull request #9050 from LabNConsulting/chopps/reset-parallel 
Chopps/reset parallel
 2021-08-04 16:17:30 -04:00
Sri Mohana Singamsetty
08d7be0f4d
Merge pull request #9261 from vivek-cumulus/fix_evpn_quick_flap 
bgpd: Handle quick flaps of an EVPN prefix properly
 2021-08-04 12:44:37 -07:00
Donald Sharp
6140b3b41b zebra: prevent crash when nhlfe is NULL 
There exists a call path where the nhlfe_alloc can return NULL
for blackhole nexthops.  In this case we were still trying
to save the nhlfe pointer causing a crash when we attempted
to add it to a self-contained list.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-08-04 13:38:25 -04:00
Donald Sharp
b7457b40cd lib: Blackhole nexthops cannot be used as part of label generation 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-08-04 13:34:03 -04:00
Donald Sharp
10cc80cafd zebra: don't use default case when switching over enum nexthop 
Do not use the `default` case when switching over an enumerated
type.  This allows the code to fail to compile when we add a
new enumeration.  Thus allowing us developers to know all
the places in the code we'll need to touch.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-08-04 13:34:03 -04:00
Mark Stapp
27649e64f2
Merge pull request #9291 from donaldsharp/fix_long_sleep 
tests: Remove sleep(200) from bgp-evpn-overlay-index-gateway
 2021-08-04 12:54:25 -04:00
Donald Sharp
1ae0e1b315 lib: Convert assert to error and record it instead of aborting 
When we get a bad value for the opaque data length, instead
of stopping the program, discard the data and move on.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-08-04 11:13:26 -04:00
Donald Sharp
22e135b451
Merge pull request #8182 from mjstapp/topotest_start_tgen 
tests: make the topogen object available when starting daemons
 2021-08-04 08:48:06 -04:00
Donald Sharp
1c7cad9be8 tests: Remove sleep(200) from bgp-evpn-overlay-index-gateway 
Remove a 200 second sleep from bgp-evpn-overlay-index-gateway.
There does not seem to be any evidence that this is needed
and I cannot make the test fail without it.

Fixes: #9035
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-08-04 08:05:12 -04:00
Yash Ranjan
a867da2b6b ospf6d: Check the cost only when asbr_present for ECMP routes 
For ECMP routes, the metric cost and metric type are compared
even when the asbr entry is not present. This stops the routes
from getting removed when max age LSAs are received for the
ECMP routes.

Signed-off-by: Yash Ranjan <ranjany@vmware.com>
 2021-08-04 05:03:10 -07:00
Donald Sharp
5504fee4a3
Merge pull request #9085 from mobash-rasool/pim-upst-4 
pimd: memory leak fix and issue fix
 2021-08-03 21:21:14 -04:00
Donald Sharp
761704b370
Merge pull request #9092 from rgirada/rmap 
ospfd: OSPF hello packets not sent with configured hello timer
 2021-08-03 21:18:21 -04:00
Donald Sharp
3e18e550ed
Merge pull request #9108 from opensourcerouting/ospf6d-range-fixes 
ospf6d: fix argument processing in the "area ... range" command
 2021-08-03 21:15:12 -04:00
Igor Ryzhov
7548eaefad Revert "tests/bgpd: initialized candidate_config to vtysh" 
This reverts commit 64fb3f8666.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
5da71ba93d Revert "tests: add bgp yang module registery to attr test" 
This reverts commit 15cbc38206.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
92cf415d6b Revert "bgpd: register northbound callbacks to bootstrap" 
This reverts commit e4a464160d.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
5f81a7edcb Revert "bgpd: bgp northbound callbacks prototypes" 
This reverts commit a1950c80a5.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
1ca2fd1175 Revert "bgpd: convert global config to transactional cli" 
This reverts commit ff8a8a7ac1.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
5bbc8de1b0 Revert "bgpd: register nb routing hook" 
This reverts commit 374069da83.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
1e48dfd2fd Revert "bgpd: shorten northbound callback names" 
This reverts commit 906ebeec98.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
66d2a8553b Revert "bgpd: correct bgp global context" 
This reverts commit 87ce25646b.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
56648eab39 Revert "bgpd: move router bgp nb callback" 
This reverts commit 5e42cb2fb0.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
8382083a8f Revert "bgpd: no router bgp check candidate config" 
This reverts commit 4b63e358bc.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
cd6012bb22 Revert "bgpd: fix SA warnings in bgp northbound" 
This reverts commit 082de39e71.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
31acf04aa4 Revert "bgpd: Use default VRF name if using router bgp command" 
This reverts commit 5ce106b72b.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
23f1fa0704 Revert "bgpd: rename router bgp callbacks" 
This reverts commit feded4118b.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
2fc82a12fb Revert "bgpd: fix crash in bgp instance creation" 
This reverts commit a5ab756f24.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
385069ca17 Revert "bgpd: use common api in bgp_get" 
This reverts commit bdaadb91e8.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
012baeeca6 Revert "yang: update bgp module afi-safi parameters" 
This reverts commit 3b66fcef58.
 2021-08-03 23:36:31 +03:00
Igor Ryzhov
585f1adc4f Revert "bgpd: convert addr-family clis to transactional clis" 
This reverts commit 37a87b8f98.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 23:36:30 +03:00
Igor Ryzhov
ba0b0df767 Revert "bgpd: add match-med nb support in aggregate cmd" 
This reverts commit fa423774ff.
 2021-08-03 23:36:05 +03:00
Igor Ryzhov
1bf062e1b4 Revert "bgpd: add nb support for suppress-map in aggregate cmd" 
This reverts commit 90e21f3535.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 23:35:40 +03:00
Igor Ryzhov
28c6e24701 Revert "bgpd: neighbor peergrp config to transactional cli" 
This reverts commit f4b8ec0721.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-03 22:29:13 +03:00
Igor Ryzhov
e7457ac8d0 Revert "*: shorten name of prefix-limit options" 
This reverts commit afe03f6094.
 2021-08-03 22:20:53 +03:00
Igor Ryzhov
7e62b79286 Revert "bgpd: convert max prefix clis to transactional" 
This reverts commit 04261decb9.
 2021-08-03 22:20:53 +03:00
Igor Ryzhov
c36bc05fcd Revert "bgpd: convert neighbor peer config to transactional" 
This reverts commit 8611c7f3b6.
 2021-08-03 22:20:53 +03:00
Igor Ryzhov
80d6a89c9d Revert "bgpd: shorten names for default originate nb callbacks" 
This reverts commit cc4440c317.
 2021-08-03 22:20:53 +03:00