Commit Graph

29815 Commits

Author SHA1 Message Date
Spoorthi K
8de0f66ae4 doc: Update setup.rst
Signed-off-by: Spoorthi K <spk@redhat.com>
2022-09-27 20:10:18 +05:30
Donald Sharp
17c149ff1b vtysh: Properly handle service cputime-warning XX in config
Prevent duplicate lines from each daemon in vtysh output.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-27 09:05:30 -04:00
Donald Sharp
54b7d471f3 vtysh: Properly handle [no] service cputime-stats in config
Prevent duplicate lines from each daemon in vtysh output.

Fixes: #12022
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-27 09:02:26 -04:00
Mobashshera Rasool
a0625bb356 pimd: IGMP Querier election is not correct in LAN scenario
When more than 2 routers are present in LAN and the querier
goes down, the other routers will wait for other querier
present timer to expire to elect a new querier.
This issue will be seen when the router having next lower ip
address expires the other querier present timer first and it
starts sending the query message. Now on the other non-querier
routers it will receive this query and reset its other
querier present timer but the querier is still the old one
and since it is lowest ip, it never gets updated to the newly
elected querier.

Reset the other querier timer only if query is received from
the previously elected querier or a better new querier
This will make sure that non-querier elects the new querier
whose ip address is higher than the old querier
when the old querier goes down via other querier querier
timer expiry

Issue: #12027

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-09-27 05:04:24 -07:00
Donatas Abraitis
0d8f9f091b
Merge pull request #11989 from maduri111/bgpd-cond-adv-peer-unset
bgpd: conditional advertise-map unset on peer not re-advertising with…
2022-09-27 15:03:58 +03:00
Olivier Dugeon
031561497c
Merge pull request #11910 from fdumontet6WIND/NAI_Adj
pathd: nai adjacency fix query type f for IPV6
2022-09-27 11:24:53 +02:00
Donatas Abraitis
77c5f1b936
Merge pull request #12009 from AbhishekNR/json_last-member-query-count
pim6d: Adding last member query count field in "show ipv6 mld interface [ifname] json" command.
2022-09-27 09:42:11 +03:00
Brian Rak
d087003451 tools: Configure systemd to always restart FRR, regardless of exit code
The current service file configures restarts on-abnormal, which translates to "unclean signal", "timeout", or "watchdog". This patch updates it to always restart, as there's never really a time watchfrr should exit by itself at all.

Signed-off-by: Brian Rak <brak@vultr.com>
2022-09-26 11:23:29 -04:00
Philippe Guibert
e77ac87a2c pathd: change the vty output, when no ted is enabled on pathd
Change the vty output, in case ted is not enabled.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2022-09-26 17:12:02 +02:00
Donald Sharp
b2328784cb
Merge pull request #12002 from opensourcerouting/fix/add_doc_missing_bgp_implemented_rf
doc: Update supported BGP RFC list
2022-09-26 09:07:22 -04:00
Donald Sharp
d8cb344c36
Merge pull request #12000 from opensourcerouting/fix/remove_deprecated_ospf_command
ospfd: Remove deprecated command `graceful-restart helper-only`
2022-09-26 08:44:40 -04:00
Donald Sharp
1e7602aa9b
Merge pull request #12003 from anlancs/fix/fpm-crash
zebra: fix fpm crash
2022-09-26 08:43:40 -04:00
Sai Gomathi N
6f606a88f3 doc: Updated the document for mld debug commands
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-26 05:16:50 -07:00
Donatas Abraitis
4c17bee53f lib: Fix show route-map NAME json command and memory leak
JSON object was generated, but not printed, because the function returned
immediatelly, even without freeing the memory.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-26 14:56:20 +03:00
Donatas Abraitis
58e111f65c bgpd: Print hostname for peer as well when marking as stale for route-refresh
Before:

```
2022/09/26 10:13:35.261 BGP: [QCZ1W-VKS36] 192.168.0.1(r0) sending REFRESH_REQ for afi/safi: IPv4/unicast
2022/09/26 10:13:35.262 BGP: [VF3QY-FP1PP] 192.168.0.1: route-refresh for IPv4/unicast, marking prefix 172.16.1.1/32 as stale
2022/09/26 10:13:35.262 BGP: [VF3QY-FP1PP] 192.168.0.1: route-refresh for IPv4/unicast, marking prefix 192.168.0.0/24 as stale
2022/09/26 10:13:35.262 BGP: [SDZS7-XVC4W] 192.168.0.1(r0) rcvd route-refresh (BoRR) for IPv4/unicast, triggering timer for 360 seconds
2022/09/26 10:13:35.362 BGP: [Y6XKR-PF89P] 192.168.0.1(r0) rcvd route-refresh (EoRR) for IPv4/unicast, stopping BoRR timer
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-26 11:13:40 +03:00
Abhishek N R
6b94500dba pim6d: Adding last member query count field in "show ipv6 mld interface [ifname] json" command.
Fixes: #12004

Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-26 00:10:58 -07:00
Sai Gomathi N
a25597611d pimd,pim6d: Change the show running commands based on address family
Change the show running commands for igmp and mld debug commands
based on the address family.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-26 00:09:45 -07:00
Sai Gomathi N
f187700545 pim6d: Add 'debug mld trace detail'
Implementing debug mld trace detail for MLD activity.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25 23:46:37 -07:00
Sai Gomathi N
e0a7a5ebe3 pim6d: Add 'debug mld trace'
Implementing mld trace for MLD protocol activity.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25 23:33:59 -07:00
Sai Gomathi N
beecba6e17 pim6d: Add 'debug mld packets'
Implementing mld packets debug to information about packet generation for sending
and about packet handling from a received packet.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25 23:22:31 -07:00
Sai Gomathi N
b92f5c2ecc pim6d: Add 'debug mld events'
Implementing debug mld events command for debugging MLD system events.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25 23:07:42 -07:00
Sai Gomathi N
de00db38aa pim6d: Add 'debug mld'
Implementing debug mld command for MLD protocol activity.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25 22:29:37 -07:00
Donatas Abraitis
1311166751 doc: Add neighbor PEER extended-optional-parameters command
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-25 21:43:41 +03:00
Donatas Abraitis
2a3a758533 doc: Update supported BGP RFC list
Added such RFCs (missing):

https://datatracker.ietf.org/doc/html/rfc2385
https://datatracker.ietf.org/doc/html/rfc2918
https://datatracker.ietf.org/doc/html/rfc4360
https://datatracker.ietf.org/doc/html/rfc4456
https://datatracker.ietf.org/doc/html/rfc4724
https://datatracker.ietf.org/doc/html/rfc4760
https://datatracker.ietf.org/doc/html/rfc5065
https://datatracker.ietf.org/doc/html/rfc5291
https://datatracker.ietf.org/doc/html/rfc5292
https://datatracker.ietf.org/doc/html/rfc6472
https://datatracker.ietf.org/doc/html/rfc5492
https://datatracker.ietf.org/doc/html/rfc7911
https://datatracker.ietf.org/doc/html/rfc6996
https://datatracker.ietf.org/doc/html/rfc6938
https://datatracker.ietf.org/doc/html/rfc8093
https://datatracker.ietf.org/doc/html/rfc7947
https://datatracker.ietf.org/doc/html/rfc9012
https://datatracker.ietf.org/doc/html/rfc8669
https://datatracker.ietf.org/doc/html/rfc8050

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-25 11:58:10 +03:00
Donatas Abraitis
760863701e
Merge pull request #12001 from donaldsharp/use_integrated
doc: Align docs to recommend integrated config
2022-09-25 11:44:42 +03:00
Madhuri Kuruganti
b9fdddb83b bgpd: conditional advertise-map unset on peer fixing warning messages
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
2022-09-25 11:48:47 +05:30
Madhuri Kuruganti
1285c4ace9 bgpd: conditional advertise-map unset on peer not re-advertising withdrawn routes
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
2022-09-25 11:48:47 +05:30
anlan_cs
0d0f516c76 zebra: fix fpm crash
Fix issue#11996.

When removing VRF ( all routes of this VRF), zebra mistakenly forgot to check
whether its routes are in update queue of FPM.  So FPM module will crash during
its dealing with these routes, which are already freed.

Add a new HOOK `rib_shutdown()`, `zebra_rtable_node_cleanup()` will use it
to remove these routes from update queue of FPM module before freeing them.

Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-09-24 19:39:58 -04:00
Donald Sharp
9b953119b4 doc: Align docs to recommend integrated config
Docs were recommending both integrated and non-integrated
config in different sections.  Remove the recommendation
for non-integrated config from vtysh.rst.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-23 15:16:40 -04:00
Donatas Abraitis
083e241235 ospfd: Remove deprecated command graceful-restart helper-only
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-23 22:10:44 +03:00
Donatas Abraitis
344d81ceed
Merge pull request #11982 from samanvithab/bgp_mem_fix
bgpd: multiple memory leak issue fixes
2022-09-23 17:54:33 +03:00
Samanvitha B Bhargav
b96b4f1c5f bgpd: Cleanup memory leaks associated with t_deferral_timer
We are allocating temporary memory for information about
what to process in this thread, which is not being cleaned
up on thread cancelling.

Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-23 00:14:12 -07:00
Donatas Abraitis
f731266e95
Merge pull request #11997 from sri-mohan1/sri-zebra-dbg1
zebra: changes for code maintainability
2022-09-23 10:04:25 +03:00
sri-mohan1
a843c5ba2a zebra: changes for code maintainability
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
2022-09-23 09:57:35 +05:30
Isabella de Leon
77a39a5db2 doc: Add CLI documentation for new overload on startup command
Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
2022-09-22 13:47:26 -07:00
Donald Sharp
9e3b5187b7
Merge pull request #11993 from opensourcerouting/feature/printfrr_pRD
bgpd: Use %pRD for prefix_rd2str()
2022-09-22 09:30:51 -04:00
Donald Sharp
f25d47d2ef
Merge pull request #11979 from opensourcerouting/fix/stop_conditional_adv_thread
bgpd: Stop conditional advertisements thread when terminating
2022-09-22 09:30:01 -04:00
Donatas Abraitis
c4f64ea94d bgpd: Use %pRD for prefix_rd2str()
Convert a bunch of prefix_rd2str() for json/vty stuff.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-22 13:12:11 +03:00
Donatas Abraitis
c0539ff458 bgpd: Stop conditional advertisements thread when terminating
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-22 10:30:13 +03:00
Isabella de Leon
01ea9b035e isisd: Add set-overload on-startup CLI/YANG support
Before:
r1# conf
r1(config)# router isis <area-tag>
r1(config-router)# set-overload-bit
  <cr>
r1(config-router)# end

After:
r1# conf
r1(config)# router isis <area-tag>
r1(config-router)# set-overload-bit
  <cr>
  on-startup  Set overload bit on startup
r1(config-router)# set-overload-bit on-startup
  (0-86400)  Set overload time in seconds
r1(config-router)# set-overload-bit on-startup 300
r1(config-router)# end

Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
2022-09-21 15:41:38 -07:00
Donald Sharp
447d0fc290
Merge pull request #11986 from opensourcerouting/fix/drop_outdated_files
bgpd: Drop out-of-date files
2022-09-21 12:56:25 -04:00
Donatas Abraitis
bdc33d0b13 bgpd: Drop out-of-date files
Just not maintained for > 18 years.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-21 17:21:31 +03:00
Donald Sharp
6db5e4c11a
Merge pull request #11977 from opensourcerouting/fix/docker_alpine_apk
docker: Keep and copy .apk files after they are built
2022-09-21 10:15:49 -04:00
Donatas Abraitis
172e4d9fa2 bgpd: Stop LLGR thread when deleting a peer and/or GR flags changed
Also valid when shutting down a BGP instance.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-21 17:13:28 +03:00
Samanvitha B Bhargav
2305e3e460 bgpd: memory leak issue fix
Memory allocated when 'import vrf route maps <>' is configured,
wasn't being freed when the entire bgp config
was deleted through 'no router bgp'.

Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-21 01:57:09 -07:00
Samanvitha B Bhargav
92d537611b bgpd: memory leak issue fix
In ecommunity_del_val(), ecommunity was not being freed
when the last value in the ecommunity was being deleted.

Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-21 01:45:41 -07:00
Samanvitha B Bhargav
f6a460f982 bgpd: memory leak issue fix
When router id is changed through config, new RD is auto generated.
However new export RT was being assigned without freeing
the older RT from VRF.

Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-21 01:44:14 -07:00
Donatas Abraitis
383a873495
Merge pull request #11802 from AbhishekNR/ttable_pim_state
pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim state" command output.
2022-09-21 11:00:40 +03:00
Donatas Abraitis
96e8d5fb04
Merge pull request #11918 from patrasar/show_ipv6_mld_interface_fix
pim6d: "show ipv6 mld interface" command
2022-09-21 10:19:33 +03:00
mobash-rasool
ea59d5e08d
Merge pull request #11968 from donaldsharp/isis_plist_mem_leak
isisd: Fix memory leak on shutdown with prefix lists
2022-09-21 08:22:33 +05:30