proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-10 08:43:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
19,542 Commits 4 Branches 191 Tags 125 MiB
e01a788c44
Commit Graph

212 Commits

Author SHA1 Message Date
Lou Berger
b0f0d980b5 lib: allow all rw access to /tmp/topotests (for package support and debug) 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:14 -05:00
Lou Berger
da63d5b319 lib: use per node log directory when topotest is used without topogen 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:14 -05:00
Lou Berger
deb4cef09a lib: log to start/local (per node) dir, log commands 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:14 -05:00
Lou Berger
2a59a86b50 lib: limit checkRouterCores output to once per router start 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:14 -05:00
Lou Berger
f76774ec9d lib: add check for core and memory issues after routerstop 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:14 -05:00
Lou Berger
e1dfa45e1b lib: convert to directories per node 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:14 -05:00
Lou Berger
c941311fef lib: lutil - fix test numbering, add test number to command logging 2018-11-27 20:22:14 -05:00
Lou Berger
518874f48a lib: fix path the led to group_nl_converted being referenced when not set 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
d521440020 lib/bgprib.py: add copyright notice 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
c63906e8cf lib: lutil matching without changing newlines 
Prior behavior of luCommand was to convert newlines to spaces in DUT
output before pattern matching. New method operating in parallel uses
re.DOTALL to mimic same behavior and allow preserving original DUT output.
The original output is needed for some scripts that parse line-by-line.

There is also some test code to compare match results using the
old way and new way and log a message if they are different. After
some short time we can develop confidence that using this new method
will not break any existing tests.

Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
587e28a4f0 lib/bgprib.py: handle empty json results gracefully 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
90d56c6cca lib/ltemplate.py: add KeepGoing parameter to ltemplateTest 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
7fdc42389a ltemplate.py: start isisd when isisd.conf present 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
09da03d50d ltemplate.py: remove dependency on hard-coded router name r2 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
1630ad4695 bgp_l3vpn_to_bgp_vrf: assign different RDs to customers on r4 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
044e2a3119 lib/bgprib.py naming rib->bgprib is more accurate 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
f7af60f202 lutil: expose result method 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
G. Paul Ziemba
8a28936d41 lib: bgprib utility to compare rib against list of required routes 
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
87d5e16a45 lib: TopoExaBGP.start - report unexpected exabgp output 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Philippe Guibert
8dd5077d81 lib: zebra support for vrfwnetns parameter 
topotest library is being added a new parameter when preparing the
configurationof each daemon. This parameter will be used to call the
daemon with some extra parameters. The -n parameter for zebra is taken
into account.
Also, when a extra parameter is given for calling zebra, a check is done to
see if it is possible to run zebra daemon with that option. This is the
case for vrfwnetns option. If not available, an error message is sent
back.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2018-11-27 20:22:13 -05:00
Lou Berger
cc3cf6a883 lib: lutil - fix test counting, add returnJson flag 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
89b9abd97e lib: ltemplate add common ltemplateRtrCmd and ltemplateVersionCheck 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
9711fc7e0b lib: add tgen level mpls init and hasmpls flag 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
4348027f3e lib: add script name to summary output 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
66c5287ec0 lib: add luLast to get last found luCommand regex match 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
850de337d9 lib: ltemplate simplify start/stop 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
9e219b9af7 lib: scope life of Lutil and _lt to a single test run reorg to support regression environment 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
447f2d5a16 lib: add router.has_mpls check 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Rafael Zalamena
46325763aa topogen: fix assertion on routers_have_failure 
`errors != ''` is never going to be false so the assert was never being
triggered.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2018-11-27 20:22:13 -05:00
Rafael Zalamena
0e17ee9e03 topogen: import pytest assert function 
Use the pytest assert function to be able to report to pytest failures
that happened inside the API.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2018-11-27 20:22:13 -05:00
Lou Berger
8ab91133c7 lib: ltemplate - fix handling of CallOnFail (take 2) 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
5859c4be6b lib: ltemplate - fix handling of CallOnFail 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:13 -05:00
Lou Berger
df437d254a lib: add LabN testing template 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:12 -05:00
Lou Berger
50b15737c9 lib: lutil - make it easier to spot command output and null output 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:12 -05:00
Lou Berger
2fdcc34250 lib: lutil - make requested error logging change 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:12 -05:00
Lou Berger
a582a8e9c5 lib: lutil cleanup move utilities/lutil.py -> lib/lutil.py add: luShowFail, CallOnFail, luStart parameter to set log dir change default wait to 10sec 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
e600b2d93c topotest: remove pid files 
Remove PID files after a SIGKILL or confirmation that the pid file no
longer contains a running PID.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
065bd557f8 topotest: improve informational messages 
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
63038f4b02 topotest: show the user that we are waiting 
Add a log message to tell the user that we are waiting for zebra.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2018-11-27 20:22:12 -05:00
Lou Berger
3a568b9ca6 lib: speed up router shutdown stopRouter: report when a process is being killed only sleep if actually killed a process add option to not sleep or conduct -7 kill topogen stop: add wait parameter (defaults to old/wait) when stopping routers, first stop all without waiting then do a second pass where will wait if needed 
Signed-off-by: Lou Berger <lberger@labn.net>
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
08533b7bce topotest: always show diff on json_cmp failure 
Append diffs on all json_cmp failures so the reader can compare JSON
field differences.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
479b98aacd topotest: specify why we are waiting 
This shows the user why the router teardown is taking 2 seconds long.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
222ea88b2a topotest/topogen: demote some messages level 
The messages level of this commit were downgraded because some of them
happen on 'non-error' situations. This should help diminish the error
log verbosity on the CI-system run.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
034237db12 topotest: fix a regression in version_cmp 
It was found a regression on an edge case when the second number in the
comparison was (at least) 2 numbers longer the comparison would fail
with a wrong return value. It succeeded for some cases because the
first comparison in the exception was correct, but not the second.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
7bd28cfc67 topotest: improve json error messages 
Show a diff of the JSON values instead of dumping the whole
data structures.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
2db5888df5 topotest: json_cmp_result split error lines 
When the API user wanted to show newlines we have to break them manually
to get the propper format.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
bc2872fd17 topotest: allow passing options to difflib 
Extend the topotest diff functions to allow receiving difflib options.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
566567e9be topotest: remove unused json_cmp unused parameter 2018-11-27 20:22:12 -05:00
Rafael Zalamena
fcfbc7696b topogen: fix diagnostics failure 
Don't try to log to file if directory doesn't exist.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
d34f613477 topogen: save zebra version output 
Keep the zebra version output for later problem diagnostics.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
7547ebd8cd topogen: log diagnostics to file 2018-11-27 20:22:12 -05:00
Martin Winter
7551168cba lib: Use SIGTERM for killing daemons first and only SIGBUS (7) if the daemons fail to exit. 
- This allows daemons to free up memory and avoid false memory leak reports

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:12 -05:00
Martin Winter
44a592b2a6 lib: check for eigrpd available and return warning if missing instead of failing 2018-11-27 20:22:12 -05:00
Rafael Zalamena
c267e5b112 topogen: add support for eigrpd and nhrp 2018-11-27 20:22:12 -05:00
Rafael Zalamena
57c5075b7b topogen: router startup failure triggers errors 
Makes `router_have_failure()` detect frr startup errors.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
b3b1b1d16c topogen: treat some corner cases on vtysh failure 
Don't throw unneeded tracebacks when 'show version' doesn't show us what
we expect, instead gracefully fail.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
1eb633c012 topogen: show pretty output for skipped messages 
Format them properly instead of printing a dictionary.
 2018-11-27 20:22:12 -05:00
Donald Sharp
cda83bee9f Allow topotests to work with eigrp and nhrp 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-11-27 20:22:12 -05:00
David Lamparter
91733ef85e topotests: change from "context" to "unified" diff 
context diff:
*** before.py
 2018-11-27 20:22:12 -05:00
Martin Winter
9427b78f65 lib: Change topology to output INFO and DEBUG to stdout and other levels to stderr 
Previously, all logs were sent to stderr
 2018-11-27 20:22:12 -05:00
Martin Winter
c11c4cc7d3 lib: add check for mpls kernel modules to diagnose_env() 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:12 -05:00
Martin Winter
b431b5540f lib: Enhance daemon_available() function to check for mpls modules in case of LDPd 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:12 -05:00
Martin Winter
e1b2ce6a70 lib: Add check for MPLS kernel modules to exist before trying LDP tests 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
570f25d80a topotest: log sleep function 
Added a wrapper for the sleep function that should be used to register
in the log files the amount of time spent sleeping.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
f9b48d8b42 topogen: allow daemon spec in vtysh_cmd 
Allow commands to be run per-daemon basis. While here make daemon
logging file configuration per-daemon.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
99a7a912fd topotest: implement 'ip route' functions 
Implement an abstraction to the commands 'ip route' to get the node
current routing table state.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
812e38a94d topotests: make 'quagga' check optional 
Only check for quagga directories and binaries when we don't find FRR.
Also fix a copy-paste error in warning message.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
45619ee3de topotest: simplify ldp kernel check 
Use version_cmp() instead of hand rolling its own parser.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
007e731324 topotest: implement environment diagnostics 
Run environment diagnostics on topotest start, report all detected
problems and abort if an error condition is met.
 2018-11-27 20:22:12 -05:00
Rafael Zalamena
6ca2411e86 topogen: add equipment version handling 
Added helper functions to TopoRouter to test equipment version and type.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
4190fe1ef1 topotest: add version comparison function 
Implemented a version comparison function that tells if a version
contained in a string is greater/less/equal to another.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
f7840f6bdf topotest: add text normalization function 
Standardized function that removes format spaces (or tab) and carriage
returns characters. This function is useful to allow output text
processing without breaking diff capabilities.

Output example:
*N IA 2001:db8:2::/64                ::                        r2-eth0    00:03:39

Becomes:
*N IA 2001:db8:2::/64 :: r2-eth0 00:03:39

If you remove 'IA' you won't have space formatting problem anymore.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
7b093d84e0 topogen: handle JSON decode failures 
Instead of raise()ing, return a empty dictionary.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
78ed61230c topogen: implement router check method 
Use a standard function to do 'router running checks' instead of having
to duplicate the code in every test.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
e84692970b topogen: fix topogen memleak activation 
When memleak_path is present in the configuration file it means that it is
activated.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
dc0d3fc53f topotest: add JSON list comparation support 
Add missing list support for json_cmp(). The missing support was
noticed while writing the BGP ECMP topology test.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
19ccab570b topogen: add support for ExaBGP peers 
Implemented basic support for ExaBGP peers.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
393ca0fa16 topogen: add error functions 
Store errors and error code in topogen so other tests can look up for
failures and skip tests.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
4cfdff1a86 topogen: implement start/stop methods for TopoGear 
Having a generic start/stop methods for TopoGear allows TopoGen to call
start/stop for all equipments. This allows us to reduce the teardown
code by removing the necessity of having to always remember to call
each equipment clean up function.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
f6899d4dd4 topogen: configure daemon logging files 
Auto configure daemon logging files to the appropriated place. This
removes the responsibility from the test developer to set this in the
daemon configuration.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
13e1fc493b topogen: add per router logging 
TopoRouters now create a logger (which logs to /tmp/{router_name}.log)
on start to record all commands and events that it goes through. All log
messages contain timestamps that may be used in the future to:
(1) correlate commands call with events
(2) benchmark/time command speed
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
6c131bd303 topotest: use topolog instead of print 
Fix some whitespace issues while at it.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
77ebccacf4 topolog: support adding loggers during runtime 
Allow topotest subsystems to create their own loggers. This will help
increase log organization and allow different settings to fit the
subsystems needs.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
36d1dc45eb topolog: implement a logging abstraction 
The default logger (root) is already being used by Mininet, so to allow
customizing logging output and configuring log files Topolog was
created. Topolog is no more than a thin layer abstraction to call
logging functions without using the 'root' logger.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
c540096e86 topogen: add memory leak report configuration 
Allow memory leak to be configured from the configuration file.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
edd2bdf6de topogen: support configuration file 
Use a configuration file for casual settings like:

* Verbosity level (helps when debugging mininet issues)
* Custom daemon directory (in order to support running different daemon
  binaries without touching tests)
* Daemon type switch: allow running quagga without touching any test
  files

Also fix the add_router() documentation to include all options.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
3668ed8dc2 topotest: improve json_cmp assert output 
Create a specialized assert and json_cmp() result to improve the
comparison output. With this we also got a way to display all comparison
failures instead of just the first one.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
a40daddc4c topogen: added JSON output support for vtysh_cmd 
Allow vtysh_cmd() to convert JSON output to Python data structures.
This feature will be used to get vtysh JSON outputs for tests
comparsions.

Usage example:

```py
router = get_topogen().gears['r1']
json_output = router.vtysh_cmd('show ip ospf json', isjson=True)
json_cmp(json_output, {'important_key': 'important_value'})
```
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
09e21b4487 topotest: implement json_cmp function 
Implemented a JSON compare function that tells you when a specific
subset of items exist or not inside a JSON dataset.

More details can be found in the function docstring or in the test file
lib/test_json.py.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
31bfa9df79 topogen: use shorter names for equipments 
After some feedback from mwinter@, the names of equipments are now
shorter to make it easier to type them and to keep consistency with
mininet documentation. While here, update the template and make it use
optional name parameters for clarity.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
7326ea11c0 topogen: implement __str__ for TopoGear objects 
Print TopoGear name, links and type (currently TopoRouter and Switch
don't have any other useful attributes).
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
38c3993248 topogen: implement memory leak test call 
This is a shortcut for the memory leak test, it should be used in the
new tests in order to avoid boilerplate code.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
8c3fdf62a9 topogen: add support for setting link state 
This commit changes how topology links are made in order to support
discovering who and what link is the node interface connected to. After
that, the implementation of the link state change functions were trivial
as calling a command in the node shell.

The method run() was moved from TopoRouter to TopoGear so all equipment
types can benefit from this code.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
d9ea1cda81 Topogen: document new options 
We can now add routers to the topology using different daemon binaries
path. This will allow us to run tests with different daemon versions and
types.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
2ab8553078 topotest: parameterize daemon's path 
This diff is a code cleanup that will allow us more flexibility when
defining and using the daemon binaries path, it also fixes a few pylint
warnings.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
1fca63c1e4 topogen: first code import 
Topogen (Topology Generator) is a helper that wraps around Topotest to
simplify some of the boilerplate code. This abstraction will help the
development of new tests and new APIs without breaking the existing
ones. It also makes the relation of objects clearer, since we no longer
touch the Mininet API directly, which in turn also makes us less
vulnerable to external API changes.
 2018-11-27 20:22:11 -05:00
Rafael Zalamena
797e8dcf5c lib: assert sysctl values 
Implemented two functions to help setting sysctl values:

* set_sysctl: set a sysctl and return an auditable return value
* assert_sysctl: uses the previous function to assert that the sysctl
  was set
 2018-11-27 20:22:11 -05:00
Martin Winter
c8cff3ced1 lib: Fix stopRouter not to fail for case if daemon was never started 
Fixes the issue for topotest to fail ot end of skipped LDP test on
a system without MPLS support

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
17070436a3 lib: cleanup diff text output formatting issue and move to library 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
4942f29847 lib: Move AddressSanitizer check to separate procedure and add check for errors in vtysh itself as part of checkRouterRunning 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
311dba3332 lib: Send Output error from AddressSanitizer to StdErr 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
84379e8e7f lib: Add different failure comment on processes killed by AddressSanitizer 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
597cabb74d lib: Move updated topotest.py lib with AddressSanitizer to correct directory (fix mistake from 2 commits ago) 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
50c40bdebb Fix memory leak detection and reporting which accidentally was dropped a month ago 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
e9125d9286 lib: Fix another typo on kernel compare 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
c63b6f86f0 lib: Fix version check in previous kernel compare 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Donald Sharp
dd43120e8e Actually fix version comparison 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-11-27 20:22:11 -05:00
Donald Sharp
dd4eca4d97 lib: Fix kernel version parsing 
When we have a kernel sub version > 10 the float conversion
of the kernel version causes 4.10 to be less than 4.5

Get the kernel version in groups on <major>.<minor> and do
comparison that way

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-11-27 20:22:11 -05:00
Martin Winter
80eeefb7da lib: Add function to check for daemon available (i.e. LDPd) and function to return typ (quagga or frr) 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
a93477ec42 topotest library: Fix creation of /etc/XXX/vtysh.conf 
- Needs to be created in local filesystem of each router

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
99561211e1 Added optional output for memleaks at the end of test. Enable them by setting the environment variable TOPOTESTS_CHECK_STDERR to some value 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00
Martin Winter
594b1259f9 Move common function and class to topotest library 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
 2018-11-27 20:22:11 -05:00