Commit Graph

13381 Commits

Author SHA1 Message Date
Donald Sharp
2dd0b3f492 vtysh: Add some missing daemons to some commands in vtysh
Fixes: #3173
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-14 19:04:58 -04:00
Donald Sharp
c9e3c7bfb2
Merge pull request #3172 from opensourcerouting/bfd-mhop-lookup
bfdd: fix multi hop hash lookup
2018-10-14 18:04:22 -04:00
Rafael Zalamena
2055ea0969 bfdd: fix multi hop hash lookup
Use the proper multi hop hash for matching multi hop peers.

Spotted by Dmitrii Turlupov.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2018-10-14 15:39:55 +02:00
Russ White
79e8a97c1a
Merge pull request #3024 from ton31337/fix/validate_route-map
bgpd: Check if route-map really exists before applying to the peer
2018-10-14 08:48:48 -04:00
Russ White
97dc689417
Merge pull request #3142 from donaldsharp/bgp_peerhash
Bgp peerhash
2018-10-12 16:55:50 -04:00
Russ White
5d3a8c513f
Merge pull request #3134 from donaldsharp/bum_flooding
Bum flooding control for BGP and Zebra
2018-10-12 16:52:21 -04:00
Russ White
cf875a1449
Merge pull request #3168 from adharkar/frr-bgp_json
bgpd: BGP JSON new fields
2018-10-12 16:48:08 -04:00
Russ White
13e911db5f
Merge pull request #3167 from chiragshah6/ospfv3_dev
ospf6d: fix ospf6 crash in inp lsa processing
2018-10-12 15:55:59 -04:00
Donald Sharp
b0ecf336f3
Merge pull request #3137 from opensourcerouting/feature/isis-bfd
Feature: BFD for IS-IS
2018-10-12 13:58:26 -04:00
Chirag Shah
beabf870d7 ospf6d: fix ospf6 crash in inp lsa processing
Use ospf6_prefix_same for comparing two exact same prefix
to determine ECMP for a route.
ospf6_route_cmp expects two different prefix rather
being exactly same.

Ticket:CM-22630
Testing Done:
performed ECMP of intra network prefix route via
sending same route via different available
ospf6 paths.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2018-10-12 09:56:09 -07:00
Christian Franke
d04f9fbf57 isisd: Fix license header of bfd code 2018-10-12 18:56:07 +02:00
Christian Franke
5489eb4563 isisd: Address code-style warnings 2018-10-12 16:45:32 +02:00
Donald Sharp
fd06964433 bgpd: Add '[no] flood <disable|head-end-replication>'
Add the '[no] flood <disable|head-end-replication>' command
to the l2vpn evpn afi/safi sub commands for bgp.  This command
when entered as 'flood disable' will turn off type 3 route
generation for the transmittal of the type 3 route necessary
for BUM replication on the remote VTEP.  Additionally it will
turn off the BUM handling via the new zebra command,
ZEBRA_VXLAN_FLOOD_CONTROL.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-11 20:27:28 -04:00
Donald Sharp
fbac9605a7 lib, zebra: Allow the specification of BUM flooding
Allow the modification of whether or not we will allow
BUM flooding on the vxlan bridge.  To do this allow
the upper level protocol to specify via the ZEBRA_VXLAN_FLOOD_CONTROL
zapi message.

If flooding is disabled then BUM traffic will not be forwarded
to other VTEP's.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-11 20:22:19 -04:00
Donald Sharp
eaae6204a9
Merge pull request #3140 from vishaldhingra/b_2802
zebra : VRF aware route map in zebra
2018-10-11 20:18:57 -04:00
Ameya Dharkar
37d4e0dfab bgpd: BGP JSON new fields
1. "show bgp ipv4 json"
  - Added "network" field which displays a prefix in 'prefix/prefixlen' format.

2. "show bgp ipv6 json"
  - Added "network" field which displays a prefix in 'prefix/prefixlen' format.
  - JSON does not have "prefix", "prefixLen" fields which are present in IPv4
    command. Added these fields as they are useful.

3. "show bgp ipv4/ipv6 neighbor <neighbor_addr> advertised-routes json"
  - Added "network" field.

4. "show bgp ipv4/ipv6 summary json"
  - Added "pfxSnt" for peers. This count is obtained from corresponding
    update_subgroup.

5. "show bgp neighbor json"
  - Added "sentPrefixCounter"

Signed-off-by: Ameya Dharkar <adharkar@vmware.org>
2018-10-11 15:35:21 -07:00
vishaldhingra
7cf16e19c5 zebra: vrf aware routmap is missing in Zebra #2802(Part 4 of 4)
The new cli for show output

Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:49:34 -07:00
vishaldhingra
214e5c2679 zebra: vrf aware routmap is missing in Zebra #2802(Part 3 of 4)
The cli changes to allow this to work.

Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:48:23 -07:00
vishaldhingra
6d53d7b1af zebra: vrf aware routmap is missing in Zebra #2802(Part 2 of 4)
Function parameter replacement of using zvrf instead of vrf_id

Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:46:55 -07:00
vishaldhingra
ac6eebce50 zebra: vrf aware routmap is missing in Zebra #2802(Part 1 of 4)
Work to handle the route-maps, namely the header changes in zebra_vrf.h
 and the mapping of using that everywhere

 Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:44:55 -07:00
Donald Sharp
7ab57d19ce lib, vtysh: Allow notification across multiple lines of failure
When reading in config files and we have failures on multiple
lines actually note the actual failure lines and return them.
This fixes an issue where we stopped counting errors after
the first one and we got missleading line numbers that
did not correspond to the actual problem.

This is fixed:
sharpd@donna ~/frr> sudo /usr/lib/frr/pimd --log=stdout -A 127.0.0.1 -f /etc/frr/pimd.conf
2018/10/11 09:41:01 PIM: VRF Created: default(0)
2018/10/11 09:41:01 PIM: pim_vrf_enable: for default
2018/10/11 09:41:01 PIM: zclient_lookup_sched_now: zclient lookup immediate connection scheduled
2018/10/11 09:41:01 PIM: zclient_lookup_new: zclient lookup socket initialized
2018/10/11 09:41:01 PIM: pimd 6.1-dev starting: vty@2611
2018/10/11 09:41:01 PIM: [EC 100663304] ERROR: No such command on config line 2: inteface lo
2018/10/11 09:41:01 PIM: [EC 100663304] ERROR: No such command on config line 3: ip igmp
2018/10/11 09:41:01 PIM: [EC 100663304] ERROR: No such command on config line 4: ip igmp join 224.1.1.1 13.13.13.2
^C2018/10/11 09:45:09 PIM: Terminating on signal SIGINT
2018/10/11 09:45:09 PIM: VRF Deletion: default(0)

Fixes: #3161
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-11 09:46:40 -04:00
Lou Berger
b3c8d34291
Merge pull request #3032 from donaldsharp/bgp_info
`struct bgp_info` to `struct bgp_path_info`
2018-10-11 09:17:31 -04:00
Donatas Abraitis
1de2762153 bgpd: Check if route-map really exists before applying to the peer
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2018-10-11 10:56:12 +03:00
Philippe Guibert
8a066a70c3 bgpd: vpn route-map config should be kept, except if vrf list is on
When executing vpn route-map config for importation, the running-config
records vrf import route-map instead. Actually, this is a problem when
restarting configuring when using vpn route-map. The choice is done to
move to vrf format, when at least one import list is created for vrfs.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-11 08:42:18 +02:00
Donald Sharp
8f7bfe318b
Merge pull request #3153 from adharkar/frr-scount
bgpd: Incorrect sent prefix count for a split subgroup
2018-10-10 15:42:20 -04:00
Ameya Dharkar
0ab7b206a6 bgpd: Incorrect sent prefix count for a split subgroup
When a subgroup splits to form a new subgroup because of policy changes
for a peer, new subgroup copies adj out(state about advertised routes)
from the parent subgroup. At the same time, it should also copy
scount(advertised prefix count) to the new subgroup for the count to be
in sync with the adj_out for the subgroup.

Signed-off-by: Ameya Dharkar <adharkar@vmware.org>
2018-10-10 11:34:40 -07:00
Quentin Young
fa8875b922
Merge pull request #3155 from opensourcerouting/building_instructions
doc: update building instructions
2018-10-10 14:18:45 -04:00
Quentin Young
3f815a1ed1
Merge pull request #3159 from pguibert6WIND/doc_draft_bgp
doc: fix warning of doc compilation with bgp draft
2018-10-10 14:15:15 -04:00
Renato Westphal
e7fb64387c
Merge pull request #3154 from donaldsharp/bgp_mem_lem
Bgp mem issue with martian address interface strings
2018-10-10 13:08:28 -03:00
Renato Westphal
dde90f1e7c doc: simplify build instructions
Remove all --enable-xxx configuration flags for features that are enabled
by default.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Renato Westphal
345c140ec2 doc: update build instructions for Debian 9
The instruction to checkout to the stable/3.0 branch doesn't belong
here.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Renato Westphal
9580f50deb doc: remove LibXML from the list of dependencies
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Donald Sharp
8a7599cd27
Merge pull request #3145 from pguibert6WIND/ipv6nexthop
bgpd: in case nexthop is ipv6, set nh attribute flag in mpls vpn case
2018-10-10 10:08:01 -04:00
Philippe Guibert
75cd35c697 bgpd: in case nexthop is ipv6, set nh attribute flag in mpls vpn case
In mpls vpn import/export, the nexthop attribute should also be
recognised for ipv6 too.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-10 13:13:09 +02:00
Philippe Guibert
49606d5872 doc: fix warning of doc compilation with bgp draft
Some draft ietf are not handle by :rfc: keyword. A workaround is
proposed, like it has been done for flowspec.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-10 11:50:38 +02:00
Donald Sharp
b91299153d bgpd: Cleanup memory leak with the martian address intf string
When cleaning up a interface string, from the linked list we were
dropping the name pointer which held the allocated martian address
intf string.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 20:19:01 -04:00
Donald Sharp
330cec3de0 bgpd: Use a more appropriate memory type for a string
Track the memory type associated with the bartian address
interface a bit better, instead of using MTYPE_TMP.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 20:16:37 -04:00
Donald Sharp
121e245d4f bgpd: Cleanup warnings issued by CI system from these changes
Modify code to cleanup warnings issued by the CI system from
this series of changes.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:26:30 -04:00
Donald Sharp
40381db785 bgpd: Rename various variable names to something more appropriate
ri -> pi
bi -> bpi
info -> path
info -> rmap_path ( for routemap applications )

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:26:30 -04:00
Donald Sharp
9b6d8fcf29 bgpd: Convert binfo to path
Convert the binfo variable to path.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:26:30 -04:00
Donald Sharp
18ee831031 bgpd: Convert all bgp_info_XXX functions to bgp_path_XXX functions
Rename all bgp_info_XXX functions to bgp_path_XXX functions

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:14:25 -04:00
Donald Sharp
4b7e606625 bgpd: Convert struct bgp_info to struct bgp_path_info
Do a straight conversion of `struct bgp_info` to `struct bgp_path_info`.
This commit will setup the rename of variables as well.

This is being done because `struct bgp_info` is not descriptive
of what this data actually is.  It is path information for routes
that we keep to build the actual routes nexthops plus some extra
information.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:14:25 -04:00
Donald Sharp
1defdda8e8 bgpd: Convert BGP_INFO_XXX to BGP_PATH_XXX
Search and replace all BGP_INFO_XXX to BGP_PATH_XXX

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:14:25 -04:00
Donald Sharp
360660c643 bgpd: Rename some BGP_PATH_XXX to BGP_PATH_SHOW_XXX
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:14:25 -04:00
Olivier Dugeon
13894ce894
Merge pull request #3077 from rgirada/ospf_2980_fix
ospfd: Resolved the inconsistency behavior when “default-info origina…
2018-10-09 19:07:33 +02:00
Christian Franke
490a6fc716 isisd: don't add deprecated bfd command 2018-10-09 17:59:46 +02:00
Quentin Young
22bca40d60
Merge pull request #3037 from patrasar/2851
bgpd: remove ip prefix from as-path, <large,ext>community-list
2018-10-09 11:56:26 -04:00
Olivier Dugeon
c7aa8432f2
Merge pull request #3143 from rgirada/fix_3124
ospfd: default route got flushed after lsa refresh timer.
2018-10-09 17:52:49 +02:00
rgirada
1fb93326ad ospfd: issue with the "default-information originate always" command #2980
Made changes such that message wont be sent to zebra to validate default
route existence  if user configured with “always”.

Signed-off-by: rgirada <rgirada@vmware.com>
2018-10-09 02:52:27 -07:00
Quentin Young
3156b2d58d
Merge pull request #3132 from toreanderson/fix_routemap_prefixlist_match_doc
doc: correct route map match for prefix lists
2018-10-08 14:08:06 -04:00