proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-06-02 21:02:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
17,326 Commits 4 Branches 191 Tags 125 MiB
d7d158892a
Commit Graph

17326 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sri Mohana Singamsetty
c4cb0574d4
Merge pull request #5060 from chiragshah6/evpn_dev2 
zebra: fix evpn prefix-routes-only for default vrf
 2019-09-30 09:12:51 -07:00
Russ White
9898a2fb34
Merge pull request #5009 from donaldsharp/interface_deletion 
lib, zebra: Allow for interface deletion when kernel event happens
 2019-09-30 07:46:19 -04:00
Philippe Guibert
fbe49edb53 doc: add vty command information about brief usage 
brief keyword can be used along with vrf NAME or vrf all.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2019-09-30 09:35:05 +02:00
Mark Stapp
2fc69f03d2 zebra: during shutdown processing, drop dplane results 
Don't process dataplane results in zebra during shutdown (after
sigint has been seen). The dplane continues to run in order to
clean up, but zebra main just drops results.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-09-27 12:15:34 -04:00
Frank Villaro-Dixon
c5ced803ba docker/debian: Make docker images lighter and with less layers 
Signed-off-by: Frank Villaro-Dixon <frank.villaro@infomaniak.com>
 2019-09-27 15:05:08 +02:00
Donald Sharp
5c256b572c
Merge pull request #5066 from ak503/libfrr_crash 
zebra: if_is_loopback_or_vrf crash if if_lookup_by_index return NULL
 2019-09-26 19:32:41 -04:00
Donald Sharp
cb70bd5638
Merge pull request #5067 from ton31337/fix/no_aggregate-address_command_for_route-map 
bgpd: Accept no aggregate-address <IP> route-map <RMAP> commands
 2019-09-26 17:40:41 -04:00
Donald Sharp
961f406493
Merge pull request #5070 from ton31337/fix/aggregate-address_for_ipv6_summary-only_missreading 
bgpd: aggregate-address X:X::X:X/M summary-only was missreading config
 2019-09-26 17:39:09 -04:00
Donatas Abraitis
1e9f08953e
Merge pull request #5068 from donaldsharp/summary_only_is_not_a_route_map 
bgpd: aggregate-address A.B.C.D A.B.C.D summary-only was missreading …
 2019-09-26 21:53:50 +03:00
Donatas Abraitis
273fae13b2 bgpd: aggregate-address X:X::X:X/M summary-only was missreading config 
Entering:
aggregate-address 2a02:4780::/48 summary-only

Will transform this to:
aggregate-address 2a02:4780::/48 summary-only route-map summary-only

This patch fixes that.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2019-09-26 21:47:55 +03:00
Donald Sharp
cf40d0528e bgpd: aggregate-address A.B.C.D A.B.C.D summary-only was missreading config 
The `aggregate-address 30.0.5.0 255.255.255.0 summary-only` command
was missreading the inputed data and translating it into:

`aggregate-address 30.0.5.0/24 summary-only route-map summary-only`

This is not quite correct.  Fix this behavior:

donna.cumulusnetworks.com# conf
donna.cumulusnetworks.com(config)# router bgp
donna.cumulusnetworks.com(config-router)# aggregate-address 30.0.5.0 255.255.255.0 summary-only
donna.cumulusnetworks.com(config-router)# do show run
Building configuration...

Current configuration:
!
frr version 7.3-dev
frr defaults datacenter
hostname donna.cumulusnetworks.com
log file /var/log/frr/frr.log
no ipv6 forwarding
frr version 7.2-dev
!
router bgp 500
 neighbor 192.168.209.1 remote-as external
 neighbor 192.168.209.1 ebgp-multihop 255
 neighbor 192.168.210.1 remote-as external
 !
 address-family ipv4 unicast
  network 192.168.9.0/24
  network 192.168.10.0/24
  aggregate-address 30.0.5.0/24 summary-only
 exit-address-family
!

Issue: #5054
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-09-26 12:40:19 -04:00
Donatas Abraitis
b84da0db76 bgpd: Accept no aggregate-address <IP> route-map <RMAP> commands 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2019-09-26 17:35:25 +03:00
dturlupov
873fde8cd9 zebra: if_is_loopback_or_vrf crash if if_lookup_by_index return NULL 
Function if_lookup_by_index() can return NULL, but in if_is_loopback_or_vrf() we don't chech NULL and get next:

Sep 2 07:44:34 XXX zebra[4616]: /usr/lib64/libfrr.so.0(zlog_backtrace_sigsafe+0x48) [0x7fb5f704cf18]
Sep 2 07:44:34 XXX zebra[4616]: /usr/lib64/libfrr.so.0(zlog_signal+0x378) [0x7fb5f704d728]
Sep 2 07:44:34 XXX zebra[4616]: /usr/lib64/libfrr.so.0(+0x6b495) [0x7fb5f706b495]
Sep 2 07:44:34 XXX zebra[4616]: /lib64/libpthread.so.0(+0x123b0) [0x7fb5f6d573b0]
Sep 2 07:44:34 XXX zebra[4616]: /usr/lib64/libfrr.so.0(if_is_loopback+0) [0x7fb5f7045160]
Sep 2 07:44:34 XXX zebra[4616]: /usr/lib64/libfrr.so.0(if_is_loopback_or_vrf+0x11) [0x7fb5f7045191]
Sep 2 07:44:34 XXX zebra[4616]: /usr/sbin/zebra() [0x43b26d]
Sep 2 07:44:34 XXX zebra[4616]: /usr/sbin/zebra() [0x43db6f]
Sep 2 07:44:34 XXX zebra[4616]: /usr/lib64/libfrr.so.0(work_queue_run+0xc8) [0x7fb5f7080de8]
Sep 2 07:44:34 XXX zebra[4616]: /usr/lib64/libfrr.so.0(thread_call+0x47) [0x7fb5f7077d27]
Sep 2 07:44:34 XXX zebra[4616]: /usr/lib64/libfrr.so.0(frr_run+0xd8) [0x7fb5f704b448]

Signed-off-by: Dmitrii Turlupov dturlupov@factor-ts.ru
 2019-09-26 16:11:50 +03:00
Donald Sharp
e23af21a44
Merge pull request #5062 from kuldeepkash/route_map 
Add bgp route-map test cases
 2019-09-26 09:05:57 -04:00
Kuldeep Kashyap
468b867f4f tests: Add bgp route-map test cases 
Adding 27 bgp route-map test cases to test multiple route-map scenarios

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2019-09-26 10:06:16 +00:00
Kuldeep Kashyap
8aa6292547 tests: Add API to shut/noshut router interface 
This API would help to shut/nohut specified router interfaces

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2019-09-26 10:06:16 +00:00
Kuldeep Kashyap
21a51c4d0f tests: Adding verification APIs for bgp route-maps and community-lists 
APIs to verify bgp route-maps, bgp community and large community configurations

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2019-09-26 10:06:16 +00:00
Kuldeep Kashyap
380bb6d16b tests: Enhance support to create bgp community-list or large-community-list 
Adding new API to create bgp community-list or large-community-list

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2019-09-26 10:06:16 +00:00
Kuldeep Kashyap
89f86e8c7b tests: Enhance framework to create and delete route-map 
Added APIs to create and delete route-maps configuration

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2019-09-26 10:06:16 +00:00
Kuldeep Kashyap
9920237e4f tests: Add route-map to initial config creation from JSON 
To enable route-map config build from JSON

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2019-09-26 10:06:16 +00:00
Kuldeep Kashyap
7f55cb6a88 tests: Adding API verify_bgp_attributes() to bgp.py 
This API is to verify BGP attribute values set by route maps

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2019-09-26 10:06:16 +00:00
Donatas Abraitis
5300176ff8
Merge pull request #5047 from dslicenc/bgp-next-hop-routemap 
bgpd: stop sending nexthop set by "route-map in" to eBGP peers
 2019-09-26 11:17:51 +03:00
Don Slice
1c875ddb57 bgpd: stop sending nexthop set by "route-map in" to eBGP peers 
Problem reported that when a "neighbor x.x.x.x route-map FOO in"
set a next-hop value, that modified next-hop value was also sent
to eBGP peers.  This is incorrect since bgp is expected to set
next-hop to self when sending to eBGP peers unless third party
next-hop on a shared segment is true.  This fix modifies the
behavior to stop sending the modified next-hop to eBGP peers
if the route-map was applied inbound on another peer.

Ticket: CM-26025
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
 2019-09-25 13:54:39 -07:00
Donald Sharp
7e933bc159
Merge pull request #5058 from mjstapp/fix_dplane_config_handler 
zebra: handle config write for dataplane values
 2019-09-25 16:47:47 -04:00
Donald Sharp
75a5d867a1
Merge pull request #5051 from idryzhov/fix-vrf-autocomplete 
*: fix missing VRF autocompletions
 2019-09-25 15:27:55 -04:00
Chirag Shah
8d0f01f10e zebra: fix evpn prefix-routes-only for default vrf 
asymmetric routing default vrf vni configuration
is not displayed as part of running-config.

Ticket:CM-26470
Reviewed By:
Testing Done:

T11# config t
T11(config)# vni 4004 prefix-routes-only
T11(config)# end

Before:

T11# show running-config
...
vni 4004
...

After:

T11# show running-config
...
vni 4004 prefix-routes-only
...

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2019-09-25 12:11:09 -07:00
Mark Stapp
f26730e17e zebra: handle config write for dataplane values 
Add the (single) dataplane config value to the output of
config write, 'show run' - missed this during dplane development.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-09-25 14:05:50 -04:00
Mark Stapp
8dd3950095
Merge pull request #5053 from donaldsharp/more_sa_stuff_this_evening 
More sa stuff this evening
 2019-09-25 11:23:49 -04:00
Mark Stapp
dd38ed3502
Merge pull request #5055 from pguibert6WIND/fix_memory_leak_with_delete_interface 
zebra: fix memory leak
 2019-09-25 10:03:26 -04:00
Donald Sharp
59aa96313a
Merge pull request #5052 from mjstapp/zebra_yang_model 
libs: add yang models for zebra and nexthop
 2019-09-25 09:27:57 -04:00
Donald Sharp
24cbd13098 pimd: up->channel_oil cannot be NULL 
When we create the up data structure we create the channel_oil
as well.  As such it is impossible to get into this code
so it can be removed.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-09-25 09:26:24 -04:00
Donald Sharp
38513e880e eigrpd: On creation of socket ensure vrf exists 
If the vrf does not exist, politely do not create
the socket.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-09-25 09:26:24 -04:00
Donald Sharp
0f9f74baeb ospf6d: Prevent use after free 
the for (ALL_LSDB...) macro was iterating over lsa,
when lsa had just been freed in these functions.
Remove the macro and make the adjustments saving lsa_next
before the free.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-09-25 09:26:24 -04:00
Donald Sharp
b53c5f1ab4 isisd: circuit is derefed in every code path 
No need to check for circuit being null, we have
already de-refed it in every code path and
would have crashed before this point if it was.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-09-25 09:22:52 -04:00
Donatas Abraitis
8396ec6717
Merge pull request #5036 from indigo423/issue/5035 
build: Fix Docker based Alpine build
 2019-09-25 10:02:31 +03:00
Philippe Guibert
fc341a9791 zebra: fix memory leak 
the if_lookup_by_name_per_ns keeps a lock on the node where the
searched ifp is stored. Then this node can not be freed even if
the ifp is removed from the node. Just add the missing unlock
(as for the if_lookup_by_index_per_ns lookup function)

Fixes: b8af3fbbaf ("zebra: fix detection of interface renames")
Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2019-09-25 08:51:06 +02:00
Mark Stapp
fdd5c6e855 libs: add yang models for zebra and nexthop 
Add a yang model for some of zebra's functionality,
but the model is not integrated into the build at all yet. Also
add a model for nexthop and nexthop-group.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-09-24 16:31:12 -04:00
Donald Sharp
0cddbb1b6c
Merge pull request #5050 from LabNConsulting/working/lb/tt-update 
topotest: bgp_l3vpn_to_bgp_vrf allow for different interface output
 2019-09-24 16:07:35 -04:00
Donald Sharp
17a8a5beec
Merge pull request #4972 from mjstapp/fix_notif_installed 
zebra: route updates from dataplane need to check all nexthops
 2019-09-24 14:31:58 -04:00
Donald Sharp
ad39295aaf
Merge pull request #5040 from opensourcerouting/isisd-fix-validation-crash 
isisd: fix crash during candidate validation
 2019-09-24 14:14:56 -04:00
Igor Ryzhov
e429a2a0cc *: fix missing VRF autocompletions 
Current autocompletion works only for simple "vrf NAME" case.

This commit expands it also for the following cases:
- "nexthop-vrf NAME" in staticd
- usage of $varname in many daemons

All daemons are updated to use single varname "$vrf_name".

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2019-09-24 19:51:46 +03:00
Russ White
8db933928f
Merge pull request #4959 from pguibert6WIND/zebra_inform_layer 
zebra: inform upper layer error when reading correct speed interface
 2019-09-24 11:46:13 -04:00
Russ White
a7f5a058e2
Merge pull request #4822 from vishaldhingra/route_agg 
bgpd : route aggregation optimisation
 2019-09-24 11:40:01 -04:00
Russ White
a56cb091fa
Merge pull request #5044 from chiragshah6/evpn_dev2 
bgpd: fix advertise-svi-ip upon vni-svi up-down
 2019-09-24 10:45:56 -04:00
Russ White
5ed07cdfc8
Merge pull request #5045 from satheeshkarra/pim_tos 
pimd: Mark Default TOS Values for PIM & IGMP Outgoing packets
 2019-09-24 10:44:01 -04:00
Russ White
e4bf00fdf9
Merge pull request #4995 from opensourcerouting/ospf6d-iftype 
ospf6d: fix interface type handling
 2019-09-24 10:38:10 -04:00
Donatas Abraitis
bdd0ce8aa5
Merge pull request #5046 from donaldsharp/sa_issues_found 
Sa issues found
 2019-09-24 17:22:46 +03:00
Donald Sharp
a3116965bb bgpd: rmap_type is 8 bit but we have 9 bits of flags 
The newly added PEER_RMAP_TYPE_AGGREGATE flag is setup to
be the 9th bit:

But the flag we are putting it into:
uint8_t rmap_type;

is 8 bits.  Adjust the size.

Found by Coverity SA Scan
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-09-24 08:29:46 -04:00
Donald Sharp
4550d5df00 pbrd: We should be looking for v4 and v6 nexthop types 
The code should be looking for both v4 and v6 nexthop types
instead of v4 nexthop types 2 times.

Found by Coverity SA
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-09-24 08:20:34 -04:00
Donald Sharp
d3fc71f304
Merge pull request #4912 from lucize/carescross 
clippy: don't fail on CARES and libcap when clippy-only selected
 2019-09-24 08:14:45 -04:00