Rafael Zalamena
d532d1092e
Merge pull request #8644 from idryzhov/fix-vrf-bind
...
lib: fix binding to a vrf
2021-06-02 10:47:10 -03:00
Rafael Zalamena
bb117f0446
Merge pull request #8777 from ton31337/fix/doc_topotests
...
doc: Replace single tick with double tick under developer/topotests.rst
2021-06-02 10:04:43 -03:00
Donatas Abraitis
6ab47b0396
doc: Replace single tick with double tick under developer/topotests.rst
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-02 08:48:25 +03:00
Donald Sharp
9dddf5fe69
Merge pull request #8759 from idryzhov/ospf6-vrf-fix
...
ospf6d: fix using vrf interface as a loopback
2021-06-01 16:31:26 -04:00
Donald Sharp
8a31e38fef
Merge pull request #8761 from idryzhov/fix-isis-vrf
...
isisd: fix using vrf interface as a loopback
2021-06-01 16:26:56 -04:00
Rafael Zalamena
06e4c62631
Merge pull request #8765 from idryzhov/bfd-vrf
...
isisd, ospf6d, pimd: set vrf_id when creating bfd sessions
2021-06-01 17:15:06 -03:00
Quentin Young
c99313762a
Merge pull request #8353 from opensourcerouting/llvm-20210327
2021-06-01 19:08:32 +00:00
Donald Sharp
465d4a6c5b
Merge pull request #8304 from mjstapp/fix_zmq_xref
...
lib: fix use of xrefs in zmq wrapper
2021-06-01 13:59:51 -04:00
Mark Stapp
88faaee986
Merge pull request #8762 from idryzhov/pcep-coverity
...
pceplib: fix mixup of global/local variables
2021-06-01 13:27:49 -04:00
Emanuele Di Pascale
ec957bbc2a
pathd: fix render candidate-path bandwidth
...
the config for dynamic candidate paths with bandwidth preferences
was using a different order of keywords (required bandwidth X) than
the corresponding command (bandwidth X required). This confuses
frr-reload, and possibly users too. Make both use the same order.
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2021-06-01 19:19:05 +02:00
Mark Stapp
2030df4d30
Merge pull request #8748 from idryzhov/ospf6-vrf-unlink
...
ospf6d: unlink router from vrf on deletion
2021-06-01 12:06:08 -04:00
Russ White
3d7bd27619
Merge pull request #8683 from kuldeepkash/bgp_gshut
...
tests: Add bgp_gshut_topo1 test suite
2021-06-01 11:43:48 -04:00
Christian Hopps
b680134e11
lib: fix threading bug in GRPC code
...
The code that actually calls FRR northbound functions needs to be running in the
master thread. The previous code was running on a GRPC pthread. While fixing
moved to more functional vs OOP to make this easier to see.
Also fix ly merge to merge siblings not throw the originals away.
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-01 15:27:54 +00:00
Igor Ryzhov
874ca76997
bfdd: forbid setting interface for multihop sessions
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-01 18:08:29 +03:00
Igor Ryzhov
edc3622d82
bfdd: don't store interface pointer for multihop sessions
...
It breaks "neighbor A.B.C.D update-source" config in BGP.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-01 18:08:29 +03:00
Igor Ryzhov
7bb5c50c83
lib: fix default ttl for single-hop bfd sessions
...
The TTL field is actually the number of hops, not a TTL.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-01 18:08:29 +03:00
Igor Ryzhov
b6c87c3576
lib: fix bfd multihop
...
Never send an interface name/index for multihop sessions. It breaks
"neighbor A.B.C.D update-source" config in BGP.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-01 18:07:54 +03:00
Igor Ryzhov
edc0d8cf49
bgpd: fix enabling bfd debug
...
When enabling bfd debug from the enable mode, library debugging is not
enabled.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-01 18:07:54 +03:00
Igor Ryzhov
8c965eaaf4
Merge pull request #8769 from ton31337/fix/time_to_remove
...
lib: Time to remove CONFDATE block
2021-06-01 17:45:25 +03:00
Donatas Abraitis
ef3b48cfe1
lib: Time to remove CONFDATE block
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-01 12:33:43 +03:00
Donatas Abraitis
2cdd73387c
Merge pull request #8698 from donaldsharp/pim_black_tests
...
tests: Fixup some pylint warnings in test_multicast_pim_sm_topo2.py
2021-06-01 09:41:04 +03:00
Rafael Zalamena
710da500a6
Merge pull request #8768 from idryzhov/doc-index
...
doc: fix redundant index once again
2021-05-31 16:54:41 -03:00
Igor Ryzhov
75b8d48236
doc: update VRF support description
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-31 22:12:55 +03:00
Igor Ryzhov
60070c3d02
tests: remove tcp_l3mdev_accept setting
...
This is not necessary anymore with fixed `vrf_bind`.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-31 22:12:55 +03:00
Igor Ryzhov
36eef8586d
lib: fix binding to a vrf
...
There are two possible use-cases for the `vrf_bind` function:
- bind socket to an interface in a vrf
- bind socket to a vrf device
For the former case, there's one problem - success is returned when the
interface is not found. In that case, the socket is left unbound without
throwing an error.
For the latter case, there are multiple possible problems:
- If the name is not set, then the socket is left unbound (zebra, vrrp).
- If the name is "default" and there's an interface with that name in the
default VRF, then the socket is bound to that interface.
- In most daemons, if the router is configured before the VRF is actually
created, we're trying to open and bind the socket right after the
daemon receives a VRF registration from zebra. We may not receive the
VRF-interface registration from zebra yet at that point. Therefore,
`if_lookup_by_name` fails, and the socket is left unbound.
This commit fixes all the issues and updates the function description.
Suggested-by: Pat Ruddy <pat@voltanet.io>
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-31 22:12:55 +03:00
Igor Ryzhov
676847384b
bgpd: pass correct vrf_id to vrf_socket when creating bgp view socket
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-31 22:12:55 +03:00
Igor Ryzhov
7f9f613125
doc: fix redundant index once again
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-31 18:29:34 +03:00
Igor Ryzhov
63262607c1
isisd, ospf6d, pimd: set vrf_id when creating bfd sessions
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-31 15:04:13 +03:00
Rafael Zalamena
6c1a2a6538
Merge pull request #6317 from rgirada/fix_route_dump
...
zebrad: Added a command to dump routes in support bundle
2021-05-28 18:12:17 -03:00
Igor Ryzhov
32fe990571
Merge pull request #8752 from pjdruddy/ospf6-route-mem-leak
...
ospf6: fix memory leak in ospf6_abr_examin_summary
2021-05-28 20:43:07 +03:00
Igor Ryzhov
694f0671c5
pceplib: fix mixup of global/local variables
...
CID 1502790
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-28 20:39:37 +03:00
Igor Ryzhov
a80618f27d
isisd: fix using vrf interface as a loopback
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-28 18:45:40 +03:00
Igor Ryzhov
d16cff32b2
ospf6d: fix using vrf interface as a loopback
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-28 16:14:34 +03:00
Igor Ryzhov
bf59f4ad20
Merge pull request #8740 from mjstapp/fix_static_ret
...
staticd: return meaningful status in cli error path
2021-05-28 11:35:43 +03:00
David Lamparter
525ec2e073
Merge pull request #8747 from LabNConsulting/chopps/improve-grpc-req-checks
...
grpc: improve checks for GRPC C++ requirements
2021-05-27 20:50:17 +02:00
Stephen Worley
7d4651cc9c
Merge pull request #8174 from mjstapp/backup_nht
...
zebra: hide backup-nexthop activations in nht
2021-05-27 09:49:41 -04:00
Lou Berger
baa54d9324
Merge pull request #8753 from idryzhov/fix-labn-ci
...
Fix LabN CI
2021-05-27 09:45:52 -04:00
Mark Stapp
f419424174
staticd: return SUCCESS when deleting non-existent route
...
Return SUCCESS if trying to delete route that doesn't exist.
This was always staticd's behavior before the northbound
conversion.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-05-27 09:01:43 -04:00
Igor Ryzhov
4b57e2c4f5
docker: fix ubuntu containers
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-27 15:57:03 +03:00
Igor Ryzhov
bea8786a1c
Revert "build: libyangv2 is mainlined, update"
...
This partially reverts commit 250335d47c
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-27 15:56:06 +03:00
Christian Hopps
b256a06b22
grpc: improve checks for GRPC C++ requirements
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-05-27 12:04:33 +00:00
Pat Ruddy
de4a0bdaa6
ospf6: fix memory leak in ospf6_abr_examin_summary
...
Ensure that if allocated route is not added to a table then it is
deleted to avoid leaking memory.
Add a new memory type for route table so that ospf6 routes can be
distinguished in the show memory output in isolation.
Signed-off-by: Pat Ruddy <pat@voltanet.io>
2021-05-27 12:57:25 +01:00
Igor Ryzhov
92699b9bbe
ospf6d: unlink router from vrf on deletion
...
Otherwise `ospf6_lookup_by_vrf_id` returns stale pointer.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-27 14:39:28 +03:00
Igor Ryzhov
67bde476b5
Merge pull request #8751 from LabNConsulting/chopps/ly2-mainline
...
build: libyangv2 is mainlined, update
2021-05-27 14:34:26 +03:00
Donatas Abraitis
b8fd5ba1d7
Merge pull request #8679 from louis-oui/bgp-summary-filter
...
bgpd: add show bgp summary filter by neighbor or AS
2021-05-27 13:57:14 +03:00
Christian Hopps
250335d47c
build: libyangv2 is mainlined, update
...
Signed-off-by: Christian Hopps <chopps@gmail.com>
2021-05-27 06:44:39 -04:00
Igor Ryzhov
6e33da3839
Merge pull request #8738 from gromit1811/bugfix_ospf6_set_tag
...
ospf6d: Fix route map "set tag" command
2021-05-27 10:07:13 +03:00
Quentin Young
f4db21a5fb
Merge pull request #8707 from LabNConsulting/chopps/improve-grpc-req-checks
2021-05-26 20:11:53 +00:00
Rafael Zalamena
12a52d5551
Merge pull request #8736 from idryzhov/fix-ospf6-debug
...
ospf6d: fix debug message issues
2021-05-26 15:25:08 -03:00
Mark Stapp
1c8fe10c98
Merge pull request #8732 from idryzhov/fix-ospf6d-crashes
...
ospf6d: fix possible crashes
2021-05-26 11:32:33 -04:00