David Lamparter
99f226f8dc
Merge pull request #524 from qlyoung/blublublub3.0
...
lib: use %p specifier for pointers
2017-05-13 09:08:55 +02:00
Quentin Young
61de994bcf
tools: $valgrind --> "$valgrind"
...
String cmp missing quotes
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-12 23:29:58 +00:00
Quentin Young
ab87c0f350
lib: use %p specifier for pointers
...
Fixes builds on ARM
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-12 21:57:30 +00:00
Vincent JARDIN
c5221d2f48
README: add references to EIGRP and NHRP.
2017-05-12 22:51:45 +02:00
Renato Westphal
51cd5cc35e
Merge pull request #518 from dwalton76/zebra-mpls-lsp-uninstall
...
zebra: zebra_mpls_lsp_uninstall was not being called
2017-05-12 12:51:06 -03:00
Renato Westphal
05910d5938
Merge pull request #495 from donaldsharp/mpls_fixes
...
Mpls fixes
2017-05-12 12:23:52 -03:00
Renato Westphal
7c7f4284cf
bgpd: fix segfault with '[no] bgp network import-check'
...
These commands were causing bgpd to crash if a static VPN route was
configured.
While here, fix a bug in bgp_static_add() and bgp_static_delete().
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 12:03:53 -03:00
Renato Westphal
92a8bd6e7a
bgpd: fix duplicate install of command
...
Only happens when FRR is configured with --enable-oldvpn-commands.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 12:02:24 -03:00
Renato Westphal
ff59521466
bgpd: fix 'show bgp [...] longer-prefixes'
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 11:58:37 -03:00
Renato Westphal
3eefc73454
bgpd: remove unused bgp_attr_default_intern() function
...
This function is not used anymore since commit 137446f9
.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 11:48:02 -03:00
Renato Westphal
17c7bb7b1c
lib: remove gap between AFI_IP6 and AFI_L2VPN
...
We have several pieces of code like this in FRR:
for (afi = AFI_IP; afi < AFI_MAX; afi++)
for (safi = SAFI_UNICAST; safi < SAFI_MAX; safi++)
bgp_distance_table[afi][safi] = bgp_table_init (afi, safi);
We were creating a lot of useless garbage in the code because of this
gap. Fix this.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 11:48:02 -03:00
Renato Westphal
8b89a3023f
bgpd: fix segfault with '[no] bgp network import-check'
...
These commands were causing bgpd to crash if a static VPN route was
configured.
While here, fix a bug in bgp_static_add() and bgp_static_delete().
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 11:48:02 -03:00
Renato Westphal
af5d681978
bgpd: fix duplicate install of command
...
Only happens when FRR is configured with --enable-oldvpn-commands.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 11:48:02 -03:00
Renato Westphal
9ff63e6f55
bgpd: removed unused parameter from bgp_dump_attr()
...
Originally we used the 'peer' parameter for this:
if (peer_sort (peer) == BGP_PEER_IBGP)
snprintf (buf + strlen (buf), size - strlen (buf), ", localpref %d",
attr->local_pref);
Now we have this:
if (CHECK_FLAG (attr->flag, ATTR_FLAG_BIT (BGP_ATTR_LOCAL_PREF)))
snprintf (buf + strlen (buf), size - strlen (buf), ", localpref %u",
attr->local_pref);
Remove the now useless 'peer' parameter.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 11:48:02 -03:00
Renato Westphal
5143a87b92
lib: add labeled-unicast in safi2str()
...
While here, move SAFI_ENCAP above SAFI_MPLS_VPN to keep the ordering
consistent.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 11:46:26 -03:00
Renato Westphal
83540e9861
bgpd: fix 'show bgp [...] longer-prefixes'
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-12 11:43:32 -03:00
Daniel Walton
71e04b9f7c
zebra: zebra_mpls_lsp_uninstall was not being called
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Old entries were not being removed from the MPLS table.
2017-05-12 13:34:51 +00:00
Jafar Al-Gharaibeh
a153bd94bc
Merge pull request #511 from donaldsharp/netlink_dump
...
zebra: Fix kernel netlink hex dump of information
2017-05-11 22:47:22 -05:00
ßingen
5c7ef8dc4f
lm: Make relay label manager async
...
To avoid blocking zebra when it's acting as a proxy for an external
label manager.
Besides:
Fix get chunk reconnection. Socket was still being destroyed on failure,
so next attempt would never work.
Filter out unwanted messages in lm sync sock.
Until LDE client sends ZEBRA_LABEL_MANAGER_CONNECT message, zserv
doesn't know which kind of client it is, so it might enqueue unwanted
messages like interface add, interface up, etc. Changes in this commit
discard those messages in the client side in case they arrive before the
expected response.
Change function name for zclient_connect in label manager to avoid
confusion with zclient one.
Signed-off-by: ßingen <bingen@voltanet.io>
2017-05-11 19:20:08 +02:00
Donald Sharp
64a4bd09f0
zebra: Fix kernel netlink hex dump of information
...
1) Fix the kernel send and recv hex dump of what we
are sending to the kernel
2) When configuring the debugs under 'conf t' display
it too.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-11 11:44:07 -04:00
Donald Sharp
5867082298
Merge pull request #510 from opensourcerouting/update-tools-gitignore
...
tools: update .gitignore
2017-05-11 09:19:15 -04:00
Christian Franke
e67d443ba1
tools: update .gitignore
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-05-11 15:15:52 +02:00
Lou Berger
cefd435b19
bgpd: Issue #198 - clean up duplicate command resulting from CLI refactoring
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-11 08:47:18 -04:00
Philippe Guibert
42025b43f2
bgpd: fixup bgpd: allow VPN next hop to be different AFI than NLRI next
...
hop for EVPN
In the case of EVPN, add the nexthop attribute.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2017-05-11 08:24:38 -04:00
Adam Fitzgerald
86fb2ae841
added troubleshooting section to debian 8 build doc
2017-05-11 08:24:10 -04:00
Donald Sharp
291012893e
Merge pull request #505 from adamfitz/stable/2.0
...
added troubleshooting section to debian 8 build doc
2017-05-11 08:20:08 -04:00
Lou Berger
be4a57d110
Merge pull request #503 from pguibert6WIND/issue_473
...
bgpd: fixup bgpd: allow VPN next hop to be different AFI than NLRI nexthop for EVPN
2017-05-11 08:14:33 -04:00
David Lamparter
9e0ceb07a3
Merge pull request #500 from qlyoung/fix-router-rip-3.0-3.0
...
vtysh: add \n to 'router rip[ng]' docstrings (3.0)
2017-05-11 13:58:40 +02:00
David Lamparter
11767391c5
Merge pull request #496 from donaldsharp/vtysh_pager
...
*: Allow configure to control VTYSH_PAGER used
2017-05-11 13:57:45 +02:00
Adam Fitzgerald
818c4f214a
added troubleshooting section to debian 8 build doc
2017-05-11 21:03:23 +10:00
Donald Sharp
19255fd020
Merge pull request #502 from opensourcerouting/show-ip-fib
...
add 'show <ip|ipv6> fib' command
2017-05-10 19:39:26 -04:00
Christian Franke
4d345ab695
zebra: add 'show ipv6 fib' command
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-05-11 00:31:57 +02:00
Christian Franke
87a8896290
zebra: add 'show ip fib' commands
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-05-11 00:31:57 +02:00
Hung-Weic Chiu
c16b6d31ed
Address the error "Dead assignment" of static analysif
...
- Refer to https://ci1.netdef.org/browse/FRR-FRR4-44/artifact/shared/static_analysis/index.html
- Remove unused variable
Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-05-10 16:02:48 -04:00
Hung-Weic Chiu
9bc221113c
- Solve the Coverity Scan PW.ASSIGN_WHERE_COMPARE_MEANT
...
- Minor refactoring
Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-05-10 16:02:48 -04:00
Quentin Young
6500e013db
vtysh: add \n to 'router rip[ng]' docstrings
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-10 19:49:18 +00:00
Hung-Weic Chiu
4afc1b4d4b
Address the error "Dead assignment" of static analysif
...
- Refer to https://ci1.netdef.org/browse/FRR-FRR4-44/artifact/shared/static_analysis/index.html
- Remove unused variable
Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-05-10 15:46:24 -04:00
Hung-Weic Chiu
bb1e60c3a1
- Solve the Coverity Scan PW.ASSIGN_WHERE_COMPARE_MEANT
...
- Minor refactoring
Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-05-10 15:46:24 -04:00
Russ White
00a1578051
Merge pull request #408 from qlyoung/remove-thread-macros
...
*: remove THREAD_ON macros, add nullity check
2017-05-10 13:51:47 -04:00
Philippe Guibert
01e68ed8a8
bgpd: fixup bgpd: allow VPN next hop to be different AFI than NLRI next
...
hop for EVPN
In the case of EVPN, add the nexthop attribute.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2017-05-10 19:27:33 +02:00
Donald Sharp
08c369bda9
*: Allow configure to control VTYSH_PAGER used
...
Signed-off-by: Donald Sharp
2017-05-10 11:16:26 -04:00
Daniel Walton
c68d0348d5
eigrpd: Fix compilation errors for some versions of gcc
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-05-10 10:06:47 -04:00
Daniel Walton
33c3228272
zebra: do not crash if zebrad.lsp_process_q is NULL
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-05-10 10:06:47 -04:00
Daniel Walton
4caac24b23
zebra: lsp_install() failed due to ZEBRA_FLAG_SELECTED check
...
ZEBRA_FLAG_SELECTED hasn't been set yet by the time lsp_install is
called. The call path is:
rib_process -> rib_process_add_fib -> zebra_mpls_lsp_install -> lsp_install
but ZEBRA_FLAG_SELECTED is set in rib_process after it calls
rib_process_add_fib. I can't think of anything that it would hurt to
install the LSP regardless of whether ZEBRA_FLAG_SELECTED is set later.
I also cleaned up some UI (json and display the pretty label names
instead of their numeric values).
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-05-10 10:06:47 -04:00
Daniel Walton
b5ab78e691
zebra: ZEBRA_MIN_FEC_LENGTH should be 5
...
If the client registers for 0.0.0.0/0 the length will be 5
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-05-10 10:06:47 -04:00
Daniel Walton
343e90c328
bgpd: add ENHE support for "address-family ipv4 labeled-unicast"
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-05-10 10:06:47 -04:00
Jafar Al-Gharaibeh
0896b75508
Merge pull request #494 from donaldsharp/community.md
...
*: Modify documentation to show people where to work
2017-05-10 08:57:41 -05:00
Donald Sharp
e0ba80e274
*: Modify documentation to show people where to work
...
Give some guidance to people on where they should work for
bug fixese and features.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-10 08:13:17 -04:00
Daniel Walton
9bcb88c7bf
Change Frr.conf to frr.conf
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-05-10 00:55:10 +00:00
Donald Sharp
a1b4f854b0
Merge remote-tracking branch 'origin/stable/3.0'
2017-05-09 20:39:35 -04:00