Lou Berger
11f3bfdd71
Merge pull request #930 from qlyoung/fix-masters-list-reachable
...
lib: fix still reachable linked list in thread.c
2017-08-08 13:58:06 -04:00
Donald Sharp
76a8685418
Merge pull request #920 from opensourcerouting/static-routes-ifindex-update-3.0
...
[3.0] fixup static routes' ifindexes when interfaces (dis)appear
2017-08-08 13:39:38 -04:00
Donald Sharp
d3d9c86f54
Merge pull request #919 from opensourcerouting/static-routes-ifindex-update
...
fixup static routes' ifindexes when interfaces (dis)appear
2017-08-08 13:39:19 -04:00
Donald Sharp
0f6476ccc3
lib, bgpd: Use 'struct prefix *' for filter matching
...
There is no need for special casing of mac addresses,
since the mac address is it's own type integrated
into `struct prefix` now.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 12:55:03 -04:00
Quentin Young
eff09c66a4
lib: fix still reachable linked list in thread.c
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-08 12:54:28 -04:00
Donald Sharp
b03b88986e
lib, bgpd: Distinguish between AF_EVPN and AF_ETHERNET
...
Create AF_EVPN for internal use and start using it.
Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
2017-08-08 10:34:31 -04:00
Donald Sharp
b34fd35d3a
lib, bgpd: Address Review comments.
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 10:30:14 -04:00
Donald Sharp
a85b24cc7f
bgpd: Use JSON_STR
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 10:30:13 -04:00
Donald Sharp
6d53d24c86
ldpd: Use JSON_STR
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 10:30:13 -04:00
Donald Sharp
bd592158ef
zebra: Use JSON_STR
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 10:30:13 -04:00
Donald Sharp
1667fc4097
lib: Fix extra doc string
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 10:30:13 -04:00
Mitesh Kanjariya
646050e57a
bgp: fix match mac address/match evpn vni commands
...
Ticket: CM-17071
Review: CCR-6454
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:30:13 -04:00
Mitesh Kanjariya
69b61704b8
lib: changes needed for mac access-list any command
...
Ticket: CM-17074
Review: CCR-6453
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:28:55 -04:00
Mitesh Kanjariya
297a21b66b
zebra: zebra should not try and advertise gateway macip if EVPN is disabled
...
Ticket: CM-17050
Review: CCR-6447
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:28:54 -04:00
Mitesh Kanjariya
2f1ac16a7e
bgpd: BGP should not ignore the VNI add notification if it is not live currently
...
Ticket: CM-17053
Review: CCR-6446
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:28:54 -04:00
Donald Sharp
bd7d02999f
zebra: Guard debugs in interface speed check
...
Not being able to get the interface speed is a common
occurrence for some interface types. Convert this
these outputs to a guarded debug.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 10:28:54 -04:00
Donald Sharp
4192df64c9
bgpd: Fix output of interface based 'show bgp ..' commands
...
When issuing a 'show ip bgp' command and the nexthop is
a interface, if the interface name was greater than 7 characters
we would arbitrarily start a new-line and setup the next
line to start at the wrong spot.
Modify the interface field to allow 16 characters than 7( to
match v6 display ), and if the interface name is greater than
16 characters properly setup the next line for display
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 10:28:54 -04:00
Daniel Walton
8a89316378
bgpd: show bgp ipv4 label-unicast does not provide any output
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Ticket: CM-16957
2017-08-08 10:28:54 -04:00
Mitesh Kanjariya
ddd16ed5f2
bgpd/zebra: honor tunnel ip change in bgp regardless of vni readiness
...
Ticket: CM-17014
Review: CCR-6432
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:28:54 -04:00
Mitesh Kanjariya
b6938a74e5
zebra: Provide neigh-mac tie-in in zebra
...
Currently, FRR does not do any linking between local MACs and neighbors.
We found this necessary when dealing with centralized GW. A neigh is considered local only when the mac is learnt locally as well.
Ticket: CM-16544
Review: CCR-6388
Unit-test: Manual/Evpn-Smoke
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:28:51 -04:00
Daniel Walton
640751c7ac
EVPN: Indentation is off for route-target export
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Ticket: CM-16967
2017-08-08 10:28:51 -04:00
Mitesh Kanjariya
5bc2ed52f0
bgpd: fix crash while configuring rt
...
Ticket: CM-16410
Review: CCR-6409
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:28:51 -04:00
Chirag Shah
cd23307906
zebra: Enable JSON for EVPN show cmds
...
Ticket: CM-16959
Reviewed By: CCR-6401
Testing Done:
Execute 'show evpn .... json' form of outputs with local/remote vteps
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-08-08 10:28:50 -04:00
Donald Sharp
9b67b51474
zebra: Fix some memory leaks on shutdown
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 10:28:50 -04:00
Daniel Walton
5014d96f0f
bgpd, tools, vtysh: Handle config migration from 'address-family evpn' to 'address-family l2vpn evpn'
...
Ticket: CM-16747
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-08 10:28:50 -04:00
Mitesh Kanjariya
1a98c08704
bgpd/zebra/lib: EVPN support for asymmetric VxLan routing
...
1. Advertise gateway mac-ip in EVPN
2. Advertise VRR mac-ip in EVPN
3. Ignore gateway mac-ip advertisements in case of distributed gateway
4. Config knob to enable/disable gateway mac-ip advertisements
Ticket: CM-16456, CM-16543, CM-16555, CM-16778
Review: CCR-6283
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:28:46 -04:00
David Lamparter
d178328163
Merge pull request #927 from donaldsharp/one_day_second
...
*: Define the number of seconds in a Day, Week and year
2017-08-08 16:19:29 +02:00
Mitesh Kanjariya
8f4b98eedb
zebra: fix mac mobility code path
...
Ticket: CM-16928
Review: CCR-6210
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:09:37 -04:00
Mitesh Kanjariya
b8ce75a5d3
zebra: update sticky mac attribute to BGP if necessary
...
Ticket: CM-16732
Review: CCR-6368
Unit-test: Manual (logs attached to ticket)
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:09:37 -04:00
Mitesh Kanjariya
421bb26a51
bgpd/zebra: fix bgpd crash happening in mac mobility code path
...
Ticket: CM-16216
Review: CCR-6210
Unit-test: Manual
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:09:37 -04:00
Donald Sharp
62982d5a9d
bgpd: Fix evpn help strings
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-08-08 10:09:37 -04:00
Mitesh Kanjariya
16f7ce2b1e
bgpd: Added support for vni filtering
...
1. provision to add match clause with a vni under route-map
Ticket: CM-16349
Review: CCR-6190
Unit-test: Manual (logs attached to ticket)
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:09:37 -04:00
Mitesh Kanjariya
d37ba5499e
bgpd, lib, vtysh: Added support for mac filtering in route-maps
...
1. Added support to create mac filters
2. Enabled route-map commands for EVPN address family
3. Provision to add mac filters under match clause in route-maps
Ticket: CM-16349
Review: CCR-6190
Unit-test: Manual (logs attached to ticket)
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
2017-08-08 10:09:37 -04:00
vivek
ba0fcaf6df
bgpd: Fix incorrect AFI reference
...
Fixes: "bgpd: Fixes related to use of L2VPN/EVPN"
Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
2017-08-08 10:09:37 -04:00
vivek
f2d622627b
bgpd: Update EVPN operational commands
...
Make EVPN operational commands follow the "<afi> <safi>" syntax.
The relevant commands are:
- show bgp l2vpn evpn summary
- show bgp l2vpn evpn vni ...
- show bgp l2vpn evpn route ...
- show bgp l2vpn evpn route vni ...
- show bgp l2vpn evpn import-rt
Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
2017-08-08 10:09:36 -04:00
vivek
ce78a6fbbe
bgpd: Fix nexthop for labeled-unicast
...
A prior change broke the nexthop setting for labeled-unicast
address-family in a RFC-5549 scenario (IPv4 prefixes exchanged
with IPv6 next hops). This commit fixes the issue.
Fixes: "bgpd: Fix next hop setting for EVPN"
Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
2017-08-08 10:09:36 -04:00
Donald Sharp
99a6a31e50
*: Define the number of seconds in a Day, Week and year
...
The defines:
ONE_DAY_SECOND
ONE_WEEK_SECOND
ONE_YEAR_SECOND
were being defined all over the system, move the
define to a central location.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-08 09:06:22 -04:00
Donald Sharp
f66e92bc48
Merge pull request #783 from opensourcerouting/pw-manager-2
...
Add Pseudowire management in Zebra
2017-08-08 07:54:32 -04:00
David Lamparter
689f5a8c84
*: remove --enable-tcp-zebra, rework ZAPI path
...
This adds "@tcp" as new choice on the -z option present in zebra and the
protocol daemons. The --enable-tcp-zebra option on configure is no
longer needed, both UNIX and TCP socket support is always available.
Note that @tcp should not be used by default (e.g. in an init script),
and --enable-tcp-zebra should never have been in any distro package
builds, because
**** TCP-ZEBRA IS A SECURITY PROBLEM ****
It allows arbitrary local users to mess with the routing table and
inject bogus data -- and also ZAPI is not designed to be robust against
attacks.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-08 11:14:05 +02:00
David Lamparter
00857b241e
Merge pull request #924 from qlyoung/deprecate-ospf-lsa-min-arrival
...
ospfd: deprecate `timers lsa arrival ...`
2017-08-08 04:17:00 +02:00
David Lamparter
e8a53dbc52
Merge pull request #923 from devicenull/master
...
rhel: Don't obsolete bird
2017-08-08 04:16:08 +02:00
Renato Westphal
9074ba8423
Merge pull request #925 from qlyoung/ldpd-no-str
...
ldpd: use NO_STR
2017-08-07 18:27:52 -03:00
Quentin Young
455066581f
ldpd: use NO_STR
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-07 16:22:59 -04:00
Quentin Young
0e88de35b9
ospfd: deprecate timers lsa arrival ...
...
Don't need two of these that do the exact same thing.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-07 16:11:10 -04:00
Brian Rak
5d82c57b76
rhel: Don't obsolete bird
...
The FRR RPM was obsoleting BIRD, which meant that as soon as you added a FRR RPM to a repository, you could no longer install BIRD. This patch switches it over to Conflicts instead, which should be much nicer behavior
2017-08-07 14:37:21 -04:00
Jafar Al-Gharaibeh
68b39ad41b
Merge pull request #922 from qlyoung/pim-cli
...
pimd: some pim cli fixes
2017-08-07 13:19:11 -05:00
Quentin Young
9643e2c75b
pimd: some pim cli fixes
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-07 12:42:05 -04:00
Jafar Al-Gharaibeh
ac3da8fa5b
Merge pull request #916 from donaldsharp/eigrp_various
...
Eigrp various
2017-08-07 11:22:36 -05:00
Jafar Al-Gharaibeh
497c6ae075
Merge pull request #903 from donaldsharp/pimble
...
Pimble
2017-08-07 11:20:38 -05:00
Quentin Young
f36f135e73
Merge pull request #921 from opensourcerouting/vty-varname-end-tkn
...
lib: cli: don't run off graph "pre-end"
2017-08-07 10:33:15 -04:00