proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-15 04:33:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
12,131 Commits 4 Branches 191 Tags 125 MiB
c11b11d566
Commit Graph

1181 Commits

Author SHA1 Message Date
Mark Stapp
123214efb8 libs, daemons: use const in route-map apply 
Use 'const prefix *' in route-map apply apis; led to some
corresponding changes in several daemons.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2018-07-23 10:34:35 -04:00
Donald Sharp
ec50871f91 ospfd: Remove deprecated code 
This code has been deprecated for over a year, let's remove it now.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-07-09 12:37:54 -04:00
F. Aragon
2ffc213bf8
ospfd pimd: null check (PVS-Studio) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-07-06 00:49:24 +02:00
Quentin Young
4adc8f6852
Merge pull request #2620 from pacovn/PVS-Studio_null_check_2 
bgpd lib ospfd pimd ripngd: null chk (PVS-Studio)
 2018-07-03 17:38:09 -04:00
Lou Berger
b99af60a40
Merge pull request #2599 from pacovn/PVS-Studio_Array_overrun 
ospfd zebra: array overrun fixes (PVS-Studio)
 2018-07-03 11:37:34 -04:00
F. Aragon
b575a12c87
bgpd lib ospfd pimd ripngd: null chk (PVS-Studio) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-07-03 15:39:50 +02:00
F. Aragon
e1fa928d22
ospfd zebra: array overrun fixes (PVS-Studio) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-07-03 11:34:40 +02:00
F. Aragon
0651460e00
eigrpd nhrpd ospfd pimd: fomat fixes (PVS-Studio) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-07-02 17:50:21 +02:00
paco
4adf00f765
ospfd: null check (Coverity 23110) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-27 14:41:50 +02:00
Quentin Young
81ef2361a3
Merge pull request #2559 from pacovn/Coverity_1302503_Logically_dead_code 
lib ospfd: dead code (Coverity 1302503 1302502)
 2018-06-26 16:48:54 -04:00
paco
39050c7e0d
lib ospfd: dead code (Coverity 1302503 1302502) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 21:39:56 +02:00
Quentin Young
045a178c13
Merge pull request #2560 from pacovn/Coverity_1302500_Constant_variable_guards_dead_code 
ospfd: dead code (Coverity 1302500)
 2018-06-26 15:05:53 -04:00
paco
9df48e81ee
ospfd: dead code (Coverity 1302500) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 20:33:47 +02:00
Russ White
884cc57a96
Merge pull request #2547 from pacovn/Coverity_1458168_Dereference_null_return_value 
eigrpd ospfd: null check (Coverity 1458168 1455335)
 2018-06-26 11:14:07 -04:00
Jafar Al-Gharaibeh
6bb6f26c4e
Merge pull request #2550 from pacovn/Coverity_1399284_Dereference_null_return_value 
ospfd: null check (Coverity 1399284)
 2018-06-25 12:40:02 -04:00
Jafar Al-Gharaibeh
433b146e25
Merge pull request #2543 from pacovn/Coverity_1399304_Out-of-bounds_access 
ospfd: out-of-bounds access (Coverity 1399304 1399286)
 2018-06-25 12:38:44 -04:00
paco
162dbe419d
ospfd: null check (Coverity 1399284) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 17:18:17 +02:00
paco
13f0e43443
ospfd: OoB access (Coverity 1399304 1399286) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 17:07:31 +02:00
paco
a2d7fdfeb0
eigrpd ospfd: null chk (Coverity 1458168 1455335) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 16:37:04 +02:00
paco
c23bc38a9f
ospfd: OoB access (Coverity 1221445 1221448) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 11:22:20 +02:00
Quentin Young
0a8990d5f8
Merge pull request #2501 from pacovn/infer_unused1 
bgpd isisd ldpd lib ospfd pimd: redundancy (infer, grouped)
 2018-06-21 15:12:33 -04:00
Donald Sharp
eab268594a
Merge pull request #2504 from pacovn/Coverity_23110_Dereference_after_null_check 
ospfd: null check (Coverity 23110)
 2018-06-21 07:30:21 -04:00
paco
a2b6e694b1
bgpd isisd ldpd lib ospfd pimd: redundancy (infer) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 22:25:28 +02:00
paco
ed35fc0593
ospfd: null check (Coverity 23110) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 18:35:20 +02:00
Russ White
96be948bcd
Merge pull request #2495 from pacovn/fixme_all_digit 
bgpd, lib, ospfd, zebra: all_digit moved to frrstr
 2018-06-20 07:38:19 -04:00
Russ White
9dbaf129b2
Merge pull request #2446 from pacovn/Coverity_1452454_1452455_1452456_Out-of-bounds_access 
ospfd: OoB access (Cov 1452454 1452455 1452456)
 2018-06-20 07:14:49 -04:00
paco
5d5ba0185d
bgpd, lib, ospfd, zebra: all_digit moved to frrstr 
This solves a pending FIXME

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 17:59:53 +02:00
paco
5f18adf01b
eigrpd, isisd, lib, ospfd: no effect (cppcheck) 
Assignment of function parameter has no effect outside the function.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 10:19:05 +02:00
Donald Sharp
6f32955ec3
Merge pull request #2486 from pacovn/cppcheck_fmt_validation 
babeld, lib, ospfd, tests: fmt fixes (cppcheck)
 2018-06-18 15:23:49 -04:00
Donald Sharp
b49bc6b010
Merge pull request #2487 from pacovn/cppcheck_redundant_memset 
ospfd, pimd: redundant memset (cppcheck)
 2018-06-18 15:15:46 -04:00
paco
d11c6941dc
babeld, eigrpd, ospfd: unsigned negative check 
After Cppcheck 1.72 feedback

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 19:07:24 +02:00
paco
1a36dd60fd
ospfd, pimd: redundant memset (cppcheck) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 18:01:59 +02:00
paco
2ec42b858c
babeld, lib, ospfd, tests: fmt fixes (cppcheck) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 17:52:56 +02:00
Rafael Zalamena
e4a374681d
Merge pull request #2426 from pacovn/Coverity_23089_Buffer_not_null_terminated 
ospfd: buffer termination (Coverity 23089)
 2018-06-14 18:02:34 -03:00
Rafael Zalamena
67f23e08c3
Merge pull request #2438 from pacovn/Coverity_1457300_Dereference_after_null_check 
ospfd: null check (Coverity 1457300)
 2018-06-14 17:58:10 -03:00
paco
9ffaacb0f7
ospfd: OoB access (Cov 1452454 1452455 1452456) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-14 19:19:44 +02:00
Renato Westphal
0d0ca0bb34
Merge pull request #2435 from pacovn/Coverity_1464993_Buffer_not_null_terminated 
ospfd: buffer termination (Coverity 1464993)
 2018-06-14 13:44:10 -03:00
paco
1f9d4e3d49
ospfd: buffer termination (Coverity 23089) 
Details:
- INET_ADDRSTRLEN is 16, for xxx.xxx.xxx\0, so 15 is now passed
 to the strncpy call instead of 16, ensuring ASCII-z output

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-14 17:43:19 +02:00
paco
e4407ea6d0
ospfd: buffer termination (Coverity 1464993) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-14 16:59:31 +02:00
Rafael Zalamena
c0519af39f
Merge pull request #2430 from pacovn/clang_scan_ospf_dereference 
ospfd: dereference check (Clang scan-build)
 2018-06-14 11:14:52 -03:00
paco
e89ffeee92
ospfd: null check (Coverity 1457300) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 19:04:43 +02:00
paco
a37befa70b
ospfd: dereference check (Clang scan-build) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 15:49:36 +02:00
paco
92692be16a
ospfd: dead code (Coverity 1399232) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 14:30:06 +02:00
paco
b42664f473
ospfd: logically dead code (Coverity 1399236) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-12 14:41:19 +02:00
Donald Sharp
20a7c80cc2 ospfd: lp may be null, make sure it isn't 
We lookup the lp value and lookup_linkparams_by_instance
can return NULL if something has gone terribly wrong.
Make sure that lp is not NULL.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-05 10:42:05 -04:00
Donald Sharp
752ee70be8 ospfd: Note that we do not care about self origination in this case 
When we first get a packet, we need to know if we are self
originated later to make correct decisions.  Go ahead and
note that we do not plan to make any decision points
about our self origination here.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-05 10:42:05 -04:00
Renato Westphal
7aad159464 build: append -std=gnu99 after SNMP_CFLAGS 
Programs that link to libnetsnmp must be compiled using a special set
of flags as specified by the "net-snmp-config --base-cflags" command
(whose output is stored in the SNMP_CFLAGS variable). The problem is
that "net-snmp-config --base-cflags" can output -std=c99 in addition to
other compiler flags in some platforms, and this breaks the build since
FRR souce code makes use of some GNU compiler extensions (e.g. allow
trailing commas in function parameter lists). In order to solve this
problem, append -std=gnu99 after SNMP_CFLAGS in all makefiles where this
variable is used. This way the -std=c99 flag will be overwritten when it's
present. Source files that don't link to libnetsnmp will be compiled using
either -std=gnu99 or -std=gnu11 depending on the compiler availability.

Fixes #1617.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2018-06-02 22:12:57 -03:00
Chirag Shah
4fc8a85288 ospfd: packet fifo init in interface create 
Currently, interface packet transmit queue is created/deleted
as part of Interface UP/Down event. This results in
a rare condition where port came up but queue
was not created. The creation of queue occupies only few bytes.

Moving fifo queue creation to interface create
would add few bytes of fifo creation but at least it guaranteed
to be available during Up/down -->Up event.

Initialize ospf packet fifo queue during ospf
interface creation.

Drain queue during interface down event.

Drained and free the queue as part of the interface
delete/cleanup.

Ticket:CM-20744
Testing Done:

Bring up ospfv2 topology with multiple neighbors.
1) Trigger multiple shut/no shut events and validate
all queues are freed.
2) configure/deconfigure router ospf and validate
all ospf instance and interface underneath are freed.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2018-05-10 17:45:43 -07:00
Mark Stapp
4259ea81e9 ospfd: use prefix2str in debugs in zebra module 
Clean up a typo or two, and use prefix2str consistently.
 2018-04-23 16:06:39 -04:00
Quentin Young
7ff7fcd2a1 ospfd: use __func__ in ospf_te.c 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-04-17 14:08:57 -04:00