Commit Graph

7190 Commits

Author SHA1 Message Date
Renato Westphal
ef04b19249 lib: fix segfault on exit caused by interface removal
Add missing bits to properly unlink interface in the if_unlink_per_ns()
function.

In the long term we should convert if_table to use a more convenient
data structure like a red-black tree instead of a routing table.

Fixes issue #398.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-04-28 15:38:00 -03:00
Donald Sharp
87e34b5889 bgpd: Fix some crashes due to NULL pointer
If you specified A.B.C.D, the code would still try to
read A.B.C.D/M and not find it and pass in a NULL pointer
which crashed the code.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-28 13:54:29 -04:00
Donald Sharp
40d3ecc35c Merge pull request #417 from donaldsharp/stable_2_0_fixes_into_stable_3_0
Stable 2.0 fixes into stable 3.0
2017-04-28 11:42:21 -04:00
Jafar Al-Gharaibeh
71d702a85e Merge branch 'stable/3.0' into pim_dev_3_0 2017-04-28 10:38:05 -05:00
Jafar Al-Gharaibeh
0b4cbacad9 Merge pull request #381 from donaldsharp/pimmerino
Pimmerino
2017-04-28 10:13:39 -05:00
Donald Sharp
650532d3d5 Merge pull request #419 from hwchiu/update-the-docs-of-ubuntu
Update the docs of ubuntu 12.04/14.04
2017-04-28 11:10:47 -04:00
Donald Sharp
30a24af092 ospf6d: Fix parse_type_spec
The function parse_type_spec was always looking in argv[0] of
for figuring out the type of the command.  Since the type location
could change, use the passed in idx_lsa.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-28 10:55:45 -04:00
Donald Sharp
373886aba9 ospf6d: Fix some issues with 'show ipv6 ospf6 data..'
1) linkstate-id was made optional in one case
2) The ipv4 address was being looked at in the wrong spot

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-28 10:55:45 -04:00
Donald Sharp
7c680483e5 vtysh: Add back in some missing ospf6 commands
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-28 10:55:45 -04:00
Donald Sharp
fcc65b0ff4 bgpd: Allow old vpnv4 commands to compile
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-28 10:55:45 -04:00
Donald Sharp
46854ac0ae bgpd: Fix 'show .. bgp ... neighbors ' command
The 'show ip bgp neighbors swp31s0' command was not
working properly.  This fixes that issue.

This command still has issues that need to be investigated
but for the moment this gets the command working in the
form that is needed.  More rework can come.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-28 10:55:45 -04:00
Donald Sharp
b9f77ec810 bgpd: Make json output to be camelCase
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-28 10:55:45 -04:00
Donald Sharp
798c3572a0 bgpd: Modify 'show ... bgp ... summary' to only display pertinent info
Modify the 'show ... bgp ... summary' command when you are
looking at a afi( with no safi specified ) to only display
output for those safi's that have been configured.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-28 10:55:39 -04:00
Donald Sharp
ceac05ce8e Merge pull request #425 from opensourcerouting/bgpd-clear-fix
bgpd: fix "clear bgp" commands
2017-04-28 10:47:05 -04:00
Donald Sharp
ed8ba2e920 Merge pull request #423 from opensourcerouting/feature/isis-mt
IS-IS multi topology
2017-04-28 10:18:33 -04:00
Donald Sharp
de290a3f57 Merge pull request #424 from opensourcerouting/snap-fix-distfile
More snapcraft cleanups
2017-04-28 10:02:03 -04:00
Renato Westphal
f0dac89fde bgpd: fix "clear bgp" commands
The use of VTY_DECLVAR_CONTEXT(bgp, bgp) here is wrong as we are not
inside the "router bgp" configuration node. This was making the clear
commands always fail with a "Current configuration object was deleted
by another process" error, which doesn't make any sense.

Also, the bgp_clear() function will already check for us if the given
peer-group or neighbor exists or not, there's no need to duplicate this
logic here.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-04-28 10:47:51 -03:00
Martin Winter
b9f34c6215 snapcraft: Clean up old no longer used configure flags
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-28 03:11:51 -07:00
Christian Franke
2b67862cca isisd: make spf MT aware
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Christian Franke
c3ae312702 isisd: announce and parse MT IP reachabilities
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Christian Franke
206f4aae58 isisd: announce and parse MT IS reachabilities
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Christian Franke
d8fba7d974 isisd: track intersecting set of supported MTs for each adj
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Christian Franke
99894f9a17 isisd: announce MT capabilities in IIH and LSP
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Christian Franke
064f48967b isisd: add MT configuration
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Christian Franke
316a98ecd1 isisd: implement draft-ietf-isis-ext-eth and support p2p over LAN on BSD
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Christian Franke
1b49e4f0ba isisd: do some cleanup on the spf implementation
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Christian Franke
795c08fc9e isisd: function lsp_te_tlv_fit is never used
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-04-28 12:03:23 +02:00
Martin Winter
8ccfe8f875 snapcraft: Add support for extra version information
- frr.version snap command will now show the contents of
  extra_version_info.txt in addition to the zebra --version output

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-28 01:48:51 -07:00
Martin Winter
0d4a6bd23c snapcraft: Fix missing files in "make dist" target
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-27 23:26:20 -07:00
Hung-Wei Chiu
362de4a621 update doc of ubuntu 12.04
1. modify the prefix to /usr (which is hard-code in /etc/init.d/frr)
2. install init.d related files.
2017-04-27 23:30:56 +08:00
Hung-Wei Chiu
500e13fea3 Update 14.04 docs to support init.d service
1. Configure the prefix to /usr  (frr script hard-code those path in /etc/init.d/frr)
2. Install the service file to /etc/init.d
2017-04-27 23:14:23 +08:00
Donald Sharp
94248997ab Merge pull request #416 from opensourcerouting/ldpd-coverity-fix
ldpd: fix issues detected by Coverity Scan
2017-04-27 09:41:07 -04:00
Hung-Wei Chiu
8395883b3e Update Building_FRR_on_Ubuntu1604.md
Fix typo
2017-04-27 09:34:16 -04:00
Hung-Wei Chiu
c398245864 Update Building_FRR_on_Ubuntu1604.md
1.  Modify the configure prefix (since there some hard coded path in **/usr/lib/frr/fr**
2.  Install the systemd service config
2017-04-27 09:34:03 -04:00
Donald Sharp
d8a055e0f2 Merge remote-tracking branch 'origin/stable/2.0' 2017-04-27 09:12:46 -04:00
Donald Sharp
e12ff52ab3 Merge pull request #415 from hwchiu/fix_ubuntu16.04
Update Building_FRR_on_Ubuntu1604 to make it support systemd
2017-04-27 08:31:16 -04:00
Renato Westphal
59341c1b5e Merge pull request #413 from dwalton76/address-family-argv-argc-stable-30
Problem with DEFUNSH in vtysh, issue #358
2017-04-27 09:21:20 -03:00
Renato Westphal
af7e63a357 ldpd: fix issues detected by Coverity Scan
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-04-27 08:56:15 -03:00
Hung-Wei Chiu
8a77d75b8a Update Building_FRR_on_Ubuntu1604.md
Fix typo
2017-04-27 11:22:15 +08:00
Hung-Wei Chiu
8399fd9d36 Update Building_FRR_on_Ubuntu1604.md
1.  Modify the configure prefix (since there some hard coded path in **/usr/lib/frr/fr**
2.  Install the systemd service config
2017-04-27 11:10:36 +08:00
Donald Sharp
2a23cf9503 vtysh: remove unused compilation file
Remove eigrp_routemap.c from consideration at the
moment for vtysh inclusion.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-26 22:27:28 -04:00
Donald Sharp
838cf8aba5 eigrpd: Switch u_int64_t -> uint64_t
Apparently u_int64_t is not available (or we don't pull
the right headers in for solaris based systems ).

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-26 22:10:33 -04:00
Donald Sharp
171616ccef eigrpd: Add missing eigrp_fsm.h to 'make dist'
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-26 22:10:11 -04:00
Donald Sharp
a8a5dbc01d lib: Actually include the header file
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-26 21:50:27 -04:00
Donald Sharp
ba0cb3fe96 lib: Fix compilation of some be32* code
The be32dec and be32enc functions are available on some
platforms and not others.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-26 21:46:10 -04:00
Martin Winter
77e17a6ae5 Merge pull request #384 from donaldsharp/dr2
Add source of route as protocol string in ip route pushed into kernel
2017-04-26 16:24:48 -07:00
Daniel Walton
39530dfe75 Problem with DEFUNSH in vtysh, issue #358
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-04-26 22:39:10 +00:00
Daniel Walton
c5a543b433 Update to draft-ietf-idr-bgp-prefix-sid-05
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

The initial implementation was against draft-keyupate-idr-bgp-prefix-sid-02
This updates our label-index implementation up to draft-ietf-idr-bgp-prefix-sid-05
- changed BGP_ATTR_LABEL_INDEX to BGP_ATTR_PREFIX_SID
- since there are multiple TLVs in BGP_ATTR_PREFIX_SID you can no longer
  rely on that flag to know if there is a label-index for the path. I
changed bgp_attr_extra_new() to init the label_index to
BGP_INVALID_LABEL_INDEX
- put some placeholder code in for the other two TLVs (IPv6 and
  Originator SRGB)
2017-04-26 21:45:32 +00:00
Renato Westphal
a30c159769 Merge pull request #343 from donaldsharp/mpls2
Mpls
2017-04-26 17:57:04 -03:00
Donald Sharp
4f13df624b lib: Fix some *bsd build issues introduced by EIGRP code
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-26 15:16:29 -04:00