Donald Sharp
30b82c7af7
pimd: Fix pim_channel_oil_empty tests
...
The pim_channel_oil_empty() function was setting
the pimreg if it ever existed for NULL comparison
but of course the pimreg device is never pulled back
out again when it was needed to be when the pimreg
is not present.
Commit: a5fa982256
broke this.
Fixes : #11368
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-09 09:36:11 -04:00
Abhishek N R
789d0ec4de
pim6d: Moving reusable code to common api for "show mroute summary" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 04:53:12 -07:00
Abhishek N R
1c1077c200
pim6d: Moving reusable code to common api for "show ip/ipv6 mroute count" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 04:43:28 -07:00
Abhishek N R
4f1f8ff9aa
pim6d: Moving reusable code to common api for "show ip/ipv6 mroute" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 04:27:20 -07:00
Sai Gomathi N
fe7eaf4065
pim6d: Moving the common lines of pim_show_nexthop_lookup cli
...
Moving the common lines of pim_show_nexthop_lookup cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-09 04:22:42 -07:00
Abhishek N R
334d2f8c3d
pim6d: Moving reusable code to common api for "show ip/ipv6 multicast count" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 04:04:14 -07:00
Donald Sharp
a76cf7e49e
babeld: Ignore sub-tlv's with mandatory bit set
...
RFC 8966 4.4
If the mandatory bit is set, then the
whole enclosing TLV MUST be silently ignored (except for updating the
parser state by a Router-Id, Next Hop, or Update TLV, as described in
the next section).
Fixes : #11349
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-09 07:04:01 -04:00
Donald Sharp
54a3e60b3e
babeld: Update to ignore unicast hellos
...
RFC 8966 requires a bit of work to make FRR forward compabitble with
it for the moment.
tl;dr -> Flags of hellos should be 0 except the main bit and
The Unicast Hello bit if set should cause the packet to be ignored.
Additionally FRR needs to ignore Hello packets with the interval field
set to 0.
Fixes : #11349
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-09 07:04:01 -04:00
Abhishek N R
8e15c9aa06
pim6d: Moving reusable code to common api for "show ip/ipv6 multicast" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 03:51:41 -07:00
Abhishek N R
e7c01c6769
pim6d: Moving reusable code to common api for "show pim state" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 03:29:02 -07:00
Sai Gomathi N
cefa37cf41
pim6d: Moving the common lines of pim_show_nexthop cli
...
Moving the common lines of pim_show_nexthop cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-09 03:23:28 -07:00
Abhishek N R
c630970866
pim6d: Moving reusable code to common api for "show pim upstream rpf" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 03:10:21 -07:00
Abhishek N R
622da92f35
pim6d: Moving reusable code to common api for "show pim upstream join desired" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 02:57:49 -07:00
Abhishek N R
9aa0569d6e
pim6d: Moving reusable code to common api for "show pim upstream" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 02:40:21 -07:00
Sai Gomathi N
78b0e69073
pim6d: Moving the common lines of pim_show_neighbors_vrf_all cli
...
Moving the common lines of pim_show_neighbors_vrf_all cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-09 02:36:08 -07:00
Abhishek N R
19296b58e4
pim6d: Moving reusable code to common api for "show pim statistics" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 01:59:58 -07:00
Sai Gomathi N
154aa4fcd4
pim6d: Moving the common lines of pim_show_neighbors cli
...
Moving the common lines of pim_show_neighbors cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-09 01:34:06 -07:00
Abhishek N R
5e52c8d5c8
pim6d: Moving reusable code to common api for "show pim secondary" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 01:33:01 -07:00
Abhishek N R
e21c4e9075
pim6d: Moving resuable code to common api for "show pim rp-info" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09 00:49:38 -07:00
Sai Gomathi N
bec5bdbe7f
pim6d: Moving the common lines of pim_local_membership cli
...
Moving the common lines of pim_local_membership cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-09 00:34:33 -07:00
Sai Gomathi N
3ca4082343
pim6d: Moving the common lines of pim_show_jp_agg cli
...
Moving the common lines of pim_show_jp_agg cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-09 00:34:24 -07:00
Donatas Abraitis
121903bd01
Merge pull request #11370 from donaldsharp/lib_zebra_cleanup
...
Lib zebra cleanup
2022-06-09 10:17:24 +03:00
Sai Gomathi N
342ba5f3bd
pim6d: Moving the common lines of pim_show_interface_vrf_all cli
...
Moving the common lines of pim_show_interface_vrf_all cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-08 23:56:17 -07:00
Sai Gomathi N
8282b98838
pim6d: Moving the common lines of pim_show_interface cli
...
Moving the common lines of pim_show_interface cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-08 23:27:00 -07:00
Sai Gomathi N
b6bf33775d
pim6d: Moving the common lines of pim_show_channel cli
...
Moving the common lines of pim_show_channel cli
in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-08 23:25:51 -07:00
Abhishek N R
6d1bd8c28a
pim6d: Moving resuable code to common api for "show pim rpf" command
...
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-08 22:49:16 -07:00
Jafar Al-Gharaibeh
71da1da0c8
Merge pull request #11360 from opensourcerouting/fix/distro_changelogs
...
redhat, debian: Update packaging releases
2022-06-08 23:56:21 -05:00
mobash-rasool
4a3879b89b
Merge pull request #11369 from donaldsharp/pim_addr_cmp
...
pimd: pim_addr_cmp returns 0 for same not -1 or 1
2022-06-09 07:57:24 +05:30
Donald Sharp
2d4093ee30
ospfd: Fixup ospfd.h to declare variable names
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-08 11:38:22 -04:00
Donald Sharp
0b96b8288a
lib: Cleanup workqueue.h to have variable declarations
...
Cleanup workqueue.h to have variable declarations as per
our standard.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-08 11:38:22 -04:00
Donald Sharp
d1c276681f
lib: Fixup workqueue.c to use proper thread.h semantics
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-08 11:38:22 -04:00
Donald Sharp
e0220703d1
pimd: pim_addr_cmp returns 0 for same not -1 or 1
...
The test for setting pimDesignatedRouterLocal was comparing
the result of pim_addr_cmp to non zero to say that the
pim_dr_addr and primary_address are the same. This is
not correct in that pim_addr_cmp returns 0 for being the
same, so the correct test is !pim_addr_cmp
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-08 11:36:48 -04:00
Donald Sharp
71623b304e
Merge pull request #11356 from mobash-rasool/pim-rfc-conform
...
pimd: Handle receive of (*,G) register stop with src addr as 0
2022-06-08 08:15:58 -04:00
Sarita Patra
d8cace8772
pim6d: Introduced PIMREG macro
...
Signed-off-by: Sarita Patra <saritap@vmware.com>
2022-06-08 01:59:37 -07:00
Donatas Abraitis
8bf53b1594
debian: Update changelog for new release (8.4)
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-06-07 23:26:58 +03:00
Donatas Abraitis
fb30d88928
redhat: Update changelog for new release (8.4)
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-06-07 23:26:56 +03:00
Donatas Abraitis
ba9dce1c87
bgpd: Print source VRF name when leaking to another VRF
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-06-07 22:50:25 +03:00
Donatas Abraitis
3840a8193e
bgpd: Withdraw implicitly old paths from VRFs when import/export list changes
...
If we overwrite import/export RT list via route-maps or even flush by using
`set extcommunity none`, then we must withdraw old paths from VRFs to avoid
stale paths.
For example using:
```
router bgp 65500 vrf vrf1
bgp router-id 10.180.1.1
!
address-family ipv4 unicast
network 192.168.100.100/32 route-map rm
rd vpn export 65500:10001
rt vpn import 65500:10000 65500:10990
rt vpn export 65500:10000
export vpn
import vpn
exit-address-family
exit
!
router bgp 65500 vrf vrf2
bgp router-id 10.180.1.1
!
address-family ipv4 unicast
rd vpn export 65500:11001
rt vpn import 65500:11000 65500:11990
rt vpn export 65500:11000
export vpn
import vpn
exit-address-family
exit
!
route-map rm permit 10
set extcommunity rt 65500:10100 65500:12990 65500:13990 65500:11990
exit
```
If we strip extcommunities using:
```
route-map rm permit 10
set extcommunity none
exit
```
or
```
route-map rm permit 10
set extcommunity rt 65500:10100 65500:12990 65500:13990
```
Routes that are imported with 65500:11990 (192.168.100.100/32 from vrf1)
becomes stale.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-06-07 22:50:24 +03:00
Donatas Abraitis
087350d968
build: FRR 8.4 development version
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-06-07 22:47:17 +03:00
Pushpasis Sarkar
aa800819cd
Merge pull request #11312 from opensourcerouting/feature/draft-ietf-idr-bfd-subcode
...
bgpd: Add Notification CEASE BFD Down message
2022-06-07 21:27:12 +05:30
Olivier Dugeon
96b706b72a
Merge pull request #11334 from ton31337/fix/deprecation_warning
...
ospfd: Remove local-block deprecated command
2022-06-07 17:38:52 +02:00
Pushpasis Sarkar
4d571bb3c4
Merge pull request #11158 from cyberstormdotmu/master
...
lib/md5,lib/sha256: Use explicit_bzero to clean up sensitive data.
2022-06-07 21:05:03 +05:30
Russ White
d7f2f10ed4
Merge pull request #11318 from pguibert6WIND/isis_mt_std
...
isisd: add ISIS_MT_STANDARD define
2022-06-07 11:30:05 -04:00
Donald Sharp
a775175bfd
Merge pull request #11289 from LabNConsulting/chopps/ospfapi-update
...
ospfapi improvements and fixes
2022-06-07 11:00:56 -04:00
Donatas Abraitis
d2e02cbf64
ospfd: Remove local-block deprecated command
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-06-07 16:11:46 +03:00
Mobashshera Rasool
e502ecad11
pimd: Handle receive of (*,G) register stop with src addr as 0
...
PIM conformance test case 11.12 sends a register stop msg with
source address as 0. This should trigger a register stop for
all the upstreams. It is not happening as such because we are not
considering 0.0.0.0 source address for starg_handling.
Fixed it.
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-06-07 05:53:46 -07:00
Donatas Abraitis
0f05ea43b0
bgpd: Initialize attr->local_pref to the configured default value
...
When we use network/redistribute local_preference is configured inproperly
when using route-maps something like:
```
network 100.100.100.100/32 route-map rm1
network 100.100.100.200/32 route-map rm2
route-map rm1 permit 10
set local-preference +10
route-map rm2 permit 10
set local-preference -10
```
Before:
```
root@spine1-debian-11:~# vtysh -c 'show bgp ipv4 unicast 100.100.100.100/32 json' | jq '.paths[].locPrf'
10
root@spine1-debian-11:~# vtysh -c 'show bgp ipv4 unicast 100.100.100.200/32 json' | jq '.paths[].locPrf'
0
```
After:
```
root@spine1-debian-11:~# vtysh -c 'show bgp ipv4 unicast 100.100.100.100/32 json' | jq '.paths[].locPrf'
110
root@spine1-debian-11:~# vtysh -c 'show bgp ipv4 unicast 100.100.100.200/32 json' | jq '.paths[].locPrf'
90
```
Set local-preference as the default value configured per BGP instance, but
do not set LOCAL_PREF flag by default.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-06-06 10:28:50 +03:00
Christian Hopps
ad9c18f375
tests: add opaque api test
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2022-06-02 16:37:16 -04:00
Christian Hopps
9191ac86fd
ospfclient: add ospfclient api python class
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2022-06-02 16:37:16 -04:00
Christian Hopps
bd1188f904
ospfd: api: always ready to receive opaque from client
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2022-06-02 16:37:16 -04:00