Donald Sharp
bb5dddf713
Merge pull request #8284 from mjstapp/fix_bgp_zero_timers
...
bgpd: use add_event instead of add_timer with zero timeout
2021-03-18 07:29:32 -04:00
Chirag Shah
e6e62ee52d
doc: add seqno to bgp as path list section
...
Add sequence no option to bgp as-path list cli syntax.
Add sequence no to example config.
Add auto generated sequence no in running-config if its not
provided in config.
Signed-off-by: Chirag Shah <chirag@nvidia.com>
2021-03-17 22:06:53 -07:00
Chirag Shah
9b6f73ee9c
bgpd: add seqno in bgp as-path access-list policy
...
Add optional parameter seqno to bgp as-patch policy
to inline with other bgp policies commands at same
level.
Testing Done:
config t
bgp as-path access-list foo1 permit _40_
bgp as-path access-list foo1 seq 5 permit _41_
bgp as-path access-list foo1 seq 8 permit _42_
bgp as-path access-list foo2 permit _43_
no bgp as-path access-list foo1 permit _41_
bgp as-path access-list foo1 permit 41$
show run:
bgp as-path access-list foo1 seq 8 permit _42_
bgp as-path access-list foo1 seq 10 permit 41$
bgp as-path access-list foo2 seq 5 permit _43_
Signed-off-by: Chirag Shah <chirag@nvidia.com>
2021-03-17 22:06:53 -07:00
Amol Lad
e8089de123
nhrpd: Set prefix length in NAT extension in resolution-reply
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Reuben Dowle
9025515c25
nhrpd: Ensure invalid NAT extension info cannot be used
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Reuben Dowle
18cc9c4293
nhrpd: Use SU_ADDRSTRLEN where appropriate
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Amol Lad
611915ae89
nhrpd: populate correct prefix length in NAT extension in Reg-Reply
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Amol Lad
85365e51f0
nhrpd: Add Claimed NBMA field in sh ip nhrp cache output
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Amol Lad
94eae49d01
nhrpd: add NHS details in NAT Extension header
...
Hub uses this to check if is itself behind a NAT
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Amol Lad
1bd508da17
nhrpd: copy NAT extension if present else attempt to populate
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Amol Lad
9c292647a9
nhrpd: parse multiple CIEs in NAT extension header
...
Cisco devices send can send multiple CIEs so we must search for the correct CIE
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Amol Lad
5e70e83b9e
nhrpd: Add empty NAT extension header for Non Natted Spoke in Resolution-Reply
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Amol Lad
1e52c95464
nhrpd: Set correct MTU in NHRP extensions
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Reuben Dowle
999a07f0d4
nhrpd: Send prefix length in NAT extension the same as is done by Cisco
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Gaurav Goyal
c2cffffb37
nhrpd: Add CIE to NAT extension in resolution requests
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Gaurav Goyal
b5fc78c068
nhrpd: Add NAT extension in forwarded packets
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Gaurav Goyal
bb58f44259
nhrpd: Process NAT extension properly, and also fallback to IPSec NAT info
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Amol Lad
d5dc926f18
nhrpd: Add zbuf routine to peek at contents
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-18 16:35:41 +13:00
Kuldeep Kashyap
53402dbf1e
tests: Fix bgp convergence issue mentioned in #8279
...
1. Enhance verify_bgp_convergence() to solve issue mentioned in #8279
Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2021-03-17 17:43:57 -07:00
Mark Stapp
e0d550dfea
bgpd: use add_event instead of add_timer with zero timeout
...
Just use events in a few places where timers with zero timeout
were being used.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-03-17 16:10:13 -04:00
Quentin Young
263e82b308
Merge pull request #8052 from ton31337/feature/show_bgp_peer-groups_json
2021-03-17 15:08:00 -04:00
nsaigomathi
79c889228f
tools: Add pimd support bundle commands
...
PIM Support Bundle commands are added in support_bundle_commands.conf file.
It will help us in debugging PIM test Failures.
Signed-off-by: Sai Gomathi <nsaigomathi@vmware.com>
2021-03-17 06:48:29 -07:00
Donald Sharp
a78a4e754e
Merge pull request #8232 from reubendowle/fixes/nhrp-ipsec-issues
...
nhrp: Fix some ipsec related issues
2021-03-17 09:33:44 -04:00
Donald Sharp
28bada3d8f
Merge pull request #8255 from pjdruddy/fix-ifindex-test
...
Fix ifindex test
2021-03-17 09:10:20 -04:00
Donald Sharp
5b21cd300c
Merge pull request #8248 from volta-networks/fix_ospf6_chunk_msgs
...
ospfd6: Clear locks when ospf messages need to be chunked
2021-03-17 09:09:28 -04:00
David Lamparter
53abc26569
tests: simplify docker rsync & support worktrees
...
The previous, more complex mechanism failed to take into account that
git worktrees only have a stub .git file & copying the worktree itself
is not enough. Just extract a file list beforehand & don't bother with
git inside the container.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 13:42:20 +01:00
David Lamparter
071f5c1664
tests: add libelf-dev to Dockerfile
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 13:42:20 +01:00
Donald Sharp
4f156615e1
Merge pull request #8276 from opensourcerouting/pathd-fmt-fix
...
pathd: fix some format strings
2021-03-17 08:31:01 -04:00
Santosh P K
de40463b54
Merge pull request #8008 from chiragshah6/yang_nb5
...
[lib, yang] : multiple fixes in prefix-list northbound conversion
2021-03-17 16:25:54 +05:30
Rafael Zalamena
692b3561df
Merge pull request #8225 from idryzhov/bfd-echo-mode
...
bfdd: fix echo receive timer and disable echo mode
2021-03-17 10:45:43 +00:00
Rafael Zalamena
57e627628d
Merge pull request #8229 from idryzhov/bfdd-echo-rx-tx
...
bfdd: separate echo rx/tx timers
2021-03-17 10:41:33 +00:00
ckishimo
d205f01e1d
tests: fix too many arguments for logging
...
Signed-off-by: ckishimo <carles.kishimoto@gmail.com>
2021-03-17 09:35:47 +01:00
David Lamparter
8c64c9571e
Merge pull request #8273 from volta-networks/fix_ospf6_coverity
...
ospf6d: Fix coverity errors
2021-03-17 08:02:14 +01:00
David Lamparter
f38d31f933
Merge pull request #8275 from donaldsharp/peer_afi_safi_mistake
2021-03-17 07:13:09 +01:00
David Lamparter
d85bf6f1eb
pathd: remove mid-string line breaks
...
cf. workflow.rst ("lines over 80 characters are allowed for text strings
to make it possible to search the code for them"), matching Linux kernel
coding style.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:39:34 +01:00
David Lamparter
84b3eb42a9
pathd: use %pIA to print struct ipaddr *
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:31:38 +01:00
David Lamparter
4d39e49673
pathd: fix %pI4 <> %pI6 snafu
...
... as noted by the frr-format GCC plugin.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:30:53 +01:00
David Lamparter
941b5172ea
lib: temporary workaround for LabN CI
...
Accept macros without ; for LabN CI *only*. This is a bit hairy since
we can't generate warnings for this, so it's very limited in both scope
and duration.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:24:03 +01:00
David Lamparter
7abb042e78
build: put macro-semicolon bits into ignore-revs
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:24:03 +01:00
David Lamparter
67b0f40c98
*: require semicolon after FRR_CFG_DEFAULT_*
...
... again ...
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:18:39 +01:00
David Lamparter
80413c2073
*: require semicolon after FRR_DAEMON_INFO & co.
...
... again ...
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:18:39 +01:00
David Lamparter
960b9a5383
*: require semicolon after DEFINE_<typesafe...>
...
Again, see previous commits.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:18:39 +01:00
David Lamparter
96244aca23
*: require semicolon after DEFINE_QOBJ & co.
...
Again, see previous commits.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:18:37 +01:00
David Lamparter
8451921b70
*: require semicolon after DEFINE_HOOK & co.
...
See previous commit.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:18:17 +01:00
David Lamparter
bf8d3d6aca
*: require semicolon after DEFINE_MTYPE & co
...
Back when I put this together in 2015, ISO C11 was still reasonably new
and we couldn't require it just yet. Without ISO C11, there is no
"good" way (only bad hacks) to require a semicolon after a macro that
ends with a function definition. And if you added one anyway, you'd get
"spurious semicolon" warnings on some compilers...
With C11, `_Static_assert()` at the end of a macro will make it so that
the semicolon is properly required, consumed, and not warned about.
Consistently requiring semicolons after "file-level" macros matches
Linux kernel coding style and helps some editors against mis-syntax'ing
these macros.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:18:17 +01:00
David Lamparter
15c05f1edf
*: require ISO C11 (or C++11)
...
It's 2021... time to drop some 10yo compat stuff.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:18:17 +01:00
David Lamparter
247c7e27a9
snmp: change -std=gnu99 to -std=gnu11
...
The point of the `-std=gnu99` was to override a `-std=c99` that may be
coming in from net-snmp. However, we want C11, not C99.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:18:17 +01:00
Gaurav Goyal
58ef1668ae
nhrpd: When IPsec profile is added or deleted, reset the vc and re-check peer
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-17 17:03:47 +13:00
Reuben Dowle
74e5ba3a3f
nhrpd: Make comments clearer, fix style issues
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-17 17:02:19 +13:00
Gaurav Goyal
083bbfaebf
nhrpd: Close IPSec connection when tunnel protection removed
...
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-17 16:56:46 +13:00