proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-17 11:32:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
30,591 Commits 4 Branches 191 Tags 125 MiB
ab80e474f2
Commit Graph

30591 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donatas Abraitis
3727e359e3 bgpd: Cleanup memory for missing hashes 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-08-30 13:46:26 +03:00
Donatas Abraitis
886307027a bgpd: Drop unused memory types 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-08-30 13:46:14 +03:00
Mobashshera Rasool
e73f7bf256 pim6d: Fix the Code for MLD in the show pim state command 
show ip pim state should show IGMP Report while
show ipv6 pim state should show MLD Report.

Output After Fix:
frr# do sh ip pim state
Codes: J -> Pim Join, I -> IGMP Report, S -> Source, * -> Inherited from (*,G), V -> VxLAN, M -> Muted
Active Source           Group            RPT  IIF               OIL

frr# do sh ipv6 pim state
Codes: J -> Pim Join, I -> MLD Report, S -> Source, * -> Inherited from (*,G), V -> VxLAN, M -> Muted
Active Source           Group            RPT  IIF               OIL

frr#

Issue: #11249

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
 2022-08-30 03:13:42 -07:00
Donatas Abraitis
58e0011dc5
Merge pull request #11877 from sri-mohan1/sri-ldp-dbg1 
ldpd: changes for code maintainability
 2022-08-30 12:55:27 +03:00
Donatas Abraitis
80c6a472f0 bgpd: Fix test for matching UN prefix and the peer 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-08-30 12:06:19 +03:00
Donatas Abraitis
8248a4bc21 bgpd: Break immediatelly and print vty_out instead of double checking for JSON 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-08-30 11:46:00 +03:00
Donatas Abraitis
253b7158ee bgpd: Remove redundant test against ifp for DEBUG messages 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-08-30 11:35:05 +03:00
rgirada
ef151af79b ospfd: crash when router acts as GR helper upon a topo change 
Description:
	ospf process is crashing when  the current router acts
	as GR helper and it received a new lsa.

	Here, ospf_lsa_different() is being called without checking
	'old' pointer. It is asserted in ospf_lsa_different() api
	if the 'old' pointer is NULL.

	corrected this by validaing old pointer before calling
	ospf_lsa_different() api.

	back tarce:
	Program terminated with signal SIGABRT, Aborted.
	0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
	[Current thread is 1 (Thread 0x6b84348827c0 (LWP 3155))]
	0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
	1  0x00006b8433aa4801 in __GI_abort () at abort.c:79
	2  0x00006b8433a9439a in __assert_fail_base (fmt=0x6b8433c1b7d8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x162ffc0630bc "l1", file=file@entry=0x162ffc062ff7 "ospfd/ospf_lsa.c", line=line@entry=3520, function=function@entry=0x162ffc0646f0 <__PRETTY_FUNCTION__.18732> "ospf_lsa_different") at assert.c:92
	3  0x00006b8433a94412 in __GI___assert_fail (assertion=assertion@entry=0x162ffc0630bc "l1", file=file@entry=0x162ffc062ff7 "ospfd/ospf_lsa.c", line=line@entry=3520, function=function@entry=0x162ffc0646f0 <__PRETTY_FUNCTION__.18732> "ospf_lsa_different") at assert.c:101
	4  0x0000162ffc008c25 in ospf_lsa_different (l1=l1@entry=0x0, l2=l2@entry=0x162ffe535c60, ignore_rcvd_flag=ignore_rcvd_flag@entry=true) at ospfd/ospf_lsa.c:3520
	5  0x0000162ffc00a8e8 in ospf_lsa_install (ospf=ospf@entry=0x162ffe513650, oi=oi@entry=0x162ffe531c30, lsa=lsa@entry=0x162ffe535c60) at ospfd/ospf_lsa.c:2892
	6  0x0000162ffc059d16 in ospf_flood (ospf=0x162ffe513650, nbr=nbr@entry=0x162ffe52cc90, current=current@entry=0x0, new=new@entry=0x162ffe535c60) at ospfd/ospf_flood.c:429
	7  0x0000162ffc01838f in ospf_ls_upd (size=<optimized out>, oi=0x162ffe531c30, s=<optimized out>, ospfh=<optimized out>, iph=<optimized out>, ospf=<optimized out>) at ospfd/ospf_packet.c:2162
	8  ospf_read_helper (ospf=<optimized out>) at ospfd/ospf_packet.c:3241
	9  ospf_read (thread=<optimized out>) at ospfd/ospf_packet.c:3272
	10 0x00006b843450139c in thread_call (thread=thread@entry=0x7780f42c7480) at lib/thread.c:1692
	11 0x00006b84344cfb18 in frr_run (master=0x162ffe34d130) at lib/libfrr.c:1068

Signed-off-by: Rajesh Girada <rgirada@vmware.com>
 2022-08-30 00:48:32 -07:00
sri-mohan1
c313846a25 ldpd: changes for code maintainability 
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2022-08-30 11:16:23 +05:30
Donatas Abraitis
1d0865f755
Merge pull request #11874 from sri-mohan1/sri-isis-dbg1 
isisd: changes for code maintainability
 2022-08-29 21:30:17 +03:00
Donatas Abraitis
c3db3422c2
Merge pull request #11871 from AbhishekNR/mem_free 
pimd, pim6d: deleting the memory malloced for json.
 2022-08-29 21:25:00 +03:00
Abhishek N R
4cc5d80965 pimd, pim6d: deleting the memory malloced for json. 
Problem Statement:
=================
2022-08-18 04:57:32,376 - ERROR: Found memory leak in daemon pimd
2022-08-18 04:57:32,377 - ERROR: ==12100== 18,978 (144 direct, 18,834 indirect) bytes in 2 blocks are definitely lost in loss record 45 of 45
2022-08-18 04:57:32,377 - ERROR: ==12100==    at 0x4C31FAC: calloc (vg_replace_malloc.c:762)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x532F51F: json_object_new_object (in /lib/x86_64-linux-gnu/libjson-c.so.3.0.1)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x128B5C: pim_show_interfaces (pim_cmd_common.c:3395)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x15A86B: show_ip_pim_interface_magic (pim_cmd.c:3127)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x15A86B: show_ip_pim_interface (pim_cmd_clippy.c:324)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x4E672B2: cmd_execute_command_real.isra.2 (command.c:1005)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x4E696FE: cmd_execute_command (command.c:1064)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x4E698F1: cmd_execute (command.c:1227)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x4EBC814: vty_command (vty.c:530)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x4EBC9EF: vty_execute (vty.c:1295)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x4EBF1F7: vtysh_read (vty.c:2142)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x4EB739B: thread_call (thread.c:1692)
2022-08-18 04:57:32,377 - ERROR: ==12100==    by 0x4E85B17: frr_run (libfrr.c:1068)
2022-08-18 04:57:32,377 - ERROR: ==12100==

Signed-off-by: Abhishek N R <abnr@vmware.com>
 2022-08-29 08:46:19 -07:00
sri-mohan1
11106e287f isisd: changes for code maintainability 
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2022-08-29 20:37:32 +05:30
Donatas Abraitis
c29b1ce67c
Merge pull request #11855 from cscarpitta/fix-srv6-memleaks 
*: Fix several memory leaks in SRv6 implementation
 2022-08-29 14:35:24 +03:00
Donatas Abraitis
ad70aa810e
Merge pull request #11869 from sri-mohan1/sri-isis-dbg1 
isisd: changes for code maintainability
 2022-08-29 13:43:11 +03:00
Donatas Abraitis
6a501480c2
Merge pull request #11581 from AbhishekNR/mld_hardcode_value 
pim6d: Completing mld config commands.
 2022-08-29 13:27:28 +03:00
Donatas Abraitis
ca500e231c
Merge pull request #11857 from mobash-rasool/fixes2 
pim6d: mroute stuck in register state, multicast traffic getting drops
 2022-08-29 10:14:34 +03:00
sri-mohan1
1f46f33f9a isisd: changes for code maintainability 
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2022-08-29 12:27:03 +05:30
Abhishek N R
588e1188f6 doc: Changed uppercase MLD to lowercase in ipv6 MLD last-member-query-interval (1-65535) 
Signed-off-by: Abhishek N R <abnr@vmware.com>
 2022-08-28 23:35:03 -07:00
nguggarigoud
3cf90b1be9 tests: adding bgp admin distance topotests. 
This has bgp admin topotest automation suit.

Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
 2022-08-28 23:34:52 -07:00
Abhishek N R
707a9e9a90 pim6d: Completing "ipv6 mld last-member-query-interval" command 
Signed-off-by: Abhishek N R <abnr@vmware.com>
 2022-08-28 23:33:07 -07:00
Abhishek N R
51b4991feb pim6d: Completing "ipv6 mld last-member-query-count" command. 
Signed-off-by: Abhishek N R <abnr@vmware.com>
 2022-08-28 23:33:07 -07:00
Abhishek N R
914710d79e pim6d: Completing "ipv6 mld query-max-response-time" command. 
Signed-off-by: Abhishek N R <abnr@vmware.com>
 2022-08-28 23:33:07 -07:00
mobash-rasool
6c231c2e38
Merge pull request #11867 from sri-mohan1/sri-ospf-dbg1 
ospfd: changes for code maintainability
 2022-08-29 11:50:54 +05:30
sri-mohan1
70ad0b6627 ospfd: changes for code maintainability 
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2022-08-28 20:48:29 +05:30
anlan_cs
df78d91d8a zebra: fix missing vni transition 
`show evpn vni detail` doesn't reflect any change in vni transition.
Need to add processing in command of `[no] vni (1-16777215)`.

With the config:
```
!
vni 66
!
vrf vrf1
 vni 88
 exit-vrf
!
```

Before:
```
(config-vrf)# no vni 88
(config-vrf)# do show evpn vni detail
VNI: 66
  Type: L3
  Tenant VRF: default
  L2 VNIs: <- Empty
```

After:
```
(config-vrf)# no vni 88
(config-vrf)# do show evpn vni detail
VNI: 66
  Type: L3
  Tenant VRF: default
  L2 VNIs: 88 <-
```

Signed-off-by: anlan_cs <vic.lan@pica8.com>
 2022-08-26 21:55:52 -04:00
Donald Sharp
43bb6fc8d4
Merge pull request #11863 from sri-mohan1/sri-ospf-dbg1 
ospfd: changes for code maintainability
 2022-08-26 10:50:21 -04:00
Donatas Abraitis
b5132009fc
Merge pull request #11718 from SaiGomathiN/mldgroups 
pim6d: Implementing "show ipv6 mld groups" CLI
 2022-08-26 15:19:32 +03:00
Donatas Abraitis
5e48498795
Merge pull request #11844 from SaiGomathiN/ttable-1 
pimd, pim6d: Using ttable for displaying show CLIs
 2022-08-26 11:48:18 +03:00
Sai Gomathi N
523a644796 doc: Updated the doc for show ipv6 mld groups command 
show ipv6 mld [vrf NAME] groups [json] displays MLD group information.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
 2022-08-26 01:14:08 -07:00
Sai Gomathi N
cdc1b7709f pim6d: Implementing "show mld groups" CLI 
To Display MLD Group information

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
 2022-08-26 01:14:08 -07:00
Sai Gomathi N
8934215f65 pimd: Modifying member of pim_instance to accomodate IPv6 changes 
Modifying igmp_group_count of struct pim_instance
to gm_group_count which is to be used for both IGMP and MLD.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
 2022-08-26 01:14:08 -07:00
sri-mohan1
1396917dde ospfd: changes for code maintainability 
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2022-08-26 13:01:37 +05:30
Donatas Abraitis
1823510862
Merge pull request #11854 from donaldsharp/memory_walk_in_gdb 
gdb: Add a macro to walk memory allocations
 2022-08-26 10:20:58 +03:00
mobash-rasool
c4d9ff5f1a
Merge pull request #11862 from sri-mohan1/sri-ospf-dbg1 
ospfd: changes for code maintainability
 2022-08-26 12:08:53 +05:30
sri-mohan1
ea892800dd ospfd: changes for code maintainability 
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2022-08-25 23:48:24 +05:30
Donald Sharp
0824a0020d
Merge pull request #11860 from opensourcerouting/fix/evpn_cli_json 
bgpd: Do not print new line for EVPN CLI outputs if it's a JSON
 2022-08-25 13:20:19 -04:00
Donald Sharp
373dce6d11
Merge pull request #11858 from sri-mohan1/sri-ospf-dbg1 
ospfd: changes for code maintainability
 2022-08-25 09:25:10 -04:00
Mark Stapp
d4fc18584b
Merge pull request #11859 from liwg06/master.fix.extra.semicolon 
lib: Fix extra semicolon after if
 2022-08-25 08:53:36 -04:00
Donatas Abraitis
036f482fce bgpd: Drop bnc_str() function 
Reuse %pFX -> prefix2str()

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-08-25 14:35:28 +03:00
Donatas Abraitis
511211bf56 bgpd: Convert prefix2str to %pFX 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-08-25 14:35:27 +03:00
Donatas Abraitis
2bf9780b26 bgpd: Do not print new line for EVPN CLI outputs if it's a JSON 
Before:

```
$ vtysh -c 'show bgp l2vpn evpn route detail json'
<<<<<<<<<<<<<<<<<<<< empty line
<<<<<<<<<<<<<<<<<<<< empty line
<<<<<<<<<<<<<<<<<<<< empty line
<<<<<<<<<<<<<<<<<<<< empty line
{
	...
	"numPrefix":4,
	"numPaths":4 <<<<< four paths = four empty lines
}
```

Contain as much "empty lines" before the JSON string as the number
of paths displayed.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-08-25 13:15:27 +03:00
Weiguo Li
51a68f9b3e lib: Fix extra semicolon after if 
Signed-off-by: Weiguo Li <liwg06@foxmail.com>
 2022-08-25 17:52:21 +08:00
sri-mohan1
e6f3b2621b ospfd: changes for code maintainability 
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2022-08-24 23:34:41 +05:30
Sai Gomathi N
d250853af7 pimd, pim6d: Using ttable for displaying "show ip|ipv6 pim jp-agg" CLI 
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
 2022-08-24 09:25:55 -07:00
Sai Gomathi N
7d11f1996e pimd, pim6d: Using ttable for displaying "show ip|ipv6 pim channel" CLI 
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
 2022-08-24 09:25:55 -07:00
Jafar Al-Gharaibeh
8783ed4bb4
Merge pull request #11829 from donaldsharp/time_32_bits 
Time 32 bits
 2022-08-24 11:25:16 -05:00
Mark Stapp
28e3928163
Merge pull request #11856 from opensourcerouting/fix/revert_clist_internet 
bgpd: Revert community-list INTERNET stuff
 2022-08-24 09:32:19 -04:00
Donald Sharp
1568e88a8e ripd: Use a sequence number instead of time 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-08-24 08:30:42 -04:00
Donald Sharp
c392d9f487 babeld: Remove return value for gettime() 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-08-24 08:30:27 -04:00