Commit Graph

24361 Commits

Author SHA1 Message Date
Hiroki Shirokura
7a4b49bdd1 lib: refactor func prototype seg6local_context2str (step1)
Make seg6local_context2str function's prototype better.
This function is added on commit e496b4203, and function
interface's considering wasn't enough.

Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:47 -04:00
Donald Sharp
9dddf5fe69
Merge pull request #8759 from idryzhov/ospf6-vrf-fix
ospf6d: fix using vrf interface as a loopback
2021-06-01 16:31:26 -04:00
Donald Sharp
8a31e38fef
Merge pull request #8761 from idryzhov/fix-isis-vrf
isisd: fix using vrf interface as a loopback
2021-06-01 16:26:56 -04:00
Rafael Zalamena
06e4c62631
Merge pull request #8765 from idryzhov/bfd-vrf
isisd, ospf6d, pimd: set vrf_id when creating bfd sessions
2021-06-01 17:15:06 -03:00
Quentin Young
c99313762a
Merge pull request #8353 from opensourcerouting/llvm-20210327 2021-06-01 19:08:32 +00:00
Donald Sharp
465d4a6c5b
Merge pull request #8304 from mjstapp/fix_zmq_xref
lib: fix use of xrefs in zmq wrapper
2021-06-01 13:59:51 -04:00
Mark Stapp
88faaee986
Merge pull request #8762 from idryzhov/pcep-coverity
pceplib: fix mixup of global/local variables
2021-06-01 13:27:49 -04:00
Mark Stapp
2030df4d30
Merge pull request #8748 from idryzhov/ospf6-vrf-unlink
ospf6d: unlink router from vrf on deletion
2021-06-01 12:06:08 -04:00
Russ White
3d7bd27619
Merge pull request #8683 from kuldeepkash/bgp_gshut
tests: Add bgp_gshut_topo1 test suite
2021-06-01 11:43:48 -04:00
Igor Ryzhov
8c965eaaf4
Merge pull request #8769 from ton31337/fix/time_to_remove
lib: Time to remove CONFDATE block
2021-06-01 17:45:25 +03:00
Donatas Abraitis
ef3b48cfe1 lib: Time to remove CONFDATE block
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-01 12:33:43 +03:00
Donatas Abraitis
2cdd73387c
Merge pull request #8698 from donaldsharp/pim_black_tests
tests: Fixup some pylint warnings in test_multicast_pim_sm_topo2.py
2021-06-01 09:41:04 +03:00
Rafael Zalamena
710da500a6
Merge pull request #8768 from idryzhov/doc-index
doc: fix redundant index once again
2021-05-31 16:54:41 -03:00
Igor Ryzhov
7f9f613125 doc: fix redundant index once again
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-31 18:29:34 +03:00
Igor Ryzhov
63262607c1 isisd, ospf6d, pimd: set vrf_id when creating bfd sessions
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-31 15:04:13 +03:00
Rafael Zalamena
6c1a2a6538
Merge pull request #6317 from rgirada/fix_route_dump
zebrad: Added a command to dump routes in support bundle
2021-05-28 18:12:17 -03:00
Igor Ryzhov
32fe990571
Merge pull request #8752 from pjdruddy/ospf6-route-mem-leak
ospf6: fix memory leak in ospf6_abr_examin_summary
2021-05-28 20:43:07 +03:00
Igor Ryzhov
694f0671c5 pceplib: fix mixup of global/local variables
CID 1502790

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-28 20:39:37 +03:00
Igor Ryzhov
a80618f27d isisd: fix using vrf interface as a loopback
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-28 18:45:40 +03:00
Igor Ryzhov
d16cff32b2 ospf6d: fix using vrf interface as a loopback
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-28 16:14:34 +03:00
Igor Ryzhov
bf59f4ad20
Merge pull request #8740 from mjstapp/fix_static_ret
staticd: return meaningful status in cli error path
2021-05-28 11:35:43 +03:00
David Lamparter
525ec2e073
Merge pull request #8747 from LabNConsulting/chopps/improve-grpc-req-checks
grpc: improve checks for GRPC C++ requirements
2021-05-27 20:50:17 +02:00
Stephen Worley
7d4651cc9c
Merge pull request #8174 from mjstapp/backup_nht
zebra: hide backup-nexthop activations in nht
2021-05-27 09:49:41 -04:00
Lou Berger
baa54d9324
Merge pull request #8753 from idryzhov/fix-labn-ci
Fix LabN CI
2021-05-27 09:45:52 -04:00
Mark Stapp
f419424174 staticd: return SUCCESS when deleting non-existent route
Return SUCCESS if trying to delete route that doesn't exist.
This was always staticd's behavior before the northbound
conversion.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-05-27 09:01:43 -04:00
Igor Ryzhov
4b57e2c4f5 docker: fix ubuntu containers
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-27 15:57:03 +03:00
Igor Ryzhov
bea8786a1c Revert "build: libyangv2 is mainlined, update"
This partially reverts commit 250335d47c.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-27 15:56:06 +03:00
Christian Hopps
b256a06b22 grpc: improve checks for GRPC C++ requirements
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-05-27 12:04:33 +00:00
Pat Ruddy
de4a0bdaa6 ospf6: fix memory leak in ospf6_abr_examin_summary
Ensure that if allocated route is not added to a table then it is
deleted to avoid leaking memory.
Add a new memory type for route table so that ospf6 routes can be
distinguished in the show memory output in isolation.

Signed-off-by: Pat Ruddy <pat@voltanet.io>
2021-05-27 12:57:25 +01:00
Igor Ryzhov
92699b9bbe ospf6d: unlink router from vrf on deletion
Otherwise `ospf6_lookup_by_vrf_id` returns stale pointer.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-27 14:39:28 +03:00
Igor Ryzhov
67bde476b5
Merge pull request #8751 from LabNConsulting/chopps/ly2-mainline
build: libyangv2 is mainlined, update
2021-05-27 14:34:26 +03:00
Donatas Abraitis
b8fd5ba1d7
Merge pull request #8679 from louis-oui/bgp-summary-filter
bgpd: add show bgp summary filter by neighbor or AS
2021-05-27 13:57:14 +03:00
Christian Hopps
250335d47c build: libyangv2 is mainlined, update
Signed-off-by: Christian Hopps <chopps@gmail.com>
2021-05-27 06:44:39 -04:00
Igor Ryzhov
6e33da3839
Merge pull request #8738 from gromit1811/bugfix_ospf6_set_tag
ospf6d: Fix route map "set tag" command
2021-05-27 10:07:13 +03:00
Quentin Young
f4db21a5fb
Merge pull request #8707 from LabNConsulting/chopps/improve-grpc-req-checks 2021-05-26 20:11:53 +00:00
Rafael Zalamena
12a52d5551
Merge pull request #8736 from idryzhov/fix-ospf6-debug
ospf6d: fix debug message issues
2021-05-26 15:25:08 -03:00
Mark Stapp
1c8fe10c98
Merge pull request #8732 from idryzhov/fix-ospf6d-crashes
ospf6d: fix possible crashes
2021-05-26 11:32:33 -04:00
Louis Scalbert
8c1d4cd512 bgpd: add show bgp summary filter by neighbor or AS
Add ability to filter session on show bgp summary by neighbor or
remote AS:

ubuntu# show bgp summary ?
  neighbor     Show only the specified neighbor session
  remote-as    Show only the specified remote AS session
ubuntu# show bgp summary neighbor ?
  A.B.C.D   Neighbor to display information about
  WORD      Neighbor on BGP configured interface
  X:X::X:X  Neighbor to display information about
ubuntu# show bgp summary remote-as ?
  (1-4294967295)  AS number
  external        External (eBGP) AS sessions
  internal        Internal (iBGP) AS sessions

This patch includes the documentation and the topotest.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2021-05-26 16:16:08 +02:00
Martin Buck
45024ca042 ospf6d: Fix route map "set tag" command
So far, "set tag" was 99% implemented in ospf6d, but registration of the
hook functions was missing, causing "set tag" actions in route maps to be
ignored in ospf6d.

This commit adds the missing hook registration.

Signed-off-by: Martin Buck <mb-tmp-tvguho.pbz@gromit.dyndns.org>
2021-05-26 16:03:51 +02:00
Mark Stapp
1446730fd0
Merge pull request #8730 from idryzhov/staticd-distance
staticd: fix distance processing
2021-05-26 07:40:35 -04:00
Igor Ryzhov
c9ac777a7e ospf6d: fix debug message config write
Fix the following issues:
- if "send" is combined with "recv-hdr", only "send" is shown
- if "recv" is combined with "send-hdr", only "recv" is shown
- if both "send-hdr" and "recv-hdr" are enabled, "; header only" is shown

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-26 11:48:09 +03:00
Igor Ryzhov
63d00b52e7 ospf6d: fix invalid "no debug ospf6 message unknown"
The message is always shown in the config, because IS_OSPF6_DEBUG_MESSAGE
works incorrectly when negated because of missing outer brackets.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-26 11:45:07 +03:00
Martin Winter
5bf9f6467f
Merge pull request #8726 from donaldsharp/possible_ospf_fix
ospfd: Fix quick interface down up event handling in ospf
2021-05-26 02:38:43 +02:00
Igor Ryzhov
b4b6bd0017 ospf6d: fix possible crashes
OSPF6 instance may not exist when processing interface state change.
Do not execute processing steps that require an instance if an area is
not configured for an interface.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-25 21:59:46 +03:00
Donald Sharp
effee18744 ospfd: Fix quick interface down up event handling in ospf
When we get this sequence of events:

- zebra receives interface up, sends to ospf
- ospf receives intf up, processes( including neighbor formation and spf )
  and sends route to zebra for installation.
- zebra receives route for processing, schedules it too happen in the future
- zebra receives interface down event, sends to ospf
- zebra processes route X and marks it inactive because nexthop
  interface is down
- zebra receives interface up event, sends to ospf
- ospf receives both events and processes the change and decides
  that nothing has changed so it does not send any route change for X to zebra.

At this point zebra has a route from ospf that is marked as inactive, while
ospf believes that the route should be installed properly.

Modify the code such that on an interface down event, ospf marks the routes
as changed if the ifindex is being used for a nexthop, so that when ospf
is deciding if routes have changed post spf that it can just automatically
send that route down again if it still exists.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-05-25 14:43:40 -04:00
Mark Stapp
1efe743ac4
Merge pull request #8675 from wesleycoakley/pbr-table-range-core-fix
pbrd: implement sparse table lookup for nhg cache
2021-05-25 14:09:41 -04:00
Russ White
1db0247e2d
Merge pull request #8694 from chiragshah6/evpn_dev1
tools: fix bgp peer-group deconfiguration in frr-reload
2021-05-25 11:37:41 -04:00
Rafael Zalamena
72b9e0cf84
Merge pull request #8718 from taspelund/fix_pfx-tree_default
lib: fix handling of rmap prefix-tree default node
2021-05-25 12:31:03 -03:00
Quentin Young
7ab0717e34
Merge pull request #8723 from mjstapp/fix_show_werror
build: display Werror in configure output, if configured
2021-05-25 15:29:14 +00:00
Igor Ryzhov
e1ea6b20df staticd: fix distance processing
When the user adds the route + nexthop pair that already exists with a
different distance, we should replace it instead of adding a new one.

Likewise, when the user wants to delete the route + nexthop pair without
explicitly entering the distance, we should delete the route.

Fixes #8695.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-05-25 15:50:54 +03:00