proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-28 12:10:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
26,640 Commits 4 Branches 191 Tags 125 MiB
a0f9b0c7c8
Commit Graph

573 Commits

Author SHA1 Message Date
Igor Ryzhov
cb3fa0a612
Merge pull request #10124 from ton31337/feature/vty_json 2021-11-29 02:11:29 +03:00
Donatas Abraitis
f615ecb96d tools: Convert vty_out to vty_json for JSON 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-11-25 17:49:25 +02:00
Donatas Abraitis
15116b0069 tools: Replace prefix2str for JSON to %pFX 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-11-25 17:26:26 +02:00
Donatas Abraitis
8b3c84254d tools: Add coccinelle script to replace inet_ntop inside JSON 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-11-18 11:32:46 +02:00
Donald Sharp
8e653596c4 tools, vtysh: Remove final vestige of address-family evpn 
This was deprecated over a year ago now.  Let's finally
remove it from the system.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-11-17 07:49:56 -05:00
Donald Sharp
23ee09601b tools: Add another valgrind suppression for libyang 
More memory leaks from libyang that we can just ignore

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-11-15 15:06:58 -05:00
Quentin Young
6e09a5bfea tools: simplify excessively complex conditional 
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
 2021-11-12 13:37:09 -05:00
Quentin Young
d2863e4a6b tools: string literals -> comments 
Convert all floating string literals being used as comments, to comments

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
 2021-11-12 13:18:52 -05:00
David Lamparter
7c1803d0a0 tools: remove Linux kernel bits from checkpatch 
These aren't appropriate for use in FRR.  Among other things, this
enables running checkpatch by calling it in a git working tree with
`tools/checkpatch.pl -g origin/master..`

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2021-10-19 14:58:51 +02:00
David Lamparter
4d619e25ab tools: add iterators to checkpatch 
For the purpose of allowing the space in `frr_each (`, copy the list of
iterators from .clang-format and wire it up appropriately.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2021-10-19 14:58:51 +02:00
Anuradha Karuppiah
32dcd36d29 tools: upstream linter is recommending double quotes 
Replaced single quotes with double quotes for strings in
the frr_babeltrace.py utility.

Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
 2021-10-15 10:37:45 -07:00
Anuradha Karuppiah
b9c3be8be2 tools: add frr_babeltrace.py to /usr/lib/frr 
Make the script available as a part of the FRR package install for
ease of use.

Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
 2021-10-15 10:37:02 -07:00
Anuradha Karuppiah
a383bfc7c9 bgpd: lttng tracepoint for local events received from zebra 
TPs -
=====
root@ibm-2410a1-01:mgmt:~# lttng list --userspace |grep frr_bgp:evpn.*recv
      frr_bgp:evpn_local_l3vni_del_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_local_l3vni_add_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_local_macip_del_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_local_macip_add_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_local_vni_del_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_local_vni_add_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_mh_local_es_evi_del_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_mh_local_es_evi_add_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_mh_local_es_del_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_mh_local_es_add_zrecv (loglevel: TRACE_INFO (6)) (type: tracepoint)
root@ibm-2410a1-01:mgmt:~#

Sample output -
===============
1. ES
frr_bgp:evpn_mh_local_es_add_zrecv {'esi': '03:44:38:39:ff:ff:01:00:00:01', 'vtep': '27.0.0.15', 'active': 0, 'bypass': 0, 'df_pref': 50000}
frr_bgp:evpn_mh_local_es_del_zrecv {'esi': '03:44:38:39:ff:ff:01:00:00:01'}

2. ES-EVI
frr_bgp:evpn_mh_local_es_evi_add_zrecv {'esi': '03:44:38:39:ff:ff:01:00:00:01', 'vni': 1004}
frr_bgp:evpn_mh_local_es_evi_del_zrecv {'esi': '03:44:38:39:ff:ff:01:00:00:01', 'vni': 1001}

3. L2-VNI
frr_bgp:evpn_local_vni_add_zrecv {'vni': 1004, 'vtep': '27.0.0.15', 'mc_grp': '239.1.1.104', 'vrf': 97}

4. L3-VNI
frr_bgp:evpn_local_l3vni_add_zrecv {'vni': 4001, 'vrf': 87, 'svi_rmac': '24:8a:07:cc:aa:5f', 'vrr_rmac': '24:8a:07:cc:aa:5f', 'vtep': '27.0.0.15', 'filter': 0, 'svi_ifindex': 95, 'anycast_mac': 'n'
frr_bgp:evpn_local_l3vni_del_zrecv {'vni': 4003, 'vrf': 107}

5. MAC-IP
frr_bgp:evpn_local_macip_add_zrecv {'vni': 1003, 'mac': '00:02:00:00:00:04', 'ip': 'fe80::202:ff:fe00:4', 'flags': 4, 'seq': 0, 'esi': '03:44:38:39:ff:ff:01:00:00:02'}
frr_bgp:evpn_local_macip_del_zrecv {'vni': 1000, 'mac': '00:02:00:00:00:04', 'ip': '2001:fee1::4', 'state': 1}

Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
 2021-10-15 10:37:02 -07:00
Donatas Abraitis
c08050d6d1 tools: Catch double pointer of struct thread towards thread_add_* 
```
% spatch --sp-file tools/coccinelle/struct_thread_double_pointer.cocci --macro-file tools/cocci.h ./ 2>/dev/null
./lib/northbound_confd.c:429:65-66: Passed double 'struct thread' pointer
./lib/northbound_confd.c:1174:61-62: Passed double 'struct thread' pointer
./lib/northbound_sysrepo.c:543:69-70: Passed double 'struct thread' pointer
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-10-07 16:25:03 +03:00
Russ White
334d9d259f
Merge pull request #9731 from ton31337/fix/thread_null_set 
cleanup: struct thread = NULL
 2021-10-05 19:27:23 -04:00
Donatas Abraitis
83e66fdfd6 tools: Add coccinelle script to catch thread to NULL assignments 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-10-04 19:29:06 +03:00
Anuradha Karuppiah
23aa35ade5 bgpd: initial batch of evpn lttng tracepoints 
Low overhead bgp-evpn TPs have been added which push data out in a binary
format -
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
root@switch:~# lttng list --userspace |grep "frr_bgp:evpn"
      frr_bgp:evpn_mh_nh_rmac_zsend (loglevel: TRACE_DEBUG_LINE (13)) (type: tracepoint)
      frr_bgp:evpn_mh_nh_zsend (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_mh_nhg_zsend (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_mh_vtep_zsend (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_bum_vtep_zsend (loglevel: TRACE_INFO (6)) (type: tracepoint)
      frr_bgp:evpn_mac_ip_zsend (loglevel: TRACE_INFO (6)) (type: tracepoint)
root@switch:~#
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

In addition to the tracepoints a babeltrace python plugin for pretty
printing (binary data is converted into grepable strings). Sample usage -
frr_babeltrace.py trace_path

Sample tracepoint output -
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
1. frr_bgp: evpn_mac_ip_zsend
frr_bgp:evpn_mac_ip_zsend {'action': 'add', 'vni': 1007, 'mac': '00:02:00:00:00:04', 'ip': 'fe80::202:ff:fe00:4', 'vtep': '27.0.0.15', 'esi': '03:44:38:39:ff:ff:01:00:00:02'}

2. frr_bgp: evpn_mh_vtep_zsend
frr_bgp:evpn_mh_vtep_zsend {'action': 'add', 'esi': '03:44:38:39:ff:ff:01:00:00:02', 'vtep': '27.0.0.16'}

3. frr_bgp: evpn_mh_nhg_zsend
frr_bgp:evpn_mh_nhg_zsend {'action': 'add', 'type': 'v4', 'nhg': 74999998, 'esi': '03:44:38:39:ff:ff:01:00:00:02', 'vrf': 85}

4. frr_bgp: evpn_mh_nh_zsend
frr_bgp:evpn_mh_nh_zsend {'nhg': 74999998, 'vtep': '27.0.0.16', 'svi': 93}

5. frr_bgp: evpn_mh_nh_rmac_zsend
frr_bgp:evpn_mh_nh_rmac_zsend {'action': 'add', 'vrf': 85, 'nh': '::ffff:1b00:12', 'rmac': '00:02:00:00:00:50'}
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
 2021-10-01 09:02:25 -07:00
Donatas Abraitis
94ca37e0a9 tools: Add coccinelle script to catch \n or \r at the end of zlog_* 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-09-27 15:21:52 +03:00
Donald Sharp
cd8aaf076e tools: Add some new suppressions 
Bunch of new stuff came in w/ the libyang2 upgrade that needs
to be suppressed.  Make it so.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-09-21 07:54:54 -04:00
Quentin Young
32acb4a7ad
Merge pull request #9497 from opensourcerouting/cli-better-no 2021-09-09 12:22:53 -04:00
Christian Hopps
a53c08bc13 tests: cleanup: rerun changed files through black 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-09-04 09:04:47 -04:00
Christian Hopps
4953ca977f tests: cleanup - remove unused imports 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-09-04 09:04:47 -04:00
Christian Hopps
77a7a87cdd tools: move frr-reload.py to python3 explicitly 
We already, reasonably, require python3 elsewhere. Do so here, and reap some
benefit.

Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-09-04 09:04:47 -04:00
David Lamparter
b8f9523597
Merge pull request #9340 from stefreak/patch-1 
tools: fix frr pathspace folder permissions
 2021-09-02 13:24:44 +02:00
David Lamparter
90c8406c20 lib: add ![...] syntax for easy "no" forms 
This allows defining a CLI command like this:
  `[no] some setting ![VALUE]`
with VALUE being optional for the "no" form, but required for the
positive form.  It's just a `[...]` where the empty branch can only be
taken for commands starting with `no`.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2021-08-26 21:03:44 +02:00
Igor Ryzhov
fc43980f25 tools: significantly simplify frr-reload context processing 
Currently, in frr-reload we:
- store a list of single-line context keywords which needs to be
  frequently updated,
- have a separate "if" clause for every node and subnode we have in FRR.

Instead, we can store the tree of all known FRR nodes. This tree needs
to be updated whenever we add a new node, which is not frequent. And,
most importantly, it allows us to write node-agnostic code and save more
than 250 LOC.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-23 22:08:20 +03:00
Igor Ryzhov
541af473f9
Merge pull request #9341 from LabNConsulting/chopps/ospf-support-bundle 
tools: add ospfd support bundle commands
 2021-08-18 14:40:08 +03:00
Donald Sharp
061bf350dd
Merge pull request #9271 from opensourcerouting/workflow-release-sched 
workflow: document release scheduling discussed
 2021-08-14 09:06:23 -04:00
David Lamparter
dc1c0bc2b3 workflow: document release scheduling discussed 
As discussed in the weekly meeting today, this is what we're trying to
work with for the time being.

(Date calculator included as a bonus goodie ;)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2021-08-11 16:37:46 +02:00
Christian Hopps
36cd3e81e8 tools: add ospfd support bundle commands 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-08-10 07:39:18 +00:00
Christian Hopps
cb04c8e906
Merge pull request #9219 from mobash-rasool/ospfv2-bug-fixes 
tools: Add ospfv2 and ospfv3 commands in support bundle
 2021-08-10 03:14:43 -04:00
Steffen Neubauer
0fc6a5f8ed tools: fix frr pathspace folder permissions 
The pathspace folder in /var/run needs the x permission for the group too

Otherwise vtysh fails when running it with groups frrvty and frr:

    $ vtysh -N gateway
    % Can't open configuration file /etc/frr/gateway/vtysh.conf due to 'Permission denied'.
    vtysh_connect(/var/run/frr/gateway/zebra.vty): stat = Permission denied

Signed-off-by: Steffen Neubauer <s.neubauer@syseleven.de>
 2021-08-09 13:54:58 +02:00
Donald Sharp
a66413a53b
Merge pull request #8870 from anlancs/master-fix-reload-service 
tools: add "vni" to oneline list
 2021-08-08 07:21:10 -04:00
Mobashshera Rasool
54d8e033f3 tools: Add ospfv3 commands in the support bundle 
Co-authored-by: Yash Ranjan <ranjyany@vmware.com>
Signed-off-by: Yash Ranjan <ranjyany@vmware.com>
Co-authored-by: Mobashshera Rasool <mrasool@vmware.com>
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
 2021-07-30 05:14:26 -07:00
Mobashshera Rasool
34e96abf2e tools: Add ospfd commands in support bundle 
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
 2021-07-30 03:52:45 -07:00
Christian Hopps
be4a9b0570 tools: improve frr-reload.py delta file creation 
- Remove incorrect requirement for `service integrated-vtysh-config`
  when producing a delta.
- Add `--test-reset` option which suppresses non-parseable lines from the
  produced delta
- Use new features in common_config.py

Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-07-15 22:12:01 -04:00
Donatas Abraitis
107df351c6 tools: Add coccinelle script for hash compare functions NULL values 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-07-13 08:49:38 +03:00
Donald Sharp
acb4c44ef8
Merge pull request #8942 from ton31337/fix/cleanups_2 
Another round of cleanup
 2021-07-06 09:47:41 -04:00
Donald Sharp
432bb280fb
Merge pull request #8939 from LabNConsulting/chopps/sup-bund-fixes 
Speedup support bundles, fix bugs, add CLI timestamp
 2021-07-06 07:58:19 -04:00
Igor Ryzhov
c54e2a8144 tools: Simplify the script to build Debian binary package 
Signed-off-by: Ondřej Surý <ondrej@sury.org>
 2021-07-03 17:02:37 +02:00
Ondřej Surý
dfbc6c046e debian: Add support for Debian bullseye to the packaging script 
The Debian bullseye is frozen now, so this adds support to this
Debian release to the packaging script.

Signed-off-by: Ondřej Surý <ondrej@sury.org>
 2021-07-03 17:02:37 +02:00
Ondřej Surý
9ea548cf3c debian: Fix the debian packaging script to build on non-default branch 
The packaging script would fail to run on non-master branch, fix that
by pulling original branch name.

Signed-off-by: Ondřej Surý <ondrej@sury.org>
 2021-07-03 17:02:37 +02:00
Ondřej Surý
223766ead4 debian: Update the tools/build-debian-package.sh to be example build script 
Signed-off-by: Ondřej Surý <ondrej@sury.org>
 2021-07-03 17:02:37 +02:00
Ondřej Surý
aa1e17f5ca debian: Remove now obsolete tarsource.sh script 
Signed-off-by: Ondřej Surý <ondrej@sury.org>
 2021-07-03 17:02:37 +02:00
Ondřej Surý
06417e9f18 debian: Remove the changelog-auto automation in favor of dch 
Signed-off-by: Ondřej Surý <ondrej@sury.org>
 2021-07-03 17:02:37 +02:00
Ondřej Surý
bcd053ee8d debian: Update tools/build-debian-package.sh to use git-buildpackage 
Signed-off-by: Ondřej Surý <ondrej@sury.org>
 2021-07-03 17:02:37 +02:00
Ondřej Surý
25785834af debian: Adjust tarsource.sh to use native debian/changelog 
Signed-off-by: Ondřej Surý <ondrej@sury.org>
 2021-07-03 17:02:37 +02:00
Christian Hopps
5417cc2de3 tests: collect support bundle data in parallel, fix bugs 
Speedup (large topo): OLD: ~6 minutes NEW: ~1 second.
  (when paired with common_config.py changes)
- Collect each "proc" support in parallel
- For each "proc" only call vtysh once with all commands

Bug fixes:
- output was broken, a dump of python "repr" format of str.

Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-06-30 15:46:10 +00:00
anlancs
470d316e3e tools: add "vni" to oneline list 
Add "vni" into oneline list.
Additionally, keep them in order in oneline list.

Signed-off-by: anlancs <anlan_cs@tom.com>
 2021-06-30 16:28:37 +08:00
Donatas Abraitis
63f7a3b910 tools: Add coccinelle script for checking against XMALLOC/XCALLOC NULLs 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-06-29 22:27:50 +03:00