proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-11-04 06:38:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
23,351 Commits 4 Branches 191 Tags 114 MiB
7c94e3d606
Commit Graph

23351 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Igor Ryzhov
7f9c68df53 eigrpd: fix dependency on operational state in cli 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-03-16 17:45:06 +03:00
Igor Ryzhov
77a42534c1 eigrpd: fix xpaths 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-03-16 17:44:25 +03:00
Donald Sharp
474cfe4a6c bgpd: Set metric appropriately for the bnc for a v6 LL address 
The v6 LL commit 8761cd6ddb

incorrectly was setting the metric value to 1 for the underlying
connected interface.  Modify the code to use a metric value of 0
instead of 1 that now represents the actual metric value that
was originally passed up.

This was noticed when the `show bgp ipv4 uni` command was
inserting a `(metric 1)` into output where before it was not.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-16 10:35:40 -04:00
Donald Sharp
877155ed06 sharpd: Dump metric received for the reachability 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-16 10:35:40 -04:00
Igor Ryzhov
f1825d571e bfdd: warn users about echo-mode restrictions 
Echo-mode implementation is currently broken. Instead of sending packets
to it's own address, bfdd is sending echo packets to the peer's address.
It may seem to work when testing between two FRR instances, because FRR
loops back such packets, but no other implementation is supposed to do
that.

Let's warn users that the current implementation works only between two
FRR instances.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-03-16 17:25:06 +03:00
Igor Ryzhov
5aeb216ea5 bfdd: fix starting echo receive timer 
Currently this timer is only started when we receive the first echo
packet. If we never receive the packet, the timer is never started and
the user falsely assumes that echo function is working.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-03-16 17:25:06 +03:00
Karen Schoener
eb44a85454 tests: update LDP SNMP topotest to walk mib objects that are statistics 
Signed-off-by: Karen Schoener <karen@voltanet.io>
 2021-03-16 10:23:34 -04:00
Karen Schoener
d4d6e7d87e ldpd: Add support for the read-only snmp mib objects that are statistics 
Add support for the read-only snmp mib objects as described in RFC 3815
that are statistics.

Signed-off-by: Lynne Morrison <lynne@voltanet.io>
Signed-off-by: Karen Schoener <karen@voltanet.io>
 2021-03-16 10:23:34 -04:00
Igor Ryzhov
81ef5048dd
Merge pull request #8260 from volta-networks/fix_isis_snmp_test 
test: fix isis-snmp test
 2021-03-16 17:20:35 +03:00
lynne
83543d89ae test: fix isis-snmp test 
Remove ifindex values being tested because it can change
between runs of the test.

Signed-off-by: Lynne Morrison <lynne@voltanet.io>
 2021-03-16 08:00:41 -04:00
Donatas Abraitis
293b8b9529
Merge pull request #8214 from chiragshah6/mdev 
tools: frr-reload refine error handling
 2021-03-16 09:28:03 +02:00
David Lamparter
c634f5da24
Merge pull request #8254 from donaldsharp/various_fixes 2021-03-16 07:41:35 +01:00
Donald Sharp
531d4171c7 pimd: Fix clang issue with -Waddress-of-packed-member 
Recent change in commit: 6b73800ba2

Caused this error to pop up in pim_igmp_mtrace.c:

error: taking address of packed member 'rsp_addr' of class or structure 'igmp_mtrace' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]

Follow the pattern used in the code to solve this problem for clang

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-15 11:46:44 -04:00
Donald Sharp
d588b995f9 bgpd: use appropriate printf formatter for some uint32_t 
newm and existm are uint32_t so let's use %u instead of %d
to print them out.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-15 10:56:08 -04:00
Donald Sharp
710b3613ff
Merge pull request #8234 from reubendowle/fixes/nhrp-trafic-indication 
nhrpd: Set hop count to 1 in traffic indication
 2021-03-15 09:45:30 -04:00
Mark Stapp
cc01c03434
Merge pull request #8230 from donaldsharp/flex_more 
more switchover to using our builtin printf functionality
 2021-03-15 08:36:23 -04:00
Donatas Abraitis
8b87b2f4f6
Merge pull request #8220 from mjstapp/bgp_notify_race 
bgpd: handle socket read errors in the main pthread
 2021-03-15 13:30:00 +02:00
Igor Ryzhov
cbb542af38
Merge pull request #8242 from opensourcerouting/format-warning-fix 
bgpd: fix wrong debug format
 2021-03-15 14:28:51 +03:00
Rafael Zalamena
ff592ac2f2
Merge pull request #8231 from idryzhov/bfd-admin-down 
bfdd: make sessions administratively up by default
 2021-03-15 07:38:18 -03:00
Renato Westphal
bfa46e3bdd
Merge pull request #8147 from volta-networks/feat_ldp_snmp_without_stats 
ldpd: Add support for read-only snmp mib objects (excluding statistics)
 2021-03-14 22:25:00 -03:00
Renato Westphal
e1908ceb42
Merge pull request #7945 from volta-networks/feat_isis_snmp 
isisd: add support for read-only snmp mibs objects
 2021-03-14 22:14:27 -03:00
Renato Westphal
70d453d2a0
Merge pull request #8160 from idryzhov/fix-show-yang-oper 
lib: fix crash when iterating over nb operational data
 2021-03-14 21:04:37 -03:00
David Lamparter
ad6f7449ef *: remove remaining severity prefixes 
Having a "warning:" prefix on a debug message is particularly dumb...

Signed-off-by: David Lamparter <equinox@diac24.net>
 2021-03-14 22:56:07 +01:00
David Lamparter
5d27875b7d zebra: move up prefix2str call in rib dump 
Signed-off-by: David Lamparter <equinox@diac24.net>
 2021-03-14 22:56:07 +01:00
David Lamparter
ef7b8be459 zebra: use printfrr exts in EVPN/VXLAN code 
Signed-off-by: David Lamparter <equinox@diac24.net>
 2021-03-14 22:56:07 +01:00
David Lamparter
5e9f9adbb4 fpm: use printfrr exts 
Signed-off-by: David Lamparter <equinox@diac24.net>
 2021-03-14 22:56:07 +01:00
David Lamparter
5145a17261 *: fix printf extension types 
Some mistakes have crept in again.

Signed-off-by: David Lamparter <equinox@diac24.net>
 2021-03-14 22:56:07 +01:00
Donald Sharp
a0ee6f3224 lib: Convert to builtin printf functionality 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-14 22:56:07 +01:00
Donald Sharp
d47b448de5 ospf6d: Convert to use builtin printf functionality 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-14 22:56:07 +01:00
Donald Sharp
4f278784d6 eigrpd: Convert to using our builtin printf stuff 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-14 22:56:07 +01:00
Donald Sharp
6b73800ba2 pimd: Use builtin printf functionality 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-14 22:56:07 +01:00
Donald Sharp
5c997d2916 babeld: We do not need to put Warning into our warning messages 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-14 22:56:07 +01:00
Donald Sharp
6dd43a35f3 sharpd: Convert over to using builtin printf functionality 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-14 22:56:07 +01:00
Igor Ryzhov
59dad8137e bfdd: make sessions administratively up by default 
Current behavior is inconsistent. When the session is created by another
daemon, it is up by default. When we later configure peer in bfdd, the
session is still up, but the NB layer thinks that it is down.

More than that, even when the session is created in bfdd using peer
command, it is created in DOWN state, not ADM_DOWN. And it actually
starts sending and receiving packets. The sessions is marked with
SHUTDOWN flag only when we try to reconfigure some parameter. This
behavior is also very unexpected.

Fixes #7780.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-03-15 00:44:08 +03:00
Gaurav Goyal
6f8817b4cf nhrpd: Set hop count to 1 in traffic indication 
If hop count is 0, this causes Cisco routers to reject the traffic indication
as invalid. This appears to be a Cisco bug, and has been observed in processing
of registration packets in the past. That problem was covered in issue #951

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
 2021-03-15 10:04:43 +13:00
Donatas Abraitis
65c0fc12b6 doc: Add show [ip] bgp peer-group [json] command 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-03-14 19:25:02 +02:00
Donatas Abraitis
6f4eacf315 bgpd: Add JSON output for show ip bgp peer-group command 
```
exit1-debian-9# show bgp peer-group

BGP peer-group test, remote AS 123
  Peer-group type is external
  Configured address-families: IPv4 Unicast; IPv6 Unicast;
  1 IPv4 listen range(s)
    192.168.100.0/24
  2 IPv6 listen range(s)
    2001:db8:1::/64
    2001:db8:2::/64
  Peer-group members:
    192.168.200.1  Active
    2001:db8::1  Active

BGP peer-group test3
  Peer-group type is external
  Configured address-families: IPv4 Unicast;
exit1-debian-9#
exit1-debian-9# show bgp peer-group json
{
  "test":{
    "remoteAs":123,
    "type":"external",
    "addressFamiliesConfigured":[
      "IPv4 Unicast",
      "IPv6 Unicast"
    ],
    "dynamicRanges":{
      "IPv4":{
        "count":1,
        "ranges":[
          "192.168.100.0\/24"
        ]
      },
      "IPv6":{
        "count":2,
        "ranges":[
          "2001:db8:1::\/64",
          "2001:db8:2::\/64"
        ]
      }
    },
    "members":{
      "192.168.200.1":{
        "status":"Active"
      },
      "2001:db8::1":{
        "status":"Active"
      }
    }
  },
  "test3":{
    "type":"external",
    "addressFamiliesConfigured":[
      "IPv4 Unicast"
    ]
  }
}
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-03-14 19:25:02 +02:00
Rafael Zalamena
e12114f2f7 doc: update the FRR format table 
Let other developers know that we have `%pIA` to print `struct ipaddr *`.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-03-14 14:07:52 -03:00
Rafael Zalamena
2dd0dde70d bgpd: fix wrong debug format 
Use `%pIA` instead of `%pI4` for `struct ipaddr *`.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-03-14 14:07:52 -03:00
Igor Ryzhov
e319ed4c49
Merge pull request #8244 from opensourcerouting/ci-fix-tests 
topotests: fix some recent test failures
 2021-03-14 20:05:26 +03:00
Rafael Zalamena
5b2906f4b4 topotests: temporary disable test assert 
The test has been failing often recently and it is causing some false
positives for unrelated PRs.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-03-14 10:15:20 -03:00
Rafael Zalamena
296951b598 topotests: remove some interface index check 
Don't expect the interface index to be always the same.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-03-12 17:33:23 -03:00
Rafael Zalamena
0085000b9e topotests: remove some FRR version checks 
We version the tests with the source code so we should no longer attempt
to support old versions in development branch.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-03-12 17:32:12 -03:00
Olivier Dugeon
e81f3c69b3
Merge pull request #8085 from volta-networks/isis_label_blocks 
isisd: configure SRGB and SRLB together
 2021-03-12 18:26:36 +01:00
Olivier Dugeon
7c760bb60d
Merge pull request #7827 from GalaxyGorilla/ospf_sr_topotests 
tests: enhance OSPF SR topotests
 2021-03-12 17:36:07 +01:00
Igor Ryzhov
c9912e0ceb
Merge pull request #8241 from Jafaral/first_p 2021-03-12 10:21:20 +03:00
Jafar Al-Gharaibeh
d532dd6d6a Revert "zebra: Remove first_p which is never used" 
This reverts commit 8617eb7c5f.
 2021-03-12 01:02:25 -06:00
Jafar Al-Gharaibeh
c0290e0b62
Merge pull request #8239 from donaldsharp/first_p 
zebra: Remove `first_p` which is never used
 2021-03-11 23:20:39 -06:00
Donald Sharp
8617eb7c5f zebra: Remove first_p which is never used 
Remove dead code.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-03-11 21:22:53 -05:00
Jafar Al-Gharaibeh
b65540e99a
Merge pull request #8223 from mjstapp/fix_pim_nb_sa 
pimd: fix coverity SA warning in pim_nb_config.c
 2021-03-11 10:27:32 -06:00